[issue39579] Attribute node in a decorator has wrong end_col_offset

2020-07-01 Thread Francis Herne


Francis Herne  added the comment:

Sorry, on further inspection it was the other AST range change 
https://bugs.python.org/issue39474 , not this one.

--

___
Python tracker 
<https://bugs.python.org/issue39579>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39579] Attribute node in a decorator has wrong end_col_offset

2020-07-01 Thread Francis Herne


Francis Herne  added the comment:

Note: this change causes a regression in kdev-python because our code was based 
on (and worked around) the long-standing previous behaviour; it produces broken 
results given the 'fixed' offset.

I shall have to write a patch with a version-check before our next stable 
release.

While the new behaviour is more logical, I'm not convinced that deliberate API 
breakage in a stable release - for something that's not a recent regression - 
was a good idea.

--
nosy: +flherne

___
Python tracker 
<https://bugs.python.org/issue39579>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32911] Doc strings no longer stored in body of AST

2018-04-12 Thread Francis Herne

Francis Herne <m...@flherne.uk> added the comment:

Note:

Because this also applies to module-level docstrings, a rather strange effect 
that, for example, `ast.parse("'foo'")` is now an empty module.

While the root node is always an instance of `ast.Module`, in practice 
`ast.parse()` is often used with smaller fragments of source code that don't 
directly correspond to a complete module, and this behaviour makes no sense in 
such cases.

The resulting bug in kdev-python took a while to track down (because I had no 
immediate reason to suspect this change), and will be somewhat awkward to 
workaround.

I would prefer that this be reverted; it's likely to break a variety of users 
in strange ways.

--
nosy: +flherne

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32911>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com