[issue40358] pathlib's relative_to should behave like os.path.relpath

[Sanyam Khurana]

Change by Sanyam Khurana :


--
nosy: +CuriousLearner

___
Python tracker 
<https://bugs.python.org/issue40358>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37854] [xmlrpc.client.ServerProxy] It does not correctly parse the URL with basic authentication.

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Closed Issue 37853 as a duplicate.

Adding Fatih's comment from there for urllib.parse.urlparse


-

No problem for these:
  "http://localhost:9100;
  "http://user:password@localhost:9100;

But, these are problematic:
  "http://use#r:password@localhost:9100;
  "http://user:pass#word@localhost:9100;


```
from urllib.parse import urlparse

url = "http://us#er:123@localhost:9001/RPC2;
u = urlparse(url)
print(u)
# ParseResult(scheme='http', netloc='us', path='', params='', query='', 
fragment='er:123@localhost:9001/RPC2')
```


--

--
nosy: +CuriousLearner
versions:  -Python 3.5, Python 3.6

___
Python tracker 
<https://bugs.python.org/issue37854>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37853] [urllib.parse.urlparse] It does not correctly parse the URL with basic authentication.

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Duplicate of Issue 37854

Fatih,

Thank you for your report. I'm marking this one as a duplicate of another. 
Request you to not create multiple issues at once for the same thing.

Thank you!

--
nosy: +CuriousLearner
resolution:  -> duplicate
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue37853>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37775] update doc of compileall

[Sanyam Khurana]

Sanyam Khurana  added the comment:

I've checked and approved this PR.

This needs a core-review now.

Thanks, Hai for your contribution.

--
nosy: +CuriousLearner, Mariatta

___
Python tracker 
<https://bugs.python.org/issue37775>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37256] urllib.request.Request documentation erroneously refers to the "final two"

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Thanks for the bug report Alan & for the PR Ngalim!

I've checked the current docs and this is a valid bug.

I've also reviewed the Pull request and it looks good to me.

@Mariatta, @Senthil can you please have a look at this?

Many thanks!

--
nosy: +CuriousLearner, Mariatta, orsenthil
versions:  -Python 3.5, Python 3.6

___
Python tracker 
<https://bugs.python.org/issue37256>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37785] argparse uses %s in gettext calls causing xgettext warnings

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Hi Eric,

This is with reference to https://bugs.python.org/issue10528.

I've looked at the PR and it's ready for a core-review: 
https://github.com/python/cpython/pull/15161

Can you please take a look at this?

Many thanks!

--
nosy: +bethard, eric.araujo

___
Python tracker 
<https://bugs.python.org/issue37785>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26543] [EASY] imaplib noop Debug: bytes vs Unicode bug in debug mode

[Sanyam Khurana]

Change by Sanyam Khurana :


--
pull_requests: +14935
pull_request: https://github.com/python/cpython/pull/15206

___
Python tracker 
<https://bugs.python.org/issue26543>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37819] as_integer_ratio() missing from fractions.Fraction()

[Sanyam Khurana]

Change by Sanyam Khurana :


--
nosy: +CuriousLearner

___
Python tracker 
<https://bugs.python.org/issue37819>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19692] Rename Py_SAFE_DOWNCAST

[Sanyam Khurana]

Change by Sanyam Khurana :


--
nosy: +CuriousLearner
versions: +Python 3.7, Python 3.8, Python 3.9 -Python 3.4

___
Python tracker 
<https://bugs.python.org/issue19692>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34331] Incorrectly pluralized abstract class error message

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Adding 3.9 to this bug. I've reviewed the PR and it looks good to me.

--
nosy: +CuriousLearner
versions: +Python 3.9

___
Python tracker 
<https://bugs.python.org/issue34331>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32912] Raise non-silent warning for invalid escape sequences

[Sanyam Khurana]

Change by Sanyam Khurana :


--
nosy: +CuriousLearner

___
Python tracker 
<https://bugs.python.org/issue32912>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26543] [EASY] imaplib noop Debug: bytes vs Unicode bug in debug mode

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Hey ankostis, 

Please let us know if you've time to complete the PR.

Thank you :)

--

___
Python tracker 
<https://bugs.python.org/issue26543>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26543] [EASY] imaplib noop Debug: bytes vs Unicode bug in debug mode

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Removing 3.5 as it is in security fix mode. Also, the PR just contains the test 
case that would trigger the condition and not the actual code.

--
nosy: +CuriousLearner
stage:  -> patch review
versions: +Python 3.7, Python 3.8, Python 3.9 -Python 3.5

___
Python tracker 
<https://bugs.python.org/issue26543>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37785] argparse uses %s in gettext calls causing xgettext warnings

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Hi Jakub,

Welcome and thank you for contributing. I've added a suggestion on your pull 
request.


Python 3.6 and Python 3.5 are in security fixes stage, so I've removed those 
tags from this bug.

--
nosy: +CuriousLearner
type:  -> behavior
versions:  -Python 3.5, Python 3.6

___
Python tracker 
<https://bugs.python.org/issue37785>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16837] Number ABC can be instantiated

[Sanyam Khurana]

Sanyam Khurana  added the comment:

I'm changing the versions to Python 3.8 and 3.9 for this bug.

--
versions: +Python 3.8, Python 3.9 -Python 3.4, Python 3.5

___
Python tracker 
<https://bugs.python.org/issue16837>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16837] Number ABC can be instantiated

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Hi Alexander,

Can you please address the reviews and turn this patch into a GitHub PR, please?

--
nosy: +CuriousLearner

___
Python tracker 
<https://bugs.python.org/issue16837>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12128] Allow an abc.abstractproperty to be overridden by an instance data attribute

[Sanyam Khurana]

Sanyam Khurana  added the comment:

I was trying to search the mailing list archives for the URL posted by Eric: 
http://mail.python.org/pipermail/python-list/2011-May/1272604.html

But I couldn't find it. Also that URL shows 404.

Eric, is it possible for you to post the correct link?

--
nosy: +CuriousLearner

___
Python tracker 
<https://bugs.python.org/issue12128>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36168] DOC: Fix capitalization in string.rst

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Backport successfully completed. Marking this as fixed.

Congrats on your first patch, Krishna!

Thank you, everyone!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue36168>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36168] DOC: Fix capitalization in string.rst

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Mariatta, I see it also needs a backport to 3.8

We can close it once the backport is completed.

--
nosy: +CuriousLearner

___
Python tracker 
<https://bugs.python.org/issue36168>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21914] Create unit tests for Turtle guionly

[Sanyam Khurana]

Change by Sanyam Khurana :


--
pull_requests: +13409

___
Python tracker 
<https://bugs.python.org/issue21914>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36822] Minor grammatical fix in glossary.rst

[Sanyam Khurana]

Change by Sanyam Khurana :


--
pull_requests: +13170

___
Python tracker 
<https://bugs.python.org/issue36822>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18387] Add 'symbols' link to pydoc's html menu bar.

[Sanyam Khurana]

Change by Sanyam Khurana :


--
pull_requests: +13135
stage:  -> patch review

___
Python tracker 
<https://bugs.python.org/issue18387>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36836] Test Suite not working on 3.4, 3.5 on MacOS Mojave

[Sanyam Khurana]

Sanyam Khurana  added the comment:

The issue does not seem to be on 3.7 and master branch, so I'm closing the bug 
as well as the pull request.

--
resolution:  -> out of date
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.5, Python 3.6 -Python 3.8

___
Python tracker 
<https://bugs.python.org/issue36836>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36836] Test Suite not working on 3.4, 3.5 on MacOS Mojave

[Sanyam Khurana]

Change by Sanyam Khurana :


--
keywords: +patch
pull_requests: +13083
stage:  -> patch review

___
Python tracker 
<https://bugs.python.org/issue36836>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36836] Test Suite not working on 3.4, 3.5 on MacOS Mojave

[Sanyam Khurana]

Sanyam Khurana  added the comment:

I had to clean-up my build a bit, and it seems like it's not really happening 
on 3.6, but it is still an issue with 3.4, 3.5, etc.

I've added a PR for 3.5 to resolve the issue.

--
assignee:  -> CuriousLearner
title: Test Suite not working on 3.4, 3.5, 3.6, 3.7 on MacOS Mojave -> Test 
Suite not working on 3.4, 3.5 on MacOS Mojave
versions:  -Python 3.6

___
Python tracker 
<https://bugs.python.org/issue36836>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36836] Test Suite not working on 3.4, 3.5, 3.6, 3.7 on MacOS Mojave

[Sanyam Khurana]

Change by Sanyam Khurana :


--
title: Test Suite not working on 3.4 and 3.5 on MacOS Mojave -> Test Suite not 
working on 3.4, 3.5, 3.6, 3.7 on MacOS Mojave

___
Python tracker 
<https://bugs.python.org/issue36836>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36836] Test Suite not working on 3.4 and 3.5 on MacOS Mojave

[Sanyam Khurana]

New submission from Sanyam Khurana :

I was testing this issue: https://bugs.python.org/issue10598

I checked both Python 3.4, 3.5, 3.6 and tagged commit v3.7.0 but I'm not able 
to run the test suite on any of them. I'm currently working on MacOS Mojave 
10.14.4

I landed on issue https://bugs.python.org/issue36432 which was superseeded by 
https://bugs.python.org/issue34602 while searching for the error I got:

```
$ make test 
 
running build
running build_ext
building '_ssl' extension
gcc -Wno-unused-result -Wsign-compare -g -O0 -Wall -Wstrict-prototypes -std=c99 
-Wextra -Wno-unused-result -Wno-unused-parameter 
-Wno-missing-field-initializers -I./Include -I. -I/usr/local/include 
-I/Users/sanyamkhurana/cpython/Include -I/Users/sanyamkhurana/cpython -c 
/Users/sanyamkhurana/cpython/Modules/_ssl.c -o 
build/temp.macosx-10.14-x86_64-3.6-pydebug/Users/sanyamkhurana/cpython/Modules/_ssl.o
gcc -bundle -undefined dynamic_lookup 
build/temp.macosx-10.14-x86_64-3.6-pydebug/Users/sanyamkhurana/cpython/Modules/_ssl.o
 -L/usr/local/lib -lssl -lcrypto -o 
build/lib.macosx-10.14-x86_64-3.6-pydebug/_ssl.cpython-36dm-darwin.so
ld: library not found for -lssl
clang: error: linker command failed with exit code 1 (use -v to see invocation)
building '_hashlib' extension
gcc -Wno-unused-result -Wsign-compare -g -O0 -Wall -Wstrict-prototypes -std=c99 
-Wextra -Wno-unused-result -Wno-unused-parameter 
-Wno-missing-field-initializers -I./Include -I. -I/usr/local/include 
-I/Users/sanyamkhurana/cpython/Include -I/Users/sanyamkhurana/cpython -c 
/Users/sanyamkhurana/cpython/Modules/_hashopenssl.c -o 
build/temp.macosx-10.14-x86_64-3.6-pydebug/Users/sanyamkhurana/cpython/Modules/_hashopenssl.o
gcc -bundle -undefined dynamic_lookup 
build/temp.macosx-10.14-x86_64-3.6-pydebug/Users/sanyamkhurana/cpython/Modules/_hashopenssl.o
 -L/usr/local/lib -lssl -lcrypto -o 
build/lib.macosx-10.14-x86_64-3.6-pydebug/_hashlib.cpython-36dm-darwin.so
ld: library not found for -lssl
clang: error: linker command failed with exit code 1 (use -v to see invocation)
building '_tkinter' extension
gcc -Wno-unused-result -Wsign-compare -g -O0 -Wall -Wstrict-prototypes -std=c99 
-Wextra -Wno-unused-result -Wno-unused-parameter 
-Wno-missing-field-initializers -DWITH_APPINIT=1 
-I/System/Library/Frameworks/Tcl.framework/Headers 
-I/System/Library/Frameworks/Tcl.framework/Versions/Current/PrivateHeaders 
-I/System/Library/Frameworks/Tk.framework/Headers 
-I/System/Library/Frameworks/Tk.framework/Versions/Current/PrivateHeaders 
-I/usr/X11R6/include -I./Include -I. -I/usr/local/include 
-I/Users/sanyamkhurana/cpython/Include -I/Users/sanyamkhurana/cpython -c 
/Users/sanyamkhurana/cpython/Modules/_tkinter.c -o 
build/temp.macosx-10.14-x86_64-3.6-pydebug/Users/sanyamkhurana/cpython/Modules/_tkinter.o
 -framework Tk
clang: warning: -framework Tk: 'linker' input unused 
[-Wunused-command-line-argument]
In file included from /Users/sanyamkhurana/cpython/Modules/_tkinter.c:50:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/tk.h:78:11:
 fatal error: 
  'X11/Xlib.h' file not found
#   include 
^~~~
1 error generated.

Python build finished successfully!
The necessary bits to build these optional modules were not found:
_dbm  _sqlite3  nis
ossaudiodev   spwd  zlib   
To find the necessary bits, look in setup.py in detect_modules() for the 
module's name.

The following modules found by detect_modules() in setup.py, have been
built by the Makefile instead, as configured by the Setup files:
atexitpwd   time   

Failed to build these modules:
_hashlib  _ssl  _tkinter   

running build_scripts
copying and adjusting /Users/sanyamkhurana/cpython/Tools/scripts/pydoc3 -> 
build/scripts-3.6
copying and adjusting /Users/sanyamkhurana/cpython/Tools/scripts/idle3 -> 
build/scripts-3.6
copying and adjusting /Users/sanyamkhurana/cpython/Tools/scripts/2to3 -> 
build/scripts-3.6
copying and adjusting /Users/sanyamkhurana/cpython/Tools/scripts/pyvenv -> 
build/scripts-3.6
changing mode of build/scripts-3.6/pydoc3 from 644 to 755
changing mode of build/scripts-3.6/idle3 from 644 to 755
changing mode of build/scripts-3.6/2to3 from 644 to 755
changing mode of build/scripts-3.6/pyvenv from 644 to 755
renaming build/scripts-3.6/pydoc3 to build/scripts-3.6/pydoc3.6
renaming build/scripts-3.6/idle3 to build/scripts-3.6/idle3.6
renaming build/scripts-3.6/2to3 to build/scripts-3.6/2to3-3.6
renaming build/scripts-3.6/pyvenv to build/scripts-3.6/pyvenv-3.6
./python.exe -E -c 'import sys ; from sysconfig import get_platform ; 
print("%s-%d.%d" % (get_platform(), *sys.version_info[:2]))' >platform
./python.exe  ./Tools/scripts/run_tests

[issue18387] Add 'symbols' link to pydoc's html menu bar.

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Hey Ron,

Friendly ping :)

Can you please convert this into a pull request?

--
nosy: +CuriousLearner
versions: +Python 3.9

___
Python tracker 
<https://bugs.python.org/issue18387>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36822] Minor grammatical fix in glossary.rst

[Sanyam Khurana]

Change by Sanyam Khurana :


--
keywords: +patch
pull_requests: +13058
stage: needs patch -> patch review

___
Python tracker 
<https://bugs.python.org/issue36822>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36822] Minor grammatical fix in glossary.rst

[Sanyam Khurana]

New submission from Sanyam Khurana :

While working on translations, I saw a minor grammatical error in 
`Doc/glossary.rst`:

```
  * The default Python prompt of the interactive shell when entering 
code for an indented code block ...
```

should be

```
  * The default Python prompt of the interactive shell when entering  the 
code for an indented code block ...
```

Attaching the path with this.

--
assignee: docs@python
components: Documentation
messages: 341665
nosy: CuriousLearner, docs@python
priority: normal
severity: normal
stage: needs patch
status: open
title: Minor grammatical fix in glossary.rst
type: enhancement
versions: Python 3.5, Python 3.6, Python 3.7, Python 3.8, Python 3.9

___
Python tracker 
<https://bugs.python.org/issue36822>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33187] Document ElementInclude (XInclude) support in ElementTree

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Hello Anjali,

This PR is still lurking for your updates from almost 11 months. Please let us 
know if you're still working on this, else, we'll get this in.

Thanks for your work!

--

___
Python tracker 
<https://bugs.python.org/issue33187>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6911] Document changes in asynchat

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Given that Python 2.x and async chat is deprecated in favor of new async io, 
we're better in closing this issue, rather than trying to apply this cleanly on 
the master branch.

--
nosy: +CuriousLearner
resolution:  -> out of date
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue6911>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4502] Allowing get_pre_input_hook from Readline

[Sanyam Khurana]

Sanyam Khurana  added the comment:

I'm working on applying this patch cleanly and writing a test for this.

However, it seems I'm unable to import `readline` in compiled version of 
Python. I'm trying to provide a path to the installation of readline in my 
system using LDFLAGS, and then reconfiguring and recompiling, but seems like it 
didn't work.

Can someone provide me a pointer here, please?

--
assignee:  -> CuriousLearner
nosy: +CuriousLearner
versions: +Python 3.8 -Python 3.3

___
Python tracker 
<https://bugs.python.org/issue4502>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31506] Improve the error message logic for object_new & object_init

[Sanyam Khurana]

Change by Sanyam Khurana :


--
pull_requests: +11416, 11417, 11418
stage: needs patch -> patch review

___
Python tracker 
<https://bugs.python.org/issue31506>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31506] Improve the error message logic for object_new & object_init

[Sanyam Khurana]

Change by Sanyam Khurana :


--
pull_requests: +11416, 11417
stage: needs patch -> patch review

___
Python tracker 
<https://bugs.python.org/issue31506>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31506] Improve the error message logic for object_new & object_init

[Sanyam Khurana]

Change by Sanyam Khurana :


--
pull_requests: +11416
stage: needs patch -> patch review

___
Python tracker 
<https://bugs.python.org/issue31506>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24746] doctest 'fancy diff' formats incorrectly strip trailing whitespace

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Hi Victor,

Senthil reverted the backport commit on 2.7 branch.

Is there a way I can test reference leaks in CPython? Is it using valgrind or 
some other tool? Can you please point me to that?

I can then see if I can fix this on 2.7

Thanks!

--

___
Python tracker 
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24746] doctest 'fancy diff' formats incorrectly strip trailing whitespace

[Sanyam Khurana]

Change by Sanyam Khurana :


--
pull_requests: +10999, 11000

___
Python tracker 
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24746] doctest 'fancy diff' formats incorrectly strip trailing whitespace

[Sanyam Khurana]

Change by Sanyam Khurana :


--
pull_requests: +10999

___
Python tracker 
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35614] Broken help() on metaclasses

[Sanyam Khurana]

Change by Sanyam Khurana :


--
keywords: +patch, patch, patch
pull_requests: +10670, 10671, 10672
stage:  -> patch review

___
Python tracker 
<https://bugs.python.org/issue35614>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35614] Broken help() on metaclasses

[Sanyam Khurana]

Change by Sanyam Khurana :


--
keywords: +patch
pull_requests: +10670
stage:  -> patch review

___
Python tracker 
<https://bugs.python.org/issue35614>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35614] Broken help() on metaclasses

[Sanyam Khurana]

Change by Sanyam Khurana :


--
keywords: +patch, patch
pull_requests: +10670, 10671
stage:  -> patch review

___
Python tracker 
<https://bugs.python.org/issue35614>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24925] Allow doctest to find line number of __test__ strings if formatted as a triple quoted string.

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Hey  R. David Murray,

Where do you think the unit test for `doctest` should be placed? 

Should it be in `test_doctest.py`?

--
assignee:  -> CuriousLearner
versions: +Python 3.7, Python 3.8

___
Python tracker 
<https://bugs.python.org/issue24925>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24746] doctest 'fancy diff' formats incorrectly strip trailing whitespace

[Sanyam Khurana]

Change by Sanyam Khurana :


--
assignee:  -> CuriousLearner

___
Python tracker 
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24746] doctest 'fancy diff' formats incorrectly strip trailing whitespace

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Thanks for your suggestion, Tim.

I've fixed the patch and it is ready for review at 
https://github.com/python/cpython/pull/10639

--

___
Python tracker 
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24746] doctest 'fancy diff' formats incorrectly strip trailing whitespace

[Sanyam Khurana]

Sanyam Khurana  added the comment:

> Unfortunately I was reminded a few days ago that there is a commit hook that 
> prevents patches containing trailing whitespace from being committed to the 
> repository.

Is this still the case?

I tried to figure out writing the test case, but I can't wrap my head around 
showing the trailing whitespace without putting it anywhere in the code.

Also, can you have a look at the PR, please?

--
nosy: +CuriousLearner
stage: patch review -> test needed
versions: +Python 3.7, Python 3.8

___
Python tracker 
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24746] doctest 'fancy diff' formats incorrectly strip trailing whitespace

[Sanyam Khurana]

Change by Sanyam Khurana :


--
pull_requests: +9886
stage: test needed -> patch review

___
Python tracker 
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24746] doctest 'fancy diff' formats incorrectly strip trailing whitespace

[Sanyam Khurana]

Change by Sanyam Khurana :


--
pull_requests: +9886, 9887
stage: test needed -> patch review

___
Python tracker 
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25439] Add type checks to urllib.request.Request

[Sanyam Khurana]

Sanyam Khurana  added the comment:

PR is up for a review: https://github.com/python/cpython/pull/10616

--

___
Python tracker 
<https://bugs.python.org/issue25439>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25439] Add type checks to urllib.request.Request

[Sanyam Khurana]

Change by Sanyam Khurana :


--
pull_requests: +9862

___
Python tracker 
<https://bugs.python.org/issue25439>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25439] Add type checks to urllib.request.Request

[Sanyam Khurana]

Sanyam Khurana  added the comment:

I'm working on applying the patch cleanly to master branch for this.

Also adding 3.8 and 3.7 as candidates for the bug.

--
versions: +Python 3.7, Python 3.8

___
Python tracker 
<https://bugs.python.org/issue25439>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25439] Add type checks to urllib.request.Request

[Sanyam Khurana]

Change by Sanyam Khurana :


--
assignee:  -> CuriousLearner
nosy: +CuriousLearner

___
Python tracker 
<https://bugs.python.org/issue25439>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18859] README.valgrind should mention --with-valgrind

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Patch added in PR: https://github.com/python/cpython/pull/10591

--
nosy: +CuriousLearner

___
Python tracker 
<https://bugs.python.org/issue18859>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18859] README.valgrind should mention --with-valgrind

[Sanyam Khurana]

Change by Sanyam Khurana :


--
pull_requests: +9837

___
Python tracker 
<https://bugs.python.org/issue18859>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32035] Documentation of zipfile.ZipFile().writestr() fails to mention that 'data' may also be bytes

[Sanyam Khurana]

Sanyam Khurana  added the comment:

The change in current PR is very minor and looks good enough that aligns the 
docs with the docstring and functionality of `ZipFile.writestr` as described.

Can a core-contributor, please look at this?

Also, I'm adding 3.8 for this change.

--
nosy: +CuriousLearner
versions: +Python 3.8

___
Python tracker 
<https://bugs.python.org/issue32035>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33014] Clarify str.isidentifier docstring; fix keyword.iskeyword docstring

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Marking this fixed via 
https://github.com/python/cpython/commit/ffc5a14d00db984c8e72c7b67da8a493e17e2c14
 and 
https://github.com/python/cpython/commit/fc8205cb4b87edd1c19e1bcc26deaa1570f87988

Thanks, everyone!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue33014>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34319] Clarify pathlib.Path("filepath").read_text()

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Marking this bug as fixed via https://github.com/python/cpython/pull/8645

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue34319>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15045] Make textwrap.dedent() consistent with str.splitlines(True) and str.strip()

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Hey Nick, Serhiy

The patch is up for your review. Any updates on this?

--

___
Python tracker 
<https://bugs.python.org/issue15045>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34361] An error should be returned when there are spaces in between function name and parameters

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Hi,

I agree that it can break backward compatibility. But maybe we can add some 
sort of warning message?

The entire motive of this is to get new folks to understand how a function is 
ideally defined and called.

--

___
Python tracker 
<https://bugs.python.org/issue34361>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34361] An error should be returned when there are spaces in between function name and parameters

[Sanyam Khurana]

New submission from Sanyam Khurana :

I noticed this while reviewing the code.

The print function works like:

```
print   (5)
```

This works with user-defined function too.

Ideally, this is a function call and we should return an error stating that 
there shouldn't be any spaces between the function name and the parameters 
listed.

This essentially is not good for people who're new to programming and learning 
to code with Python as their first language.

--
components: Library (Lib)
messages: 323294
nosy: CuriousLearner
priority: normal
severity: normal
stage: needs patch
status: open
title: An error should be returned when there are spaces in between function 
name and parameters
type: behavior
versions: Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 
<https://bugs.python.org/issue34361>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24255] Replace debuglevel-related logic with logging

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Yeah, that is understandable. I've reverted major chunk of it. Just in the http 
client file, I've added blank lines where ever necessary (which I think won't 
change the blame information for any of the code :))

Would that be okay?

Also, I did a change in the test to redirect the `output` from `test.support` 
to `stdout` in order to test the changes, but seems like the CI failed because 
the environment of test was changed. Is there a better method to accomplish it?

--

___
Python tracker 
<https://bugs.python.org/issue24255>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24255] Replace debuglevel-related logic with logging

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Hey Conrad,

I've merged your fixes as well. They are in the PR now. Also added your name in 
the NEWS entry :)

@Vinay, I noticed that there are linting errors in `test_logging.py`. Does it 
make sense to issue a separate Pull Request to fix those? Currently, I've fixed 
them in the current Pull Request. Please let me know :)

--
nosy: +vinay.sajip

___
Python tracker 
<https://bugs.python.org/issue24255>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34319] Clarify pathlib.Path("filepath").read_text()

[Sanyam Khurana]

Sanyam Khurana  added the comment:

+1 to Terry's suggestion.

I've reviewed xtreak's PR and it looks good to me.

--
nosy: +CuriousLearner

___
Python tracker 
<https://bugs.python.org/issue34319>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33187] Document ElementInclude (XInclude) support in ElementTree

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Hello Anjali,

As far as I remember, you started this in a PyDelhi Dev Sprint. So, just wanted 
to check around, if you're looking for any help :)

--
nosy: +CuriousLearner

___
Python tracker 
<https://bugs.python.org/issue33187>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21914] Create unit tests for Turtle guionly

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Hey Rajalakshmi,

Are you still working on this issue? Is there anything we can help you with?

--
nosy: +CuriousLearner

___
Python tracker 
<https://bugs.python.org/issue21914>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24255] Replace debuglevel-related logic with logging

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Sure Conrad,

Yeah, indeed. The patch didn't apply cleanly, so I"ve done it manually.

I've raised the PR here: https://github.com/python/cpython/pull/8633

I'll check your patch and merge :)

Thanks for your help too!

I'm adding Python 3.7 and Python 3.8 for this patch.

--
stage: patch review -> needs patch
versions: +Python 3.7, Python 3.8

___
Python tracker 
<https://bugs.python.org/issue24255>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24255] Replace debuglevel-related logic with logging

[Sanyam Khurana]

Change by Sanyam Khurana :


--
pull_requests: +8138
stage: needs patch -> patch review

___
Python tracker 
<https://bugs.python.org/issue24255>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24255] Replace debuglevel-related logic with logging

[Sanyam Khurana]

Sanyam Khurana  added the comment:

That's okay Eryn. We really appreciate all your help.

I will take this patch forward :)

--

___
Python tracker 
<https://bugs.python.org/issue24255>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29710] Incorrect representation caveat on bitwise operation docs

[Sanyam Khurana]

Sanyam Khurana  added the comment:

On, yes, I think I missed the first point, earlier. Thank You! I did the 
changes.

--

___
Python tracker 
<https://bugs.python.org/issue29710>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29710] Incorrect representation caveat on bitwise operation docs

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Hey Tim,

> @CuriousLearner, does the PR also include Nick's first suggested change?  
> Here:

"""
=
Bitwise operations only make sense for integers. The result of bitwise 
operations is calculated as though carried out in two's complement with an 
infinite number of sign bits.
=
"""

I think it was then discussed to keep this line as:

"""
===
Bitwise operations only make sense for integers. Negative numbers are treated 
as their 2's complement value.
===
"""

Does this needs to be changed?

Here is the link of the PR: 
https://github.com/python/cpython/pull/1691/files#diff-7498e907ba97646df434a0eb583c6909

--

___
Python tracker 
<https://bugs.python.org/issue29710>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8525] Display exceptions' subclasses in help()

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Hi,

My perception with all the discussion and WIP patch is that we can ideally 
limit the no. of subclasses shown only for object, and not for any other class.

>From that list, the only unhelpful ones with > 4 items, in my opinion, appear 
>to be `object`, since that just tells you every type that exists, and `tuple`, 
>because that lists every single namedtuple.

> So it is USEFUL to know ALL subclasses of a given Exception class

+1

> I agree with this - most of the value here comes from showing the full set of 
> exceptions. If we don't do that, we should probably point the user to calling 
> `cls.__subclasses__()` so they can inspect the full list

I agree with this. I would propose to only limit to 4 classes for subclasses of 
`object` and for everything else displaying all the subclasses. We can 
optionally display the message to call `cls.__subclasses()` in the case when 
`help(object)` is called.

How does it sound?

--

___
Python tracker 
<https://bugs.python.org/issue8525>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29710] Incorrect representation caveat on bitwise operation docs

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Seems good to me. I've made the changes in the PR.

--

___
Python tracker 
<https://bugs.python.org/issue29710>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34114] Build failing: use of undeclared identifier '_Py_END_SUPPRESS_IPH' & '_Py_BEGIN_SUPPRESS_IPH'

[Sanyam Khurana]

Sanyam Khurana  added the comment:

This is strange.

I cloned the repo again at some other location, and I can build it successfully.

In my older clone, however, it shows me this error, despite running a `make 
clean`.

Any idea on what is the problem here?

--
nosy: +vstinner
priority: high -> 
stage: needs patch -> 
type: compile error -> 
versions:  -Python 3.8

___
Python tracker 
<https://bugs.python.org/issue34114>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34114] Build failing: use of undeclared identifier '_Py_END_SUPPRESS_IPH' & '_Py_BEGIN_SUPPRESS_IPH'

[Sanyam Khurana]

New submission from Sanyam Khurana :

The step for configuration works correctly and gives a makefile.

On running `./make` the following traceback is produced:

```
$ make  
   
---
Modules/Setup.dist is newer than Modules/Setup;
check to make sure you have all the updates you
need in your Modules/Setup file.
Usually, copying Modules/Setup.dist to Modules/Setup will work.
---
gcc -Wno-unused-result -Wsign-compare -g -O0 -Wall-std=c99 -Wextra 
-Wno-unused-result -Wno-unused-parameter -Wno-missing-field-initializers 
-Wstrict-prototypes -Werror=implicit-function-declaration   -I. -I./Include 
-c ./Modules/posixmodule.c -o Modules/posixmodule.o
./Modules/posixmodule.c:1548:9: error: use of undeclared identifier 
'_Py_BEGIN_SUPPRESS_IPH'
_Py_BEGIN_SUPPRESS_IPH
^
./Modules/posixmodule.c:1550:9: error: use of undeclared identifier 
'_Py_END_SUPPRESS_IPH'
_Py_END_SUPPRESS_IPH
^
./Modules/posixmodule.c:4356:5: error: use of undeclared identifier 
'_Py_BEGIN_SUPPRESS_IPH'
_Py_BEGIN_SUPPRESS_IPH
^
./Modules/posixmodule.c:4364:5: error: expected expression
else
^
./Modules/posixmodule.c:4368:5: error: use of undeclared identifier 
'_Py_END_SUPPRESS_IPH'
_Py_END_SUPPRESS_IPH
^
./Modules/posixmodule.c:5075:5: error: use of undeclared identifier 
'_Py_BEGIN_SUPPRESS_IPH'
_Py_BEGIN_SUPPRESS_IPH
^
./Modules/posixmodule.c:5081:5: error: use of undeclared identifier 
'_Py_END_SUPPRESS_IPH'
_Py_END_SUPPRESS_IPH
^
./Modules/posixmodule.c:5146:5: error: use of undeclared identifier 
'_Py_BEGIN_SUPPRESS_IPH'
_Py_BEGIN_SUPPRESS_IPH
^
./Modules/posixmodule.c:5157:5: error: use of undeclared identifier 
'_Py_END_SUPPRESS_IPH'
_Py_END_SUPPRESS_IPH
^
./Modules/posixmodule.c:5376:5: error: use of undeclared identifier 
'_Py_BEGIN_SUPPRESS_IPH'
_Py_BEGIN_SUPPRESS_IPH
^
./Modules/posixmodule.c:5379:5: error: use of undeclared identifier 
'_Py_END_SUPPRESS_IPH'
_Py_END_SUPPRESS_IPH
^
./Modules/posixmodule.c:7996:5: error: use of undeclared identifier 
'_Py_BEGIN_SUPPRESS_IPH'
_Py_BEGIN_SUPPRESS_IPH
^
./Modules/posixmodule.c:8011:5: error: use of undeclared identifier 
'_Py_END_SUPPRESS_IPH'
_Py_END_SUPPRESS_IPH
^
./Modules/posixmodule.c:8048:5: error: use of undeclared identifier 
'_Py_BEGIN_SUPPRESS_IPH'
_Py_BEGIN_SUPPRESS_IPH
^
./Modules/posixmodule.c:8050:5: error: use of undeclared identifier 
'_Py_END_SUPPRESS_IPH'
_Py_END_SUPPRESS_IPH
^
./Modules/posixmodule.c:8074:5: error: use of undeclared identifier 
'_Py_BEGIN_SUPPRESS_IPH'
_Py_BEGIN_SUPPRESS_IPH
^
./Modules/posixmodule.c:8077:5: error: use of undeclared identifier 
'_Py_END_SUPPRESS_IPH'
_Py_END_SUPPRESS_IPH
^
./Modules/posixmodule.c:8265:5: error: use of undeclared identifier 
'_Py_BEGIN_SUPPRESS_IPH'
_Py_BEGIN_SUPPRESS_IPH
^
./Modules/posixmodule.c:8271:5: error: use of undeclared identifier 
'_Py_END_SUPPRESS_IPH'
_Py_END_SUPPRESS_IPH
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make: *** [Modules/posixmodule.o] Error 1
```

--
components: Interpreter Core
messages: 321662
nosy: CuriousLearner
priority: high
severity: normal
stage: needs patch
status: open
title: Build failing: use of undeclared identifier '_Py_END_SUPPRESS_IPH' & 
'_Py_BEGIN_SUPPRESS_IPH'
type: compile error
versions: Python 3.8

___
Python tracker 
<https://bugs.python.org/issue34114>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24925] Allow doctest to find line number of __test__ strings if formatted as a triple quoted string.

[Sanyam Khurana]

Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:

Hey Jurjen,

Do you mind converting your patch in a Pull request please?

--
nosy: +CuriousLearner

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue24925>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33014] Clarify str.isidentifier docstring; fix keyword.iskeyword docstring

[Sanyam Khurana]

Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:

Carol, Yes, I've raised a PR.

Currently, I've updated the docs for `str.isidentifier` clarifying the usage of 
`keyword.iskeyword`

For updating the docstring of `keyword.iskeyword`, I saw that `Lib/Keyword.py` 
defines this on line 55: `iskeyword = frozenset(kwlist).__contains__`

The docstring of the file says that it is automatically generated from 
`graminit.c`. I observed that file and have no clue on how to proceed to have 
the doc string updated. Can someone provide me a pointer on this please?

--
keywords:  -patch
stage: patch review -> needs patch

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue33014>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33014] Clarify str.isidentifier docstring; fix keyword.iskeyword docstring

[Sanyam Khurana]

Change by Sanyam Khurana <sanyam.khuran...@gmail.com>:


--
keywords: +patch
pull_requests: +5850
stage: needs patch -> patch review

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue33014>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3014] file_dealloc() assumes errno is set when EOF is returned

[Sanyam Khurana]

Change by Sanyam Khurana <sanyam.khuran...@gmail.com>:


--
keywords: +patch
pull_requests: +5849
stage:  -> patch review

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue3014>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33014] Clarify doc string for str.isidentifier()

[Sanyam Khurana]

Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:

Hey David,

I'm working on this issue. Will submit a PR in a while :)

--
nosy: +CuriousLearner

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue33014>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24255] Replace debuglevel-related logic with logging

[Sanyam Khurana]

Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:

Hey Erin,

Can you please convert your patch to a PR on Github?

--
nosy: +CuriousLearner

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue24255>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8525] Display exception's subclasses in help()

[Sanyam Khurana]

Change by Sanyam Khurana <sanyam.khuran...@gmail.com>:


--
assignee:  -> CuriousLearner
versions: +Python 3.8 -Python 3.7

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue8525>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32685] Erroneous suggestion in print statement

[Sanyam Khurana]

Change by Sanyam Khurana <sanyam.khuran...@gmail.com>:


--
pull_requests: +5217

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32685>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32685] Erroneous suggestion in print statement

[Sanyam Khurana]

Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:

Thanks for the report Mayank!

As we discussed offline, it is indeed reproducible if someone uses `print` on 
the same line (such as in this case, where a loop is used).

I will look into this issue.

--

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32685>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25910] How many "critical"-level open issues are there?

[Sanyam Khurana]

Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:

Victor, there is just one last thing to do in here.

All the links pointing to Github (that are build automatically) are permanently 
redirected from https://github.com/python/cpython/tree/master/* to 
https://github.com/python/cpython/blob/master/*

I will issue a separate PR for it, and then we're good to close this issue.

PS: Guido, I'm not sure about the title change either.

--

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue25910>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8525] Display exception's subclasses in help()

[Sanyam Khurana]

Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:

I've changed the version to 3.7. Not sure if this would need a backport since 
this is a new feature. So, I'll defer this call to a core developer. I've 
created a PR for the new feature.

--
versions: +Python 3.7 -Python 3.2

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue8525>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8525] Display exception's subclasses in help()

[Sanyam Khurana]

Change by Sanyam Khurana <sanyam.khuran...@gmail.com>:


--
pull_requests: +4940
stage: needs patch -> patch review

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue8525>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15045] Make textwrap.dedent() consistent with str.splitlines(True) and str.strip()

[Sanyam Khurana]

Change by Sanyam Khurana <sanyam.khuran...@gmail.com>:


--
pull_requests: +4932

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue15045>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19678] smtpd.py: channel should be passed to process_message

[Sanyam Khurana]

Change by Sanyam Khurana <sanyam.khuran...@gmail.com>:


--
keywords: +patch
pull_requests: +4931
stage: needs patch -> patch review

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue19678>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22671] Typo in class io.BufferedIOBase docs

[Sanyam Khurana]

Change by Sanyam Khurana <sanyam.khuran...@gmail.com>:


--
pull_requests: +4708

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue22671>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31506] Improve the error message logic for object_new & object_init

[Sanyam Khurana]

Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:

Serhiy, can you please elaborate on that a bit? I'll try to fix this.

--

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue31506>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19678] smtpd.py: channel should be passed to process_message

[Sanyam Khurana]

Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:

Leslie, would you like to work on a patch for this?

--
nosy: +CuriousLearner

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue19678>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15045] Make textwrap.dedent() consistent with str.splitlines(True) and str.strip()

[Sanyam Khurana]

Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:

Ezra, can you please convert your patch to a Pull Request on Github?

--
nosy: +CuriousLearner

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue15045>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31506] Improve the error message logic for object_new & object_init

[Sanyam Khurana]

Change by Sanyam Khurana <sanyam.khuran...@gmail.com>:


--
pull_requests: +4643
stage: needs patch -> patch review

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue31506>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31506] Improve the error message logic for object_new & object_init

[Sanyam Khurana]

Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:

Nick,

I think the error messages are incorrect. We expect error message to be `takes 
no argument` rather than `takes exactly one argument`. Can you please confirm 
that?

I think for the class without any method overrides, the functionality should be 
something like this:

 >>> class C:
... pass
...
>>> C(42)
Traceback (most recent call last):
  File "", line 1, in 
TypeError: C() takes no arguments
>>> C.__new__(C, 42)
Traceback (most recent call last):
  File "", line 1, in 
TypeError: C() takes no arguments
>>> C().__init__(42)
Traceback (most recent call last):
  File "", line 1, in 
TypeError: C().__init__() takes no arguments
>>> object.__new__(C, 42)
Traceback (most recent call last):
  File "", line 1, in 
TypeError: C() takes no arguments
>>> object.__init__(C(), 42)
Traceback (most recent call last):
  File "", line 1, in 
TypeError: C().__init__() takes no arguments



Is that correct?

--

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue31506>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31506] Improve the error message logic for object_new & object_init

[Sanyam Khurana]

Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:

I'll work on a fix for this and issue a PR.

--
nosy: +CuriousLearner

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue31506>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32197] Compiling against master branch fails; error: expected expression SET_DECODE_ERROR

[Sanyam Khurana]

Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:

Hey Victor, thanks for the update.

I was confused about how the macro was replaced in the previous version.

--

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32197>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32028] Syntactically wrong suggestions by the new custom print statement error message

[Sanyam Khurana]

Change by Sanyam Khurana <sanyam.khuran...@gmail.com>:


--
keywords: +patch
pull_requests: +4601
stage: test needed -> patch review

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32028>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32197] Compiling against master branch fails; error: expected expression SET_DECODE_ERROR

[Sanyam Khurana]

Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:

Even a simple use of ternary operator instead of using if-else inside do-while 
to handle the macro like:

#define SET_DECODE_ERROR(NAME, LEN) \
pymain->err = ((LEN) == (size_t)-2) \
? _Py_INIT_USER_ERR("cannot decode " #NAME) \
: _Py_INIT_NO_MEMORY()

, throws the error `undeclared identifier pymain`:

gcc -c -Wno-unused-result -Wsign-compare -g -O0 -Wall -Wstrict-prototypes
-std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter 
-Wno-missing-field-initializers -Werror=implicit-function-declaration   -I. 
-I./Include-DPy_BUILD_CORE -o Modules/main.o Modules/main.c
Modules/main.c:899:20: error: use of undeclared identifier 'pymain'
return SET_DECODE_ERROR("PYTHONEXECUTABLE environment "
   ^
Modules/main.c:46:5: note: expanded from macro 'SET_DECODE_ERROR'
pymain->err = ((LEN) == (size_t)-2) \
^
1 error generated.
make: *** [Modules/main.o] Error 1

I'm still trying to figure out a solution for this.

--

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32197>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32197] Compiling against master branch fails; error: expected expression SET_DECODE_ERROR

[Sanyam Khurana]

Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:

I tried to resolve the issue by trying to figure out the syntax for the 
SET_DECODE_ERROR macro.

I tried to call a function from the macro, and eventually do the checking in 
that function.

Second way I tried was to replace statement for macro instead of using do-while 
for placing the if-else clause.

I was stuck at the issue that at the point when the compiler tries to replace 
the macro with actual code, `pymain` wasn't defined.

If someone could provide a pointer on this, it would be really helpful and I'll 
try to work on a patch.

One simplest possible solution would be not use macro and simply use the code 
at the 3 places where it is being used. But I'll defer this anti-DRY approach 
if we can have a better solution.

--

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32197>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32197] Compiling against master branch fails; error: expected expression SET_DECODE_ERROR

[Sanyam Khurana]

Sanyam Khurana <sanyam.khuran...@gmail.com> added the comment:

I used git bisect to track down the commit that broke the build.

Seems like this is the SHA: ebac19dad6263141d5db0a2c923efe049dba99d2

ebac19dad6263141d5db0a2c923efe049dba99d2 is the first bad commit
commit ebac19dad6263141d5db0a2c923efe049dba99d2
Author: Victor Stinner <victor.stin...@gmail.com>
Date:   Fri Dec 1 20:09:52 2017 +0100

bpo-32030: Don't call _PyPathConfig_Fini() in Py_FinalizeEx() (#4667)

Changes:

* _PyPathConfig_Fini() cannot be called in Py_FinalizeEx().
  Py_Initialize() and Py_Finalize() can be called multiple times, but
  it must not "forget" parameters set by Py_SetProgramName(),
  Py_SetPath() or Py_SetPythonHome(), whereas _PyPathConfig_Fini()
  clear all these parameters.
* config_get_program_name() and calculate_program_full_path() now
  also decode paths using Py_DecodeLocale() to use the
  surrogateescape error handler, rather than decoding using
  mbstowcs() which is strict.
* Change _Py_CheckPython3() prototype: () => (void)
* Truncate a few lines which were too long

:04 04 de4ec929ff3fcd3c6455d8dae4d16e47fdd32ad5 
8b289341f1b5e68757ac3b111a7f11808f5de1ec M  Include
:04 04 ecddc93b37f74818d85f6d8e8ab0e0c57e893c03 
c51971a3af2b6f163e625505265277410bb9eedd M  Modules
:04 04 b92d30ac6375b7dde865a878e701684dd400e742 
7d5d8810407060f32c9cbce20dcfc6f9d425524f M  PC
:04 04 537f9e0e6a27b41178fe7b828a8da99c63cc2d9b 
b14940c66180023a3704ad3949367db3e82ca832 M  Python

--

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32197>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com