[issue10344] codecs.open() buffering doc needs fix

[STINNER Victor]

STINNER Victor  added the comment:


New changeset a2670565d8f5c502388378aba1fe73023fd8c8d4 by Victor Stinner 
(Alexey Izbyshev) in branch 'master':
bpo-32236: open() emits RuntimeWarning if buffering=1 for binary mode (GH-4842)
https://github.com/python/cpython/commit/a2670565d8f5c502388378aba1fe73023fd8c8d4


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10344] codecs.open() buffering doc needs fix

[Alexey Izbyshev]

Change by Alexey Izbyshev :


--
keywords: +patch
pull_requests: +4731
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10344] codecs.open() buffering doc needs fix

[Martin Panter]

Martin Panter added the comment:

A couple of specific problems have been raised by Terry here. Checking each 
against the current Python 3 status, some have already been fixed:

* The codecs.open() signature has been fixed in Issue 19548.

* The StreamReader.readline(size=...) parameter documentation has been fixed to 
match the docstring in Issue 18336.

So that leaves these three problems, as I see it:

1. The notice about opening in binary mode still needs fixing for encoding=None.

2. The buffering parameter is applied to the underlying builtins.open() call, 
so should be clarified in the documentation.

3. codecs.open(filename, encoding=...) will by default call 
builtins.open(filename, rb, buffering=1), which makes no sense according the 
the documentation.

--
nosy: +vadmium
stage:  - needs patch
title: codecs.StreamReader.readline doc needs fix - codecs.open() buffering 
doc needs fix

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10344
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10344] codecs.open() buffering doc needs fix

[Antoine Pitrou]

Changes by Antoine Pitrou pit...@free.fr:


--
nosy:  -pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10344
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com