[issue19235] Add a dedicated subclass for recursion errors
Larry Hastings added the comment: This is fine for 3.5. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19235] Add a dedicated subclass for recursion errors
Yury Selivanov added the comment: Thanks Larry and Georg! -- resolution: - fixed stage: patch review - resolved status: open - closed versions: +Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19235] Add a dedicated subclass for recursion errors
Roundup Robot added the comment: New changeset a795cf73ce6f by Yury Selivanov in branch '3.5': Issue #19235: Add new RecursionError exception. Patch by Georg Brandl. https://hg.python.org/cpython/rev/a795cf73ce6f New changeset 749d74e5dfa7 by Yury Selivanov in branch 'default': Merge 3.5 (Issue #19235) https://hg.python.org/cpython/rev/749d74e5dfa7 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19235] Add a dedicated subclass for recursion errors
Changes by Ivan Levkivskyi levkivs...@gmail.com: -- nosy: +levkivskyi ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19235] Add a dedicated subclass for recursion errors
Elazar Gershuni added the comment: So what holds it back now? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19235] Add a dedicated subclass for recursion errors
Elazar Gershuni added the comment: Well that's a déjà vu. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19235] Add a dedicated subclass for recursion errors
Yury Selivanov added the comment: +1. This, unfortunately, can't go in 3.5 (too late), but I can commit this in 3.6. -- assignee: - yselivanov nosy: +yselivanov versions: +Python 3.6 -Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19235] Add a dedicated subclass for recursion errors
Yury Selivanov added the comment: Larry, is there any chance this can be committed in 3.5 (the change is fully backwards compatible)? -- nosy: +larry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19235] Add a dedicated subclass for recursion errors
Elazar Gershuni added the comment: Ok -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19235] Add a dedicated subclass for recursion errors
Changes by Berker Peksag berker.pek...@gmail.com: -- nosy: +berker.peksag stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19235] Add a dedicated subclass for recursion errors
Elazar Gershuni added the comment: Is it going to be committed? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19235] Add a dedicated subclass for recursion errors
R. David Murray added the comment: It's an enhancement, so it can only go in 3.5, and that will happen some time after the release of 3.4. -- nosy: +r.david.murray versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19235] Add a dedicated subclass for recursion errors
Elazar Gershuni added the comment: Looks good to me. Is it possible to add it to 2.7? I think it won't break any PEP8-following code (e.g. not testing for type equality/identity) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19235] Add a dedicated subclass for recursion errors
Raymond Hettinger added the comment: +1 -- nosy: +rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19235] Add a dedicated subclass for recursion errors
Georg Brandl added the comment: Attached is a patch, please review. Introduces a RecursionError that subclasses RuntimeError for compatibility. Note: I also tested this with RecursionError not subclassing RuntimeError, to make sure that except clauses in the test suite are sufficiently narrowed to RecursionError. -- keywords: +patch Added file: http://bugs.python.org/file32091/recursion_error.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19235] Add a dedicated subclass for recursion errors
New submission from Elazar Gershuni: There's no dedicated StackOverflowErrorException, So there is no way to accurately distinguish a recursion overflow from a general RuntimeError. One cannot use the exception message, since the docs explicitly says that Exception messages are not part of the Python API, and checking for len(traceback.extract_tb(trace)) = sys.getrecursionlimit()-1 is ugly, and (AFAIK) not guaranteed to be correct. Use case: I've found this while trying to create a cycle detector that will compress the traceback of such errors. See discussion in python-ideas: https://mail.python.org/pipermail/python-ideas/2013-September/023190.html An cycle-detection implementation: http://code.activestate.com/recipes/578660-concise-output-for-maximum-recursion-depth-exceede/ -- components: Library (Lib) messages: 199595 nosy: elazar priority: normal severity: normal status: open title: Add a dedicated subclass for recursion errors type: enhancement versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19235] Add a dedicated subclass for recursion errors
Changes by Elazar Gershuni elaz...@gmail.com: -- nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19235] Add a dedicated subclass for recursion errors
Changes by Georg Brandl ge...@python.org: -- nosy: +pitrou ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19235] Add a dedicated subclass for recursion errors
Antoine Pitrou added the comment: This sounds like a reasonable feature request to me. -- components: +Interpreter Core -Library (Lib) ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19235] Add a dedicated subclass for recursion errors
Georg Brandl added the comment: I agree. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
