[issue28810] Document bytecode changes in 3.6

[Mariatta Wijaya]

Mariatta Wijaya added the comment:


New changeset 0a17e584461b14ff65ec287048f53911dbb2 by Mariatta in branch 
'3.6':
bpo-28810: Update lnotab_notes.txt (GH-665) (GH-919)
https://github.com/python/cpython/commit/0a17e584461b14ff65ec287048f53911dbb2


--
nosy: +Mariatta

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Mariatta Wijaya]

Changes by Mariatta Wijaya :


--
pull_requests: +817

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Brett Cannon]

Brett Cannon added the comment:


New changeset 7e52c3e7aefb4cdaa0662fc01ff68a5e976b77ca by Brett Cannon (Ivan 
Levkivskyi) in branch 'master':
bpo-28810: Document BUILD_TUPLE_UNPACK_WITH_CALL bytecode added in 3.6 (GH-239)
https://github.com/python/cpython/commit/7e52c3e7aefb4cdaa0662fc01ff68a5e976b77ca


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Brett Cannon]

Brett Cannon added the comment:


New changeset 4b2a2a425a906c8e4eb8daee14ab1793e225f726 by Brett Cannon (Ivan 
Levkivskyi) in branch 'master':
bpo-28810: Document changes to CALL_FUNCTION opcodes (GH-250)
https://github.com/python/cpython/commit/4b2a2a425a906c8e4eb8daee14ab1793e225f726


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Brett Cannon]

Brett Cannon added the comment:


New changeset 68c5e4c592495f1e0f4f60acb3483beb6aa87be1 by Brett Cannon in 
branch '3.6':
bpo-28810: Document BUILD_TUPLE_UNPACK_WITH_CALL bytecode (GH-605)
https://github.com/python/cpython/commit/68c5e4c592495f1e0f4f60acb3483beb6aa87be1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Brett Cannon]

Brett Cannon added the comment:


New changeset 4807fa8386f825d0c71192c59f7e33b99a94bebe by Brett Cannon in 
branch '3.6':
bpo-28810: Document changes to CALL_FUNCTION opcodes (GH-607)
https://github.com/python/cpython/commit/4807fa8386f825d0c71192c59f7e33b99a94bebe


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Serhiy Storchaka]

Serhiy Storchaka added the comment:


New changeset 9135275cba680902e6caf29461f0423dc570190d by Serhiy Storchaka 
(Ivan Levkivskyi) in branch 'master':
bpo-28810: Update lnotab_notes.txt (#665)
https://github.com/python/cpython/commit/9135275cba680902e6caf29461f0423dc570190d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Ivan Levkivskyi]

Ivan Levkivskyi added the comment:

Thanks Brett!

I think this could be closed now.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Brett Cannon]

Brett Cannon added the comment:

Is there anything left to do for this Ivan?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Brett Cannon]

Brett Cannon added the comment:


New changeset 74bfcc314b188e1e8c90e442270e36d6510755ee by Brett Cannon in 
branch '3.6':
bpo-28810: Document remaining bytecode changes in 3.6 (GH-651) (GH-808)
https://github.com/python/cpython/commit/74bfcc314b188e1e8c90e442270e36d6510755ee


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Brett Cannon]

Changes by Brett Cannon :


--
pull_requests: +713

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Brett Cannon]

Brett Cannon added the comment:


New changeset 8f9e1bbf2dbdf46a0bf920279568a31460043376 by Brett Cannon (Ivan 
Levkivskyi) in branch 'master':
bpo-28810: Document remaining bytecode changes in 3.6 (GH-651)
https://github.com/python/cpython/commit/8f9e1bbf2dbdf46a0bf920279568a31460043376


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Ivan Levkivskyi]

Changes by Ivan Levkivskyi :


--
pull_requests: +547

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Ivan Levkivskyi]

Changes by Ivan Levkivskyi :


--
pull_requests: +538

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Brett Cannon]

Brett Cannon added the comment:

I have merged all the PRs that Ivan had open. I'll leave the issue open since 
Ivan said he had another PR he wanted to create.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Brett Cannon]

Changes by Brett Cannon :


--
pull_requests: +502

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Brett Cannon]

Changes by Brett Cannon :


--
pull_requests: +500

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Ivan Levkivskyi]

Ivan Levkivskyi added the comment:

It looks like there are still few things that are not covered in two open PRs. 
I will add these in an additional PR in the next few days.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Brett Cannon]

Brett Cannon added the comment:

If the "ping" is for me, I spent my open source day last week reviewing the 
dependency for this issue (and other stuff) so I plan to get to this PR this 
Friday.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Ping.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Ivan Levkivskyi]

Changes by Ivan Levkivskyi :


--
pull_requests: +217

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you for your patches Ivan. Feel free to rewrite my patch, I'm sure it 
uses poor English.

--
dependencies: +Document BUILD_*_UNPACK opcodes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Ivan Levkivskyi]

Changes by Ivan Levkivskyi :


--
pull_requests: +201

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Matthieu Dartiailh]

Matthieu Dartiailh added the comment:

Anyone to review this. Working on bytecode manipulation for different projects 
I wish I had known this existed before.

--
nosy: +mdartiailh

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Brett Cannon]

Brett Cannon added the comment:

I'll review your patch sometime this week, Serhiy.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Brett Cannon]

Changes by Brett Cannon :


--
assignee: docs@python -> brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Several third-party bytecode manipulating projects still are not updated to 
3.6. Correct documentation is needed for them. Could anyone please make a 
review of the patch (or maybe totally rewrite it)?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Berker Peksag]

Changes by Berker Peksag :


--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Because nobody proposed a patch, here is my attempt. Following patch documents 
opcodes CALL_FUNCTION, CALL_FUNCTION_KW and CALL_FUNCTION_EX.

--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file45780/docs-call-function-opcodes.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Brett Cannon]

Changes by Brett Cannon :


--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I think only the mention in What's News is needed. Elvis already provided a 
patch in issue28635.

But the documentation of other opcodes may be missed or outdated.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Ivan Levkivskyi]

Ivan Levkivskyi added the comment:

SETUP_ANNOTATIONS and STORE_ANNOTATION opcodes are documented in documentation 
for dis module. Should they be documented also somewhere else?

--
nosy: +levkivskyi

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28810] Document bytecode changes in 3.6

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

There are many bytecode changes in 3.6, but seems most of them are not 
documented (besides short line in _bootstrap_external.py).

* The bytecode now uses 16 bit units (wordcode) (issue26647).

* Added FORMAT_VALUE opcode (issue25483).

* Added BUILD_CONST_KEY_MAP opcode (issue27140).

* Added BUILD_STRING opcode (issue27078).

* Added BUILD_TUPLE_UNPACK_WITH_CALL opcode (issue28257).

* Added SETUP_ANNOTATIONS and STORE_ANNOTATION opcodes (issue27985).

* Changed CALL_FUNCTION, CALL_FUNCTION_KW and BUILD_MAP_UNPACK_WITH_CALL 
opcodes, removed CALL_FUNCTION_VAR, CALL_FUNCTION_VAR_KW opcodes, added 
CALL_FUNCTION_EX opcode (issue27213).

* Changed MAKE_FUNCTION opcode, removed MAKE_CLOSURE opcode (issue27095).

* Not related to the bytecode itself: lineno delta of code.co_lnotab now is 
signed (issue26107).

There are third-party projects that need correct information about bytecode 
changes.

--
assignee: docs@python
components: Documentation
messages: 281788
nosy: docs@python, serhiy.storchaka
priority: high
severity: normal
stage: needs patch
status: open
title: Document bytecode changes in 3.6
type: enhancement
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com