[issue31106] os.posix_fallocate() generate exception with errno 0

2018-05-26 Thread Ned Deily 

Ned Deily  added the comment:

P.S.:
> Koobs, could you please open a new issue about the failing test?  Unless 
> someone knows of a foolproof way to determine on all platforms that a file is 
> resident on ZFS, the fix is to skip the test on FreeBSD as well if ZFS is 
> likely to be used there.

The unrelated problem identified in msg312453 has now been fixed in Issue33655.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2018-05-24 Thread Ned Deily 

Ned Deily  added the comment:

Considering we have already shipped this fix in 3.6.5, I guess we can live 
without a NEWS entry at this point -> closing this issue.

--
priority: deferred blocker -> 
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2018-02-27 Thread Ned Deily 

Ned Deily  added the comment:

I agree with Alexey's analysis.

Koobs, could you please open a new issue about the failing test?  Unless 
someone knows of a foolproof way to determine on all platforms that a file is 
resident on ZFS, the fix is to skip the test on FreeBSD as well if ZFS is 
likely to be used there.

Also, can someone add a NEWS entry and close this issue?

--
nosy: +ned.deily
priority: normal -> deferred blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2018-02-20 Thread Alexey Izbyshev 

Alexey Izbyshev  added the comment:

The failed test is test_posix_fallocate, not test_posix_fallocate_errno. The 
former special-cases Solaris for EINVAL already, and the latter merely passes 
an invalid descriptor.

It seems that this particular issue is still open only because there is no NEWS 
entry in the merged commits.

--
nosy: +izbyshev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2018-02-20 Thread Kubilay Kocak 

Kubilay Kocak  added the comment:

I believe changeset d4b93e21c2664d6a78e0656e7a7be0807be1c352 may be the cause 
of buildbot failures on FreeBSD (at least koobs-freebsd-current, log attached), 
due to only the EBADF error being handled (not EINVAL, et al).

Unfortunately the worker was been offline for a longer than anticipated period 
of time and only recently was restored which delayed picking it up.

The issue (in this workers case) is related to the buildbot home/data directory 
being on a ZFS filesystem, who's host was recently updated (from current late 
last year to yesterday).

Initial investigation/isolation/references:

Disable posix_fallocate(2) for ZFS
https://lists.freebsd.org/pipermail/svn-src-head/2017-November/105709.html

Note: Above change will be relevant (merged) for at least FreeBSD 12 and 11, 
but perhaps even 10.

684: posix_fallocate() should be allowed to return ENOTSUP (Interp Status: 
Approved)
http://austingroupbugs.net/view.php?id=684

[HEADS UP] posix_fallocate support removed from ZFS, lld affected
https://lists.freebsd.org/pipermail/freebsd-current/2017-November/067463.html
Snip: "illumos and ZoL seem to do the same."

Gold fails when output file is lying on ZFS 
https://sourceware.org/bugzilla/show_bug.cgi?id=22540

Given the wide scope of use of zfs and both syscalls across multiple OS's, and 
possible changes to POSIX documentation/standards, changes to the underlying 
fallocate/fadvise functions may also be indicated here.

--
nosy: +koobs
versions: +Python 3.8
Added file: 
https://bugs.python.org/file47454/koobs-freebsd-current.non-debug.3.x.build.16.stdio.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2018-02-01 Thread Andrew Svetlov 

Andrew Svetlov  added the comment:


New changeset 3a04c52a9eb03e31c60037248b872f3662002a4d by Andrew Svetlov (Miss 
Islington (bot)) in branch '3.6':
bpo-31106: Fix handling of erros in posix_fallocate() and posix_fadvise() 
(GH-3000) (GH-3000) (#4101)
https://github.com/python/cpython/commit/3a04c52a9eb03e31c60037248b872f3662002a4d


--
nosy: +asvetlov

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2017-12-23 Thread Марк Коренберг 

Марк Коренберг  added the comment:

Yes, I can. Should I create new PR ? to which branch ?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2017-10-24 Thread Serhiy Storchaka 

Serhiy Storchaka  added the comment:

Марк, do you mind to add a NEWS entry?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2017-10-24 Thread Roundup Robot 

Change by Roundup Robot :


--
keywords: +patch
pull_requests: +4071

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2017-08-14 Thread Larry Hastings 

Larry Hastings added the comment:

You understand correctly.  It won't be backported to Python 3.5.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2017-08-14 Thread Марк Коренберг 

Марк Коренберг added the comment:

If I understand right, Python 3.5 will not be fixed with this pathc. Right ?

If yes, I will tell Debian maintainers to backport this patch to Python 3.5, 
which is shipped with latest stable Debian 9.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2017-08-14 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:

Needed a NEWS entry.

--
nosy: +serhiy.storchaka
versions:  -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2017-08-14 Thread Larry Hastings 

Changes by Larry Hastings :


--
pull_requests: +3129

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2017-08-14 Thread Larry Hastings 

Larry Hastings added the comment:


New changeset d4b93e21c2664d6a78e0656e7a7be0807be1c352 by larryhastings 
(Коренберг Марк) in branch 'master':
bpo-31106: Fix handling of erros in posix_fallocate() and posix_fadvise() 
(#3000) (#3000)
https://github.com/python/cpython/commit/d4b93e21c2664d6a78e0656e7a7be0807be1c352


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2017-08-07 Thread STINNER Victor 

Changes by STINNER Victor :


--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2017-08-07 Thread Mariatta Wijaya 

Mariatta Wijaya added the comment:

Adding Larry who is listed as posix expert.

--
nosy: +Mariatta, larry
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2017-08-04 Thread Марк Коренберг 

Марк Коренберг added the comment:

posix_fadvise() is also affected :(

Fixed in this patch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2017-08-04 Thread Марк Коренберг 

Марк Коренберг added the comment:

All checks passed.

Please merge.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2017-08-04 Thread Марк Коренберг 

Марк Коренберг added the comment:

https://github.com/python/cpython/pull/3000

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2017-08-04 Thread Марк Коренберг 

Changes by Марк Коренберг :


--
pull_requests: +3036

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2017-08-04 Thread Марк Коренберг 

Марк Коренберг added the comment:

Also, EINTR will not be caught too (!)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2017-08-04 Thread Марк Коренберг 

Марк Коренберг added the comment:

man posix_fallocate:

RETURN VALUE

posix_fallocate() returns zero on success, or an error number on failure.  Note 
that errno is not set.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31106] os.posix_fallocate() generate exception with errno 0

2017-08-02 Thread Марк Коренберг 

New submission from Марк Коренберг:

===
os.posix_fallocate(os.open('qwe.qwe', os.O_RDONLY|os.O_CREAT), 0, 1024*1024)
===

generates OSError with errno 0. Suppose this happen due to O_RDONLY flag.

strace :


open("qwe.qwe", O_RDONLY|O_CREAT|O_CLOEXEC, 0777) = 3
fallocate(3, 0, 0, 1048576) = -1 EBADF (Bad file descriptor)



Python 3.5.3, Ubuntu 64-bit.

--
components: Library (Lib)
messages: 299660
nosy: socketpair
priority: normal
severity: normal
status: open
title: os.posix_fallocate() generate exception with errno 0
type: behavior
versions: Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com