[issue31643] test_uuid: test_getnode and test_windll_getnode fail if connected to the Internet via an Android phone

[Irit Katriel]

Change by Irit Katriel :


--
keywords:  -patch
versions: +Python 3.10, Python 3.11, Python 3.9 -Python 2.7, Python 3.4, Python 
3.5, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31643] test_uuid: test_getnode and test_windll_getnode fail if connected to the Internet via an Android phone

[Xavier de Gaye]

Xavier de Gaye  added the comment:

> C:\> ipconfig -all

So the all-zero MAC address occurs on a Windows box and that explains the 
test_windll_getnode failure (this test is skipped on Android). I missed that 
point in your initial post and knowing what Android device you are using is 
irrelevant.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31643] test_uuid: test_getnode and test_windll_getnode fail if connected to the Internet via an Android phone

[Ivan Pozdeev]

Ivan Pozdeev  added the comment:

> Xavier de Gaye  added the comment:
>
> On a Samsung device with Android 5.1 and tethering enabled, only one network 
> device has a MAC address and it is not an all-zero MAC address.
>
> Ivan can you please provide more information about this problem: which 
> device, what Android version, what is the output of 'ip link' ?

C:\> ipconfig -all
<...>
Samsung Galaxy S7 - Ethernet адаптер:

     DNS-суффикс этого подключения . . :
     Описание  . . . . . . . . . . . . : Android USB Ethernet/RNDIS
     Физический адрес. . . . . . . . . : 00-00-00-00-00-00
     Dhcp включен. . . . . . . . . . . : да
     Автонастройка включена  . . . . . : да
     IP-адрес  . . . . . . . . . . . . : 192.168.42.2
     Маска подсети . . . . . . . . . . : 255.255.255.0
     Основной шлюз . . . . . . . . . . : 192.168.42.129
     DHCP-сервер . . . . . . . . . . . : 192.168.42.129
     DNS-серверы . . . . . . . . . . . : 192.168.42.129

Device name: Samsung Galaxy S7
Model number: SM-G930F
Android version: 6.0.1
Firmware version: G930FXXU1APGJ
Baseband version: G930VVRS4APH1
Build number: MMB29M.G930VVRU2APG5

> Serhiy Storchaka  added the comment:
>
> I'm not sure that  is better than a random address. Even if an 
> all-zero MAC address is not explicitly prohibited it is used in a multiple 
> independent devices. A random address looks more appropriate fore the purpose 
> of generating a UUID.
The question is not whether it's good UUID source material. The 
question, for the purpose of the test, is whether it's valid getnode() 
output -- which it is for the current logic.

--
nosy: +__Vano

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31643] test_uuid: test_getnode and test_windll_getnode fail if connected to the Internet via an Android phone

[Xavier de Gaye]

Xavier de Gaye  added the comment:

> I'm not sure that  is better than a random address.

I agree, getnode() when obtained from a MAC address should not return 0.

RFC 4122 states (emphasis on 'uniqueness' is mine):

This document specifies three algorithms to generate UUIDs: the
  first leverages the unique values of 802 MAC addresses to
  guarantee *uniqueness*, ...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31643] test_uuid: test_getnode and test_windll_getnode fail if connected to the Internet via an Android phone

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

I'm not sure that  is better than a random address. Even if an 
all-zero MAC address is not explicitly prohibited it is used in a multiple 
independent devices. A random address looks more appropriate fore the purpose 
of generating a UUID.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31643] test_uuid: test_getnode and test_windll_getnode fail if connected to the Internet via an Android phone

[Xavier de Gaye]

Xavier de Gaye  added the comment:

On a Samsung device with Android 5.1 and tethering enabled, only one network 
device has a MAC address and it is not an all-zero MAC address.

Ivan can you please provide more information about this problem: which device, 
what Android version, what is the output of 'ip link' ?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31643] test_uuid: test_getnode and test_windll_getnode fail if connected to the Internet via an Android phone

[Ivan Pozdeev]

Change by Ivan Pozdeev :


Removed file: 
https://bugs.python.org/file47178/0001-Allow-for-all-zero-MAC-based-node-ID-e.g.-mobile-mod.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31643] test_uuid: test_getnode and test_windll_getnode fail if connected to the Internet via an Android phone

[Ivan Pozdeev]

Change by Ivan Pozdeev :


--
pull_requests: +4701

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31643] test_uuid: test_getnode and test_windll_getnode fail if connected to the Internet via an Android phone

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
nosy: +barry, serhiy.storchaka, xdegaye

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31643] test_uuid: test_getnode and test_windll_getnode fail if connected to the Internet via an Android phone

[Ivan Pozdeev]

Change by Ivan Pozdeev :


--
pull_requests: +4387
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31643] test_uuid: test_getnode and test_windll_getnode fail if connected to the Internet via an Android phone

[Ivan Pozdeev]

Ivan Pozdeev  added the comment:

Example failure:

==
FAIL: test_windll_getnode (test.test_uuid.TestInternals)
--
Traceback (most recent call last):
  File "C:\Ivan\cpython\lib\test\test_uuid.py", line 501, in test_windll_getnode

self.check_node(node)
  File "C:\Ivan\cpython\lib\test\test_uuid.py", line 449, in check_node
"%s is not an RFC 4122 node ID" % hex)
AssertionError: False is not true :  is not an RFC 4122 node ID

==
FAIL: test_getnode (test.test_uuid.TestUUID)
--
Traceback (most recent call last):
  File "C:\Ivan\cpython\lib\test\test_uuid.py", line 296, in test_getnode
self.assertTrue(0 < node1 < (1 << 48), '%012x' % node1)
AssertionError: False is not true : 

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31643] test_uuid: test_getnode and test_windll_getnode fail if connected to the Internet via an Android phone

[Ivan Pozdeev]

New submission from Ivan Pozdeev :

Ethernet emulation for some devices like Android phones' tethering use all-zero 
MAC addresses (which is okay since they don't actually pass Ethernet frames to 
other NICs). This results in a node ID of 0 if I'm currently connected to the 
Net via such a device. Which fails range checks in the corresponding tests.

RFC 4122 doesn't actually have any prohibitions of using a node ID of 0. 
Neither does IEEE 802.3 (or rather, whatever info I gathered on it since the 
standard's text is not freely available) assign any special meaning to an 
all-zero MAC address.

The patch also corrects the check call in test_windll_getnode since the tested 
function always generates UUID from a MAC address.

--
components: Tests
files: 0001-Allow-for-all-zero-MAC-based-node-ID-e.g.-mobile-mod.patch
keywords: patch
messages: 303360
nosy: Ivan.Pozdeev
priority: normal
severity: normal
status: open
title: test_uuid: test_getnode and test_windll_getnode fail if connected to the 
Internet via an Android phone
type: behavior
versions: Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7, Python 3.8
Added file: 
https://bugs.python.org/file47178/0001-Allow-for-all-zero-MAC-based-node-ID-e.g.-mobile-mod.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com