[issue31901] atexit callbacks should be run at subinterpreter shutdown

[Antoine Pitrou]

Change by Antoine Pitrou :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31901] atexit callbacks should be run at subinterpreter shutdown

[Antoine Pitrou]

Antoine Pitrou  added the comment:


New changeset 776407fe893fd42972c7e3f71423d9d86741d07c by Antoine Pitrou 
(Marcel Plch) in branch 'master':
bpo-31901: atexit callbacks should be run at subinterpreter shutdown (#4611)
https://github.com/python/cpython/commit/776407fe893fd42972c7e3f71423d9d86741d07c


--
nosy: +pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31901] atexit callbacks should be run at subinterpreter shutdown

[Xavier G. Domingo]

Change by Xavier G. Domingo :


--
nosy: +xgdomingo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31901] atexit callbacks should be run at subinterpreter shutdown

[Marcel Plch]

Marcel Plch  added the comment:

I created a PR with fix on this issue - 
https://github.com/python/cpython/pull/4611

This makes Py_EndInterpreter() call atexit callbacks for the subinterpreter it 
is destroying.

It doesn't make Py_Finalize() end all subinterpreters, as the current 
implementation of subinterpreters makes it hard to do so. This is the same as 
the current behaviour: you need to end all subinterpreters before calling 
Py_Finalize().

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31901] atexit callbacks should be run at subinterpreter shutdown

[Marcel Plch]

Change by Marcel Plch :


--
keywords: +patch
pull_requests: +4527
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31901] atexit callbacks should be run at subinterpreter shutdown

[Nick Coghlan]

Nick Coghlan  added the comment:

Ah, I see - yeah, that makes a lot of sense.

I've retitled the issue to make it clearer that the problem is where the 
responsibility for calling atexit functions lives - currently it's in 
Py_Finalize, but really it should be inside the interpreter object's own 
teardown code.

--
components: +Interpreter Core -Extension Modules
title: atexit callbacks only called for current subinterpreter -> atexit 
callbacks should be run at subinterpreter shutdown

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com