[issue32264] move pygetopt.h into internal/

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +9747

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32264] move pygetopt.h into internal/

[Benjamin Peterson]

Benjamin Peterson  added the comment:


New changeset 4c72bc4a38eced10a55ba7071e084b26a2b5ed4b by Benjamin Peterson in 
branch 'master':
add 'extern' to pygetopt.h symbols, so then don't end up in comdat (#4909)
https://github.com/python/cpython/commit/4c72bc4a38eced10a55ba7071e084b26a2b5ed4b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32264] move pygetopt.h into internal/

[Benjamin Peterson]

Change by Benjamin Peterson :


--
pull_requests: +4803

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32264] move pygetopt.h into internal/

[Benjamin Peterson]

Benjamin Peterson  added the comment:

Thanks the report and debugging. You're exactly right—I forgot to add extern.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32264] move pygetopt.h into internal/

[David Bolen]

David Bolen  added the comment:

After some further testing, it does not appear to be configure related but 
something environmental (maybe MACOSX_DEPLOYMENT_TARGET) - using the same 
configure options manually as build-installer seems ok.

For what it's worth, since there do appear to be duplicate definitions in 
pygetopt.h and getopt.c, adding "extern" to the declarations in pygetopt.h 
appears to resolve the issue.  It looks like that was lost with the removal of 
PyAPI_DATA.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32264] move pygetopt.h into internal/

[David Bolen]

David Bolen  added the comment:

This commit appears to have broken OSX installer builds using the 
build-installer.py script (as in the last two attempts on the bolen-dmg-3.x 
builder), confirmed with a bisection from the first failing worker build 
(covering the range 02a0a19..3327a2d)

It fails during the main python compilation with:

ld: multiple definitions of symbol __PyOS_optarg
libpython3.7m.a(getopt.o) definition of __PyOS_optarg in section (__DATA,__data)
libpython3.7m.a(main.o) definition of __PyOS_optarg in section (__DATA,__common)
ld: multiple definitions of symbol __PyOS_opterr

(repeated for the various __PyOS__opt* symbols.

It doesn't seem to be a problem with a simple manual configure/make build 
(probably why the regular OSX workers aren't failing).  

So best guess at the moment is it's related to one of the extra configure 
options used by the build-installer script.  I'm not sure which of the commit 
or build process needs correction, although reverting this at least temporarily 
would resolve the immediate issue.

--
nosy: +db3l, ned.deily, ronaldoussoren

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32264] move pygetopt.h into internal/

[Benjamin Peterson]

Benjamin Peterson  added the comment:


New changeset e425bd75177ffb7f098bdb0618b4a5ba3211fe52 by Benjamin Peterson in 
branch 'master':
move pygetopt.h to internal (closes bpo-32264) (#4830)
https://github.com/python/cpython/commit/e425bd75177ffb7f098bdb0618b4a5ba3211fe52


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32264] move pygetopt.h into internal/

[Benjamin Peterson]

Change by Benjamin Peterson :


--
keywords: +patch
pull_requests: +4722
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32264] move pygetopt.h into internal/

[Benjamin Peterson]

New submission from Benjamin Peterson :

This header has no public functions. It shouldn't be distributed.

--
components: Interpreter Core
messages: 307925
nosy: benjamin.peterson
priority: normal
severity: normal
status: open
title: move pygetopt.h into internal/
type: enhancement
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com