[issue32337] Dict order is now guaranteed, so add tests and doc for it

[Ned Deily]

Ned Deily  added the comment:

Thanks for doing this!  Let's close it.  If comments arise prior to its release 
in 370b4, we can reopen, otherwise please open a new issue.

--
priority: deferred blocker -> 
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32337] Dict order is now guaranteed, so add tests and doc for it

[INADA Naoki]

INADA Naoki  added the comment:

Any other known issue?  May I close this issue?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32337] Dict order is now guaranteed, so add tests and doc for it

[miss-islington]

miss-islington  added the comment:


New changeset 9216dffbc8a2aa62789f81f51f64bc1ec7bf6883 by Miss Islington (bot) 
in branch '3.7':
bpo-32337: Update documentats about dict order (GH-4973)
https://github.com/python/cpython/commit/9216dffbc8a2aa62789f81f51f64bc1ec7bf6883


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32337] Dict order is now guaranteed, so add tests and doc for it

[miss-islington]

Change by miss-islington :


--
pull_requests: +6079

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32337] Dict order is now guaranteed, so add tests and doc for it

[INADA Naoki]

INADA Naoki  added the comment:


New changeset dfbbbf16f9aab82330c634913441b5ac73267d9c by INADA Naoki (hui 
shang) in branch 'master':
bpo-32337: Update documentats about dict order (GH-4973)
https://github.com/python/cpython/commit/dfbbbf16f9aab82330c634913441b5ac73267d9c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32337] Dict order is now guaranteed, so add tests and doc for it

[INADA Naoki]

INADA Naoki  added the comment:

> I started to add this comment to #33218 but Raymond closed that ticket while 
> I was editing it.

Sorry, I closed it, not Raymond.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32337] Dict order is now guaranteed, so add tests and doc for it

[Steven D'Aprano]

Steven D'Aprano  added the comment:

I started to add this comment to #33218 but Raymond closed that ticket while I 
was editing it.

In 3.6, dicts preserving insertion order remains an implementation detail that 
cannot be relied on. It only becomes a guarantee in 3.7.

Even in 3.7, I think that it remains best to think of dicts as fundamentally 
unordered. Dicts might preserve insertion order, but there's no interface for 
extracting the n-th item, or re-ordering the keys into some alternative order, 
and for the purposes of equality comparisons, the order is ignored.

I propose changing the description from "It is best to think of a dictionary as 
an unordered set of key: value pairs" to something like:


Dicts are an otherwise unordered set of key:value pairs
that remember the order keys were inserted.


and references to "arbitrary order" should be replaced by "insertion order". 
But by no means should we suggest that dicts are fundamentally orderable 
(sortable).

--
nosy: +steven.daprano

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32337] Dict order is now guaranteed, so add tests and doc for it

[Ned Deily]

Ned Deily  added the comment:

Raymond, do you want to review the current state of the PR before 3.7.0b4?  
Otherwise, I'll probably ask that it be merged as is.

--
priority: release blocker -> deferred blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32337] Dict order is now guaranteed, so add tests and doc for it

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
nosy: +ned.deily
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32337] Dict order is now guaranteed, so add tests and doc for it

[Raymond Hettinger]

Change by Raymond Hettinger :


--
assignee: rhettinger -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32337] Dict order is now guaranteed, so add tests and doc for it

[shangdahao]

shangdahao  added the comment:

Thanks zhang, I have updated it in the PR.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32337] Dict order is now guaranteed, so add tests and doc for it

[Xiang Zhang]

Xiang Zhang  added the comment:

This part needs editing too, the text and example. 
https://docs.python.org/3/library/stdtypes.html#dictionary-view-objects

--
nosy: +xiang.zhang

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32337] Dict order is now guaranteed, so add tests and doc for it

[shangdahao]

shangdahao  added the comment:

Thanks inada, I removed the tests from the PR.

--
nosy: +shangdahao

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32337] Dict order is now guaranteed, so add tests and doc for it

[INADA Naoki]

New submission from INADA Naoki :

FYI, Builtin dict is tested for ordering already:
https://github.com/python/cpython/blob/13a6c098c215921e35004f9d3a9b70f601e56500/Lib/test/test_ordered_dict.py#L646-L662

--
nosy: +inada.naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32337] Dict order is now guaranteed, so add tests and doc for it

[shangdahao]

Change by shangdahao :


--
keywords: +patch
pull_requests: +4864
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32337] Dict order is now guaranteed, so add tests and doc for it

[Raymond Hettinger]

Change by Raymond Hettinger :


--
title: Dict order is now guaranteed, so add tests for it -> Dict order is now 
guaranteed, so add tests and doc for it

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com