[issue32360] Save OrderedDict imports in various stdlibs.

[INADA Naoki]

Change by INADA Naoki :


--
dependencies:  -Dict order is now guaranteed, so add tests and doc for it
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32360] Save OrderedDict imports in various stdlibs.

[INADA Naoki]

Change by INADA Naoki :


--
resolution:  -> fixed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32360] Save OrderedDict imports in various stdlibs.

[miss-islington]

miss-islington  added the comment:


New changeset 0c533573c527c63dacab5921becb66dc3eb274c1 by Miss Islington (bot) 
in branch '3.7':
bpo-32360: Remove object_pairs_hook=OrderedDict examples (GH-5001)
https://github.com/python/cpython/commit/0c533573c527c63dacab5921becb66dc3eb274c1


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32360] Save OrderedDict imports in various stdlibs.

[miss-islington]

Change by miss-islington :


--
pull_requests: +6072

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32360] Save OrderedDict imports in various stdlibs.

[INADA Naoki]

INADA Naoki  added the comment:


New changeset 629338f1404ea9cd75e4fb0389a2fbe1b589de43 by INADA Naoki in branch 
'master':
bpo-32360: Remove object_pairs_hook=OrderedDict examples (GH-5001)
https://github.com/python/cpython/commit/629338f1404ea9cd75e4fb0389a2fbe1b589de43


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32360] Save OrderedDict imports in various stdlibs.

[INADA Naoki]

INADA Naoki  added the comment:


New changeset 2812d3d99287c50bab99625d7240bcf1c2e32369 by INADA Naoki in branch 
'master':
bpo-32360: Remove OrderedDict usage from json.tool (GH-5315)
https://github.com/python/cpython/commit/2812d3d99287c50bab99625d7240bcf1c2e32369


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32360] Save OrderedDict imports in various stdlibs.

[INADA Naoki]

Change by INADA Naoki :


--
pull_requests: +5161

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32360] Save OrderedDict imports in various stdlibs.

[Srinivas Reddy T]

Change by Srinivas  Reddy T :


--
pull_requests: +4902

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32360] Save OrderedDict imports in various stdlibs.

[Raymond Hettinger]

Raymond Hettinger  added the comment:

> * asyncio/base_events.py:  Used for local variable. 
> * email/_header_value_parser.py: Used for local variable.
> * json: Examples (in document and docstring) for keeping order, and json.tool.

All of these modules have active maintainers.  You should create separate 
issues for each one of these and assign to those maintainers.  You don't just 
get to mow down all the other developers.  That isn't how we work together.

In the JSON module, there does need to be an example of how to use 
object_pairs_hook, so you will need to come up with a replacement or an 
additional note explaining in Py3.7 and later, most of the OrderedDict use 
cases have been supplanted by the regular dict.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32360] Save OrderedDict imports in various stdlibs.

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

I concur with Raymond. I made the same searching before and have found that 
there are not much opportunities for getting rid of OrderedDict and there are 
even less cases that will get a benefit from this.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32360] Save OrderedDict imports in various stdlibs.

[INADA Naoki]

INADA Naoki  added the comment:

Let's remove from these:

* asyncio/base_events.py:  Used for local variable. 
* email/_header_value_parser.py: Used for local variable.
* json: Examples (in document and docstring) for keeping order, and json.tool.

I don't touch other modules.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32360] Save OrderedDict imports in various stdlibs.

[INADA Naoki]

Change by INADA Naoki :


--
pull_requests: +4890

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32360] Save OrderedDict imports in various stdlibs.

[INADA Naoki]

INADA Naoki  added the comment:

Agreed.
I won't remove OrderedDict usages which is part of public APIs.
This issue is for finding and removing easy local usages.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32360] Save OrderedDict imports in various stdlibs.

[Raymond Hettinger]

Raymond Hettinger  added the comment:

These should be looked at one at a time (no sweeping search and replace 
missions).

The original author should be consulted when possible (they are in a better 
position to judge whether the original intent was preserved).

Published APIs should not be changed (i.e. you can't just change the default 
argument for configparser).

Docs should be changed carefully (i.e. let Bob Ippolito decide whether he wants 
to change the examples of how to use the object_pairs_hook).

Guido was very clear that you can't just downgrade every occurrence of 
OrderedDict with dict.  Please don't be so aggressive (grepping every 
occurrence in the standard library without giving it individual consideration).

--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32360] Save OrderedDict imports in various stdlibs.

[Srinivas Reddy T]

Change by Srinivas  Reddy T :


--
pull_requests: +4889

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32360] Save OrderedDict imports in various stdlibs.

[Srinivas Reddy T]

Change by Srinivas  Reddy T :


--
keywords: +patch
pull_requests: +4883
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32360] Save OrderedDict imports in various stdlibs.

[INADA Naoki]

New submission from INADA Naoki :

csv and re has issues already.
There are some remaining OrderdDict, including docstring.
It looks like some of them can be removed easily without doc update.

This is `ag --exclude-dir=test OrderedDict`, exluding csv, re, pprint and 
collections.

typing:
2109:nm_tpl.__annotations__ = nm_tpl._field_types = 
collections.OrderedDict(types)

unittest/util.py
3:from collections import namedtuple, OrderedDict
158:c = OrderedDict()

enum.py
153:enum_class._member_map_ = OrderedDict()  # name->value map
615:# We use an OrderedDict of sorted source keys so that the

lib2to3/pgen2/grammar.py
91:dump() recursively changes all dict to OrderedDict, so the pickled 
file
93:pickled file to create the tables, but  only changes OrderedDict to 
dict
94:at the top level; it does not recursively change OrderedDict to dict.
96:passed to load() in that some of the OrderedDict (from the pickled 
file)
98:performance because OrderedDict uses dict's __getitem__ with nothing 
in
142:return collections.OrderedDict(

asyncio/base_events.py
842:addr_infos = collections.OrderedDict()

configparser.py
142:from collections import OrderedDict as _default_dict, ChainMap as _ChainMap

inspect.py
52:from collections import namedtuple, OrderedDict
1712:new_params = OrderedDict(old_params.items())
2563:* arguments : OrderedDict
2663:self.arguments = OrderedDict(new_arguments)
2694:* parameters : OrderedDict
2724:params = OrderedDict()
2727:params = OrderedDict()
2762:params = OrderedDict(((param.name, param)
2839:arguments = OrderedDict()

json/tool.py
41:object_pairs_hook=collections.OrderedDict)

json/__init__.py
31:>>> from collections import OrderedDict
32:>>> mydict = OrderedDict([('4', 5), ('6', 7)])
290:collections.OrderedDict will remember the order of insertion). If
318:collections.OrderedDict will remember the order of insertion). If

json/decoder.py
297:collections.OrderedDict will remember the order of insertion). If

email/_header_value_parser.py
73:from collections import OrderedDict
720:params = OrderedDict()

pydoc_data/topics.py
8585: '"collections.OrderedDict" to remember the order that 
class '
8593: '   return collections.OrderedDict()\n'
8614: 'empty "collections.OrderedDict".  That mapping records 
the '

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32360] Save OrderedDict imports in various stdlibs.

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
dependencies: +Dict order is now guaranteed, so add tests and doc for it

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32360] Save OrderedDict imports in various stdlibs.

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
components: +Library (Lib)
dependencies: +Save OrderedDict import in argparse, Save OrderedDict import in 
re
type:  -> performance
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32360] Save OrderedDict imports in various stdlibs.

[INADA Naoki]

Change by INADA Naoki :


--
nosy: inada.naoki
priority: normal
severity: normal
status: open
title: Save OrderedDict imports in various stdlibs.

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com