[issue32369] test_subprocess: last part of test_close_fds() doesn't check what's intended

[Alexey Izbyshev]

Change by Alexey Izbyshev :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32369] test_subprocess: last part of test_close_fds() doesn't check what's intended

[Gregory P. Smith]

Gregory P. Smith  added the comment:


New changeset 2d8f06382e7d5a759ca554110a699a397114824a by Gregory P. Smith 
(izbyshev) in branch 'master':
bpo-32369: test_subprocess: Fix pass_fds check in test_close_fds() (#4920)
https://github.com/python/cpython/commit/2d8f06382e7d5a759ca554110a699a397114824a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32369] test_subprocess: last part of test_close_fds() doesn't check what's intended

[Alexey Izbyshev]

Change by Alexey Izbyshev :


--
keywords: +patch
pull_requests: +4815
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32369] test_subprocess: last part of test_close_fds() doesn't check what's intended

[Alexey Izbyshev]

Change by Alexey Izbyshev :


--
nosy: +gregory.p.smith, pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32369] test_subprocess: last part of test_close_fds() doesn't check what's intended

[Alexey Izbyshev]

New submission from Alexey Izbyshev :

The last part of test_close_fds() doesn't match its own comment. The following 
assertion always holds because fds_to_keep and open_fds are disjoint by 
construction.

self.assertFalse(remaining_fds & fds_to_keep & open_fds,
 "Some fds not in pass_fds were left open")

--
components: Tests
messages: 308581
nosy: izbyshev
priority: normal
severity: normal
status: open
title: test_subprocess: last part of test_close_fds() doesn't check what's 
intended
type: behavior
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com