[issue32890] os: Some functions may report bogus errors on Windows

[Alexey Izbyshev]

Alexey Izbyshev  added the comment:

Python 2.7 doesn't have the same issue.

In os.execve(), posix_error() is used, but it is based on errno, which is 
correct. (A funny bit is that os.execve('', ['a'], {}) crashes in 2.7, probably 
because of some checks in CRT).

And os.truncate() is not implemented in 2.7 at all.

--
versions:  -Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32890] os: Some functions may report bogus errors on Windows

[STINNER Victor]

Change by STINNER Victor :


--
versions: +Python 2.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32890] os: Some functions may report bogus errors on Windows

[STINNER Victor]

STINNER Victor  added the comment:

Thanks Alexey Izbyshev!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32890] os: Some functions may report bogus errors on Windows

[miss-islington]

miss-islington  added the comment:


New changeset d9a2665fc4573c4d311a89750737ad4cc3310252 by Miss Islington (bot) 
in branch '3.6':
bpo-32890, os: Use errno instead of GetLastError() in execve() and truncate() 
(GH-5784)
https://github.com/python/cpython/commit/d9a2665fc4573c4d311a89750737ad4cc3310252


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32890] os: Some functions may report bogus errors on Windows

[miss-islington]

miss-islington  added the comment:


New changeset 8f53dcdb246a3acb0e64b742c35b5f785bd19092 by Miss Islington (bot) 
in branch '3.7':
bpo-32890, os: Use errno instead of GetLastError() in execve() and truncate() 
(GH-5784)
https://github.com/python/cpython/commit/8f53dcdb246a3acb0e64b742c35b5f785bd19092


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32890] os: Some functions may report bogus errors on Windows

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 834603112e6ca35944dd21105b01fca562dc3241 by Victor Stinner 
(Alexey Izbyshev) in branch 'master':
bpo-32890, os: Use errno instead of GetLastError() in execve() and truncate() 
(GH-5784)
https://github.com/python/cpython/commit/834603112e6ca35944dd21105b01fca562dc3241


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32890] os: Some functions may report bogus errors on Windows

[miss-islington]

Change by miss-islington :


--
pull_requests: +9325

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32890] os: Some functions may report bogus errors on Windows

[miss-islington]

Change by miss-islington :


--
pull_requests: +9326

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32890] os: Some functions may report bogus errors on Windows

[Alexey Izbyshev]

Change by Alexey Izbyshev :


--
keywords: +patch
pull_requests: +5565
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32890] os: Some functions may report bogus errors on Windows

[Alexey Izbyshev]

New submission from Alexey Izbyshev :

Demo:

>>> os.execve('', ['a'], {})
Traceback (most recent call last):
  File "", line 1, in 
OSError: [WinError 0] The operation completed successfully: ''

The reason is that path_error() used throughout os module always uses 
GetLastError() on Windows, but some functions are implemented via CRT calls 
which report errors via errno. It seems that commit 292c83554 caused this issue.

--
messages: 312446
nosy: izbyshev, vstinner
priority: normal
severity: normal
status: open
title: os: Some functions may report bogus errors on Windows
type: behavior
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com