[issue33032] Mention implicit cache in struct.Struct docs

[Gregory P. Smith]

Gregory P. Smith  added the comment:

thanks!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33032] Mention implicit cache in struct.Struct docs

[miss-islington]

miss-islington  added the comment:


New changeset 2110f78d92522499836a928d268704fdc5f7a037 by Miss Islington (bot) 
in branch '3.7':
bpo-33032: Mention the implicit cache in struct.Struct() docs (GH-7700)
https://github.com/python/cpython/commit/2110f78d92522499836a928d268704fdc5f7a037


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33032] Mention implicit cache in struct.Struct docs

[Gregory P. Smith]

Gregory P. Smith  added the comment:


New changeset 3666b3c1f695a145adab1bf644c22e564e8eb0ee by Gregory P. Smith 
(Zackery Spytz) in branch 'master':
bpo-33032: Mention the implicit cache in struct.Struct() docs (GH-7700)
https://github.com/python/cpython/commit/3666b3c1f695a145adab1bf644c22e564e8eb0ee


--
nosy: +gregory.p.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33032] Mention implicit cache in struct.Struct docs

[miss-islington]

Change by miss-islington :


--
pull_requests: +8604

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33032] Mention implicit cache in struct.Struct docs

[Zackery Spytz]

Change by Zackery Spytz :


--
nosy: +ZackerySpytz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33032] Mention implicit cache in struct.Struct docs

[Zackery Spytz]

Change by Zackery Spytz :


--
keywords: +patch
pull_requests: +7316
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33032] Mention implicit cache in struct.Struct docs

[Nick Coghlan]

Nick Coghlan  added the comment:

The note on https://docs.python.org/3/library/re.html#re.compile provides a 
useful precedent for possible wording here, as the struct cache and the regex 
cache are quite similar.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33032] Mention implicit cache in struct.Struct docs

[Nick Coghlan]

New submission from Nick Coghlan :

The struct.Struct docs claim that creating and re-using a Struct object will be 
noticeably faster than calling the module level methods repeatedly with the 
same format string, as it will avoid parsing the format string multiple times: 
https://docs.python.org/3/library/struct.html#struct.Struct

This claim is questionable, as struct has used an internal Struct cache since 
at least 2.5, so if you're using less than 100 different struct layouts in any 
given process, the only thing you'll be saving is a string-keyed dictionary 
lookup.

--
assignee: docs@python
components: Documentation
messages: 313468
nosy: docs@python, ncoghlan
priority: normal
severity: normal
stage: needs patch
status: open
title: Mention implicit cache in struct.Struct docs
type: enhancement
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com