[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 903f189b6e528cbe9500014c6f990c6511b38918 by Serhiy Storchaka in 
branch '2.7':
bpo-33096: Removed unintentionally backported from Python 3 Tkinter files. 
(GH-6724)
https://github.com/python/cpython/commit/903f189b6e528cbe9500014c6f990c6511b38918


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +6417

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset e80a232f2cfdab584133d9779c83885c5f9f1ba6 by Serhiy Storchaka in 
branch '2.7':
[2.7] bpo-33096: Fix ttk.Treeview.insert. (GH-6228) (GH-6326)
https://github.com/python/cpython/commit/e80a232f2cfdab584133d9779c83885c5f9f1ba6


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +6040

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

[miss-islington]

miss-islington  added the comment:


New changeset 45116d393f713bbe918f16b33a0bba28b15bc96b by Miss Islington (bot) 
in branch '3.6':
bpo-33096: Fix ttk.Treeview.insert. (GH-6228)
https://github.com/python/cpython/commit/45116d393f713bbe918f16b33a0bba28b15bc96b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

[miss-islington]

miss-islington  added the comment:


New changeset a7b1b847f665aafc22557917cea32ec34c9b4418 by Miss Islington (bot) 
in branch '3.7':
bpo-33096: Fix ttk.Treeview.insert. (GH-6228)
https://github.com/python/cpython/commit/a7b1b847f665aafc22557917cea32ec34c9b4418


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

[miss-islington]

Change by miss-islington :


--
pull_requests: +5980

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

[miss-islington]

Change by miss-islington :


--
pull_requests: +5979

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 3ab44c0783eebdff687014f7d14d5dec59b6bd39 by Serhiy Storchaka 
(Garvit Khatri) in branch 'master':
bpo-33096: Fix ttk.Treeview.insert. (GH-6228)
https://github.com/python/cpython/commit/3ab44c0783eebdff687014f7d14d5dec59b6bd39


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

[Garvit Khatri]

Change by Garvit Khatri :


--
keywords: +patch
pull_requests: +5967
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Yes, this is expected.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

[Garvit Khatri]

Garvit Khatri  added the comment:

I made the changes on my machine and I\in my testing, it breaks on an empty 
string with an error saying
"Item already exists". If this is expected I would like to submit a patch with 
tests for the same.

--
nosy: +garvitdelhi

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

I have tested -- omitting the option and passing an empty string are treated 
different in Tk. Passing a duplicate iid is error. Thus the fix should be just 
`iid is not None`. But needed tests.

--
keywords: +easy
stage:  -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

[Terry J. Reedy]

Terry J. Reedy  added the comment:

This was initially reported in pydev thread "ttk.Treeview.insert() does not 
allow to insert item with iid=0" on 2018/3/16.  Igor, you should have mentioned 
on the thread that you had opened a tracker issue in response.  It was only 
happenstance that I did not open a duplicate.

I suggested there that 'if iid:' be replaced by 'if iid is not None:' but 
wondered if passing '"-id" ""' in the tk.call would be a problem.  If so, that 
would be a reason for the expanded check and suggest 'if iid in (None, ''):" as 
the replacement.

MRAB responded that '' is the id of the root of the tree.  But that does not 
tell me if passing a duplicate iid or that particular duplicate is a problem or 
not.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka
versions: +Python 2.7, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33096] ttk.Treeview.insert() does not allow to insert item with "False" iid

[Igor Yakovchenko]

New submission from Igor Yakovchenko :

ttk.Treeview.insert(... iid=None, ...) method has a check:
if iid:
res = self.tk.call(self._w, "insert", parent, index,
"-id", iid, *opts)
else:
res = self.tk.call(self._w, "insert", parent, index, *opts)

Documentation says that "If iid is specified, it is used as the item 
identifier", but as you can see from code, iid is used only if it's "True". It 
means that you cannot use iids like 0, 0.0 etc.

--
components: Tkinter
messages: 314032
nosy: gpolo, serhiy.storchaka, truestarecat
priority: normal
severity: normal
status: open
title: ttk.Treeview.insert() does not allow to insert item with "False" iid
type: behavior
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com