[issue33204] IDLE: remove \b from colorizer string prefix

[Terry J. Reedy]

Change by Terry J. Reedy :


--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33204] IDLE: remove \b from colorizer string prefix

[Terry J. Reedy]

Change by Terry J. Reedy :


--
resolution:  -> fixed
stage: patch review -> resolved

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33204] IDLE: remove \b from colorizer string prefix

[Tal Einat]

Tal Einat  added the comment:

Should this be closed as resolved?

--
nosy: +taleinat

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33204] IDLE: remove \b from colorizer string prefix

[miss-islington]

miss-islington  added the comment:


New changeset 306559e6ca15b86eb230609f484f48132b7ca383 by Miss Islington (bot) 
in branch '3.6':
bpo-33204: IDLE - revise and extend colorizer test. (GH-6347)
https://github.com/python/cpython/commit/306559e6ca15b86eb230609f484f48132b7ca383


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33204] IDLE: remove \b from colorizer string prefix

[miss-islington]

miss-islington  added the comment:


New changeset fa91aff07c16ad48a63580c2909934be92a5e9c8 by Miss Islington (bot) 
in branch '3.7':
bpo-33204: IDLE - revise and extend colorizer test. (GH-6347)
https://github.com/python/cpython/commit/fa91aff07c16ad48a63580c2909934be92a5e9c8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33204] IDLE: remove \b from colorizer string prefix

[miss-islington]

Change by miss-islington :


--
pull_requests: +6059

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33204] IDLE: remove \b from colorizer string prefix

[miss-islington]

Change by miss-islington :


--
pull_requests: +6058

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33204] IDLE: remove \b from colorizer string prefix

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset 55966f3a0d5f1bf823bd22ce1abbde267b06552f by Terry Jan Reedy in 
branch 'master':
bpo-33204: IDLE - revise and extend colorizer test. (GH-6347)
https://github.com/python/cpython/commit/55966f3a0d5f1bf823bd22ce1abbde267b06552f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33204] IDLE: remove \b from colorizer string prefix

[Terry J. Reedy]

Change by Terry J. Reedy :


--
pull_requests: +6057

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33204] IDLE: remove \b from colorizer string prefix

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Yes, still correct, as a keyword.  Legal "x or''" is colored as "x"  
"or"  "''" .  Legal "if'':" is colored as "if"  "''" 
 ":" ".  New PR revises colorizer test and add the above.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33204] IDLE: remove \b from colorizer string prefix

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Is ''or'' correctly colorized?

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33204] IDLE: remove \b from colorizer string prefix

[miss-islington]

miss-islington  added the comment:


New changeset 16cf84b4fbe78f9d876e0335f33459f1b92b7bf0 by Miss Islington (bot) 
in branch '3.6':
bpo-33204: IDLE: consistently color invalid string prefixes (GH-6344)
https://github.com/python/cpython/commit/16cf84b4fbe78f9d876e0335f33459f1b92b7bf0


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33204] IDLE: remove \b from colorizer string prefix

[miss-islington]

miss-islington  added the comment:


New changeset 6130675efeb3c23cebc43ab07c49eb62cd03cacf by Miss Islington (bot) 
in branch '3.7':
bpo-33204: IDLE: consistently color invalid string prefixes (GH-6344)
https://github.com/python/cpython/commit/6130675efeb3c23cebc43ab07c49eb62cd03cacf


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33204] IDLE: remove \b from colorizer string prefix

[miss-islington]

Change by miss-islington :


--
pull_requests: +6056

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33204] IDLE: remove \b from colorizer string prefix

[miss-islington]

Change by miss-islington :


--
pull_requests: +6055

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33204] IDLE: remove \b from colorizer string prefix

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset da58533ac67b01ce8f6466e6f03ff6b8b3bb04d5 by Terry Jan Reedy in 
branch 'master':
bpo-33204: IDLE: consistently color invalid string prefixes (#6344)
https://github.com/python/cpython/commit/da58533ac67b01ce8f6466e6f03ff6b8b3bb04d5


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33204] IDLE: remove \b from colorizer string prefix

[Terry J. Reedy]

Change by Terry J. Reedy :


--
stage: test needed -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33204] IDLE: remove \b from colorizer string prefix

[Terry J. Reedy]

Terry J. Reedy  added the comment:

To see the visually verified test, run Lib/idlelib/colorizer as the main 
module, either from a command line or editor, and click the button.

--
stage: patch review -> test needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33204] IDLE: remove \b from colorizer string prefix

[Terry J. Reedy]

Change by Terry J. Reedy :


--
keywords: +patch
pull_requests: +6054
stage: test needed -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33204] IDLE: remove \b from colorizer string prefix

[Tim Peters]

Tim Peters  added the comment:

Sounds good (removing \b) to me, Terry!

--
nosy: +tim.peters

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33204] IDLE: remove \b from colorizer string prefix

[Terry J. Reedy]

Terry J. Reedy  added the comment:

The current test is part of the htest.  The section
# All valid prefixes for unicode and byte strings should be colored
contains "ur'is invalid'".  This should be moved to a new section with other 
invalid combinations.

# Invalid combinations of legal characters should be half colored.
ur'x', ru'x', uf'x', fu'x', UR'x'
(only one CAPS example is needed now).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33204] IDLE: remove \b from colorizer string prefix

[Terry J. Reedy]

New submission from Terry J. Reedy :

Lib\idlelib\colorizer.py, line 25, is:
  stringprefix = r"(?i:\br|u|f|fr|rf|b|br|rb)?"

The r prefix, but only the r prefix, must be preceded by a non-word character.

On pydev thread "IDLE colorizer", MRAB noted: "The \b will apply only to the 
first choice. Shouldn't it be more like:
  stringprefix = r"(?:\b(?i:r|u|f|fr|rf|b|br|rb))?"

I think the \b should be removed instead.  Currently uf'a' gets f'a' colored, 
while ur'a' only gets  'a' colored.  (Tim Peters pointed out the difference 
with a different example.) I prefer coloring the maximal legal string rather 
than the minimum.I think the contrast between two chars legal by 
themselves, but differently colored when put together, makes the bug more 
obvious.

--
assignee: terry.reedy
components: IDLE
messages: 314793
nosy: terry.reedy
priority: normal
severity: normal
stage: test needed
status: open
title: IDLE: remove \b from colorizer string prefix
type: behavior
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com