[issue33270] tags for anonymous code objects should be interned

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Thank you for your contribution Zackery.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33270] tags for anonymous code objects should be interned

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset f303639e3ac96cfe6c1438f1c594226941f46216 by Serhiy Storchaka 
(Zackery Spytz) in branch 'master':
bpo-33270: Intern names for all anonymous code objects (#6472)
https://github.com/python/cpython/commit/f303639e3ac96cfe6c1438f1c594226941f46216


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33270] tags for anonymous code objects should be interned

[Antoine Pitrou]

Change by Antoine Pitrou :


--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33270] tags for anonymous code objects should be interned

[Zackery Spytz]

Change by Zackery Spytz :


--
keywords: +patch
pull_requests: +6171
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33270] tags for anonymous code objects should be interned

[Raymond Hettinger]

Raymond Hettinger  added the comment:

+1

--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33270] tags for anonymous code objects should be interned

[Brett Cannon]

Change by Brett Cannon :


--
stage:  -> needs patch
type:  -> enhancement
versions: +Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33270] tags for anonymous code objects should be interned

[Daniel Moisset]

New submission from Daniel Moisset :

In compile.c, some strings are created to be used as name of anonymous code 
objects: "", "", "", "", "" and 
"".

Only the first two of those are interned (created with 
PyUnicode_InternFromString ), the rest are created with "PyUnicode_FromString". 
Even if they use a static variable to avoid creating multiple instances, not 
interning results in multiple copies when code objects are marshaled into pyc 
files and reloaded (one copy per module).

Always using PyUnicode_InternFromString should be more consistent, and slightly 
more efficient

--
components: Interpreter Core
messages: 315232
nosy: Daniel Moisset
priority: normal
severity: normal
status: open
title: tags for anonymous code objects should be interned

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com