[issue34456] pickle: Missing NULL check in save_global()

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

We don't bother to fix low probably bugs in 2.7 if the code is too different 
from 3.x. But if you create a PR it will be merged. Seems this should be a 
separate issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34456] pickle: Missing NULL check in save_global()

[Alexey Izbyshev]

Alexey Izbyshev  added the comment:

No, I couldn't find any similar calls in save_global() in 2.7.

However, there is Py_BuildValue() call in initcPickle(), and its result is 
passed unchecked to PyDict_SetItemString(), where it's eventually dereferenced. 
In fact, all PyDict_SetItemString() calls in initcPickle() are made without 
checking for NULL. Should I file an issue for that?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34456] pickle: Missing NULL check in save_global()

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Is 2.7 affected?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34456] pickle: Missing NULL check in save_global()

[Alexey Izbyshev]

Change by Alexey Izbyshev :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34456] pickle: Missing NULL check in save_global()

[miss-islington]

miss-islington  added the comment:


New changeset b14a68fd7d8f02bd133b59709f969c1c564f5978 by Miss Islington (bot) 
in branch '3.6':
bpo-34456: pickle: Add missing NULL check to save_global(). (GH-8851)
https://github.com/python/cpython/commit/b14a68fd7d8f02bd133b59709f969c1c564f5978


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34456] pickle: Missing NULL check in save_global()

[miss-islington]

miss-islington  added the comment:


New changeset 3152bc36fd1a8ab349d6802e9b48dd88a35b3620 by Miss Islington (bot) 
in branch '3.7':
bpo-34456: pickle: Add missing NULL check to save_global(). (GH-8851)
https://github.com/python/cpython/commit/3152bc36fd1a8ab349d6802e9b48dd88a35b3620


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34456] pickle: Missing NULL check in save_global()

[miss-islington]

Change by miss-islington :


--
pull_requests: +8326

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34456] pickle: Missing NULL check in save_global()

[miss-islington]

Change by miss-islington :


--
pull_requests: +8325

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34456] pickle: Missing NULL check in save_global()

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset f8c06b028036e50596e75d4c9f6b27ba05133efe by Serhiy Storchaka 
(Alexey Izbyshev) in branch 'master':
bpo-34456: pickle: Add missing NULL check to save_global(). (GH-8851)
https://github.com/python/cpython/commit/f8c06b028036e50596e75d4c9f6b27ba05133efe


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34456] pickle: Missing NULL check in save_global()

[Alexey Izbyshev]

Change by Alexey Izbyshev :


--
keywords: +patch
pull_requests: +8323
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34456] pickle: Missing NULL check in save_global()

[Alexey Izbyshev]

New submission from Alexey Izbyshev :

The return value of Py_BuildValue() is dereferenced without checking at 
https://github.com/python/cpython/blob/ef8861c112ed1dac9351958c121bc24ca4ecdb08/Modules/_pickle.c#L3457

Reported by Svace static analyzer.

--
components: Extension Modules
messages: 323853
nosy: izbyshev, serhiy.storchaka
priority: normal
severity: normal
status: open
title: pickle: Missing NULL check in save_global()
type: behavior
versions: Python 3.5, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com