[issue34457] Missing NULL check in alias_for_import_name() from Python/ast.c

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34457] Missing NULL check in alias_for_import_name() from Python/ast.c

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 5223ce2131a121201a78d0680302ea06c4a58369 by Serhiy Storchaka 
(Alexey Izbyshev) in branch '2.7':
[2.7] bpo-34457: Python/ast.c: Add missing NULL check to 
alias_for_import_name(). (GH-8852) (GH-8858)
https://github.com/python/cpython/commit/5223ce2131a121201a78d0680302ea06c4a58369


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34457] Missing NULL check in alias_for_import_name() from Python/ast.c

[Alexey Izbyshev]

Change by Alexey Izbyshev :


--
pull_requests: +8329

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34457] Missing NULL check in alias_for_import_name() from Python/ast.c

[miss-islington]

miss-islington  added the comment:


New changeset 0ef61ee7b194a1c15747d6bca3cf30a5c581e7e3 by Miss Islington (bot) 
in branch '3.6':
bpo-34457: Python/ast.c: Add missing NULL check to alias_for_import_name(). 
(GH-8852)
https://github.com/python/cpython/commit/0ef61ee7b194a1c15747d6bca3cf30a5c581e7e3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34457] Missing NULL check in alias_for_import_name() from Python/ast.c

[miss-islington]

miss-islington  added the comment:


New changeset b8e7319d39bf44355bf60f9bbec07cfbbe56739d by Miss Islington (bot) 
in branch '3.7':
bpo-34457: Python/ast.c: Add missing NULL check to alias_for_import_name(). 
(GH-8852)
https://github.com/python/cpython/commit/b8e7319d39bf44355bf60f9bbec07cfbbe56739d


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34457] Missing NULL check in alias_for_import_name() from Python/ast.c

[miss-islington]

Change by miss-islington :


--
pull_requests: +8328

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34457] Missing NULL check in alias_for_import_name() from Python/ast.c

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 28853a249b1d0c890b7e9ca345290bb8c1756446 by Serhiy Storchaka 
(Alexey Izbyshev) in branch 'master':
bpo-34457: Python/ast.c: Add missing NULL check to alias_for_import_name(). 
(GH-8852)
https://github.com/python/cpython/commit/28853a249b1d0c890b7e9ca345290bb8c1756446


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34457] Missing NULL check in alias_for_import_name() from Python/ast.c

[miss-islington]

Change by miss-islington :


--
pull_requests: +8327

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34457] Missing NULL check in alias_for_import_name() from Python/ast.c

[Alexey Izbyshev]

Change by Alexey Izbyshev :


--
keywords: +patch
pull_requests: +8324
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34457] Missing NULL check in alias_for_import_name() from Python/ast.c

[Alexey Izbyshev]

Alexey Izbyshev  added the comment:

The NULL dereference seems to be hard to trigger due to caching for 
one-character Latin-1 strings, but being safe probably won't hurt.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34457] Missing NULL check in alias_for_import_name() from Python/ast.c

[Alexey Izbyshev]

New submission from Alexey Izbyshev :

The return value of PyUnicode_InternFromString() is dereferenced without 
checking at 
https://github.com/python/cpython/blob/ef8861c112ed1dac9351958c121bc24ca4ecdb08/Python/ast.c#L3256

Reported by Svace static analyzer.

--
components: Interpreter Core
messages: 323854
nosy: izbyshev, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Missing NULL check in alias_for_import_name() from Python/ast.c
type: behavior
versions: Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com