[issue34474] Python/bltinmodule.c: Missing NULL check in builtin_sum_impl()

[miss-islington]

miss-islington  added the comment:


New changeset 45ee452751d095d665717bafb61cfd7c65b729b4 by Miss Islington (bot) 
in branch '2.7':
closes bpo-34474: Python/bltinmodule.c: Add missing NULL check in 
builtin_sum_impl() (GH-8872)
https://github.com/python/cpython/commit/45ee452751d095d665717bafb61cfd7c65b729b4


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34474] Python/bltinmodule.c: Missing NULL check in builtin_sum_impl()

[miss-islington]

miss-islington  added the comment:


New changeset 7d470f3f24d0c091cf1da4f13695c6bb3200a713 by Miss Islington (bot) 
in branch '3.6':
closes bpo-34474: Python/bltinmodule.c: Add missing NULL check in 
builtin_sum_impl() (GH-8872)
https://github.com/python/cpython/commit/7d470f3f24d0c091cf1da4f13695c6bb3200a713


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34474] Python/bltinmodule.c: Missing NULL check in builtin_sum_impl()

[miss-islington]

miss-islington  added the comment:


New changeset a59036365b304d43bba0f050fa9a7d76100e0ae1 by Miss Islington (bot) 
in branch '3.7':
closes bpo-34474: Python/bltinmodule.c: Add missing NULL check in 
builtin_sum_impl() (GH-8872)
https://github.com/python/cpython/commit/a59036365b304d43bba0f050fa9a7d76100e0ae1


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34474] Python/bltinmodule.c: Missing NULL check in builtin_sum_impl()

[miss-islington]

Change by miss-islington :


--
pull_requests: +8363

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34474] Python/bltinmodule.c: Missing NULL check in builtin_sum_impl()

[miss-islington]

Change by miss-islington :


--
pull_requests: +8364

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34474] Python/bltinmodule.c: Missing NULL check in builtin_sum_impl()

[Benjamin Peterson]

Benjamin Peterson  added the comment:


New changeset 2b824b2538c4a5f9f520c5de8a1eae5a0c181a94 by Benjamin Peterson 
(Alexey Izbyshev) in branch 'master':
closes bpo-34474: Python/bltinmodule.c: Add missing NULL check in 
builtin_sum_impl() (GH-8872)
https://github.com/python/cpython/commit/2b824b2538c4a5f9f520c5de8a1eae5a0c181a94


--
nosy: +benjamin.peterson
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34474] Python/bltinmodule.c: Missing NULL check in builtin_sum_impl()

[miss-islington]

Change by miss-islington :


--
pull_requests: +8362

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34474] Python/bltinmodule.c: Missing NULL check in builtin_sum_impl()

[Berker Peksag]

Berker Peksag  added the comment:

Personally I wouldn't bother fixing 2.7, but let's see what other core devs 
think.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34474] Python/bltinmodule.c: Missing NULL check in builtin_sum_impl()

[Alexey Izbyshev]

Change by Alexey Izbyshev :


--
keywords: +patch
pull_requests: +8350
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34474] Python/bltinmodule.c: Missing NULL check in builtin_sum_impl()

[Alexey Izbyshev]

New submission from Alexey Izbyshev :

The return value of PyFloat_FromDouble() at 
https://github.com/python/cpython/blob/48ce4897f8f8d91d948ecd1241ffab002df2be9e/Python/bltinmodule.c#L2403
 is not checked for NULL and then dereferenced.

Reported by Svace static analyzer.

A similar issue in an 'if' statement above was fixed in #18560. Note that 2.7 
is affected by both issues, so I can fix both if needed.

--
components: Interpreter Core
messages: 323946
nosy: berker.peksag, izbyshev, pitrou, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Python/bltinmodule.c: Missing NULL check in builtin_sum_impl()
type: behavior
versions: Python 2.7, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com