[issue34482] datetime: Tests for potential crashes due to non-UTF-8-encodable strings

2018-11-27 Thread Alexey Izbyshev 


Alexey Izbyshev  added the comment:

The added test exposed a leak in unicode_encode_locale(). See msg330534.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34482] datetime: Tests for potential crashes due to non-UTF-8-encodable strings

2018-11-26 Thread STINNER Victor 


STINNER Victor  added the comment:

It seems like thie issue introduced a memory leak: bpo-35322 .

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34482] datetime: Tests for potential crashes due to non-UTF-8-encodable strings

2018-10-23 Thread Tal Einat 


Tal Einat  added the comment:

Thanks for the PR, Alexey!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34482] datetime: Tests for potential crashes due to non-UTF-8-encodable strings

2018-10-23 Thread miss-islington 


miss-islington  added the comment:


New changeset 313e5015d258778737bff766a8ccf997a0cc20c7 by Miss Islington (bot) 
in branch '3.7':
bpo-34482: test datetime classes' handling of non-UTF-8-encodable strings 
(GH-8878)
https://github.com/python/cpython/commit/313e5015d258778737bff766a8ccf997a0cc20c7


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34482] datetime: Tests for potential crashes due to non-UTF-8-encodable strings

2018-10-23 Thread miss-islington 


Change by miss-islington :


--
pull_requests: +9387

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34482] datetime: Tests for potential crashes due to non-UTF-8-encodable strings

2018-10-23 Thread Tal Einat 


Tal Einat  added the comment:


New changeset 3b0047d8e982b10b34ab05fd207b7d513cc1188a by Tal Einat (Alexey 
Izbyshev) in branch 'master':
bpo-34482: test datetime classes' handling of non-UTF-8-encodable strings 
(GH-8878)
https://github.com/python/cpython/commit/3b0047d8e982b10b34ab05fd207b7d513cc1188a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34482] datetime: Tests for potential crashes due to non-UTF-8-encodable strings

2018-08-28 Thread Alexey Izbyshev 


Alexey Izbyshev  added the comment:

Yes, I've referenced the relevant message from #6697 in #34454.

The specific test you've referenced should be changed after #34481 is fixed -- 
it highlights inconsistency between C and Python implementations.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34482] datetime: Tests for potential crashes due to non-UTF-8-encodable strings

2018-08-27 Thread Paul Ganssle 


Paul Ganssle  added the comment:

Somewhat related: #6697.

Turns out there are already some tests here for this, specifically for the C 
version only: 
https://github.com/python/cpython/blob/master/Lib/test/datetimetester.py#L3328

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34482] datetime: Tests for potential crashes due to non-UTF-8-encodable strings

2018-08-23 Thread Alexey Izbyshev 


Change by Alexey Izbyshev :


--
pull_requests: +8355

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34482] datetime: Tests for potential crashes due to non-UTF-8-encodable strings

2018-08-23 Thread Alexey Izbyshev 


Change by Alexey Izbyshev :


--
keywords: +patch
pull_requests: +8353
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34482] datetime: Tests for potential crashes due to non-UTF-8-encodable strings

2018-08-23 Thread Alexey Izbyshev 


New submission from Alexey Izbyshev :

This is a follow-up of #34454. 'datetime' extension module attempts to encode 
input strings into UTF-8 in several places, which requires special care because 
some valid Python strings can't be represented in UTF-8. It makes sense to add 
more tests for methods dealing with strings.

Note that my PR doesn't attempt to deal with #34481. In cases where behavior 
differs between C and Python datetime impls the tests check only for  absence 
of crashes.

--
components: Extension Modules
messages: 323964
nosy: belopolsky, izbyshev, p-ganssle, serhiy.storchaka, taleinat
priority: normal
severity: normal
status: open
title: datetime: Tests for potential crashes due to non-UTF-8-encodable strings
type: security
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com