[issue34504] PySequence_Check: argument is dereferenced and then checked for NULL

[miss-islington]

miss-islington  added the comment:


New changeset d60bdf239e322316c8b5e37679cb8e789028aae2 by Miss Islington (bot) 
in branch '3.6':
closes bpo-34504: Remove the useless NULL check in PySequence_Check(). (GH-8935)
https://github.com/python/cpython/commit/d60bdf239e322316c8b5e37679cb8e789028aae2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34504] PySequence_Check: argument is dereferenced and then checked for NULL

[miss-islington]

miss-islington  added the comment:


New changeset d6725fcdd54cb3c72201eaa8841dd72d84f5f71d by Miss Islington (bot) 
in branch '3.7':
closes bpo-34504: Remove the useless NULL check in PySequence_Check(). (GH-8935)
https://github.com/python/cpython/commit/d6725fcdd54cb3c72201eaa8841dd72d84f5f71d


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34504] PySequence_Check: argument is dereferenced and then checked for NULL

[miss-islington]

Change by miss-islington :


--
pull_requests: +8409

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34504] PySequence_Check: argument is dereferenced and then checked for NULL

[miss-islington]

Change by miss-islington :


--
pull_requests: +8408

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34504] PySequence_Check: argument is dereferenced and then checked for NULL

[Benjamin Peterson]

Benjamin Peterson  added the comment:


New changeset b57b4ac042b977e0b42a2f5ddb30ca7edffacfa9 by Benjamin Peterson 
(Alexey Izbyshev) in branch 'master':
closes bpo-34504: Remove the useless NULL check in PySequence_Check(). (GH-8935)
https://github.com/python/cpython/commit/b57b4ac042b977e0b42a2f5ddb30ca7edffacfa9


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34504] PySequence_Check: argument is dereferenced and then checked for NULL

[Alexey Izbyshev]

Change by Alexey Izbyshev :


--
keywords: +patch
pull_requests: +8407
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34504] PySequence_Check: argument is dereferenced and then checked for NULL

[Alexey Izbyshev]

New submission from Alexey Izbyshev :

The argument of PySequence_Check() is dereferenced at 
https://github.com/python/cpython/blob/5f79b50763d687aeeed8edcb4efcc7ac9f8fa186/Objects/abstract.c#L1511
 and then checked for NULL.

Reported by Svace static analyzer.

Since other PySomething_Check() functions seem to expect a non-NULL argument, I 
suggest to remove the NULL check instead of moving it.

--
components: Interpreter Core
messages: 324101
nosy: benjamin.peterson, berker.peksag, izbyshev, serhiy.storchaka
priority: normal
severity: normal
status: open
title: PySequence_Check: argument is dereferenced and then checked for NULL
type: behavior
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com