[issue34536] Enum._missing_ doesn't raise TypeError when a non-Enum object is a returned

[Ethan Furman]

Change by Ethan Furman :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34536] Enum._missing_ doesn't raise TypeError when a non-Enum object is a returned

[Ethan Furman]

Ethan Furman  added the comment:


New changeset 4acf6c9d4be77b968fa498569d7a1545e5e77344 by Ethan Furman (Victor 
Stinner) in branch 'master':
bpo-34536: Cleanup test_enum imports (GH-9979)
https://github.com/python/cpython/commit/4acf6c9d4be77b968fa498569d7a1545e5e77344


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34536] Enum._missing_ doesn't raise TypeError when a non-Enum object is a returned

[STINNER Victor]

STINNER Victor  added the comment:

> Why does the above say 9319 when the PR is 9978?

Roundup (the software running bugs.python.org) logs its own internal identifier 
for pull requests. Following https://bugs.python.org/pull_request9320 may help 
you to understand :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34536] Enum._missing_ doesn't raise TypeError when a non-Enum object is a returned

[Ethan Furman]

Ethan Furman  added the comment:


New changeset 0f2fc8bee0b435ee2934751264196db30d16ed8a by Ethan Furman (Victor 
Stinner) in branch '3.7':
bpo-34536: raise error for invalid _missing_ results (GH-9147) (GH-9978)
https://github.com/python/cpython/commit/0f2fc8bee0b435ee2934751264196db30d16ed8a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34536] Enum._missing_ doesn't raise TypeError when a non-Enum object is a returned

[Ethan Furman]

Ethan Furman  added the comment:

Change by STINNER Victor:

> pull_requests: +9319

Why does the above say 9319 when the PR is 9978?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34536] Enum._missing_ doesn't raise TypeError when a non-Enum object is a returned

[STINNER Victor]

STINNER Victor  added the comment:

I wrote PR 9978 to backport the fix to Python 3.7.

Should the fix be backported to Python 3.6 as well?

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34536] Enum._missing_ doesn't raise TypeError when a non-Enum object is a returned

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +9320

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34536] Enum._missing_ doesn't raise TypeError when a non-Enum object is a returned

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +9319

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34536] Enum._missing_ doesn't raise TypeError when a non-Enum object is a returned

[miss-islington]

Change by miss-islington :


--
pull_requests: +8805

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34536] Enum._missing_ doesn't raise TypeError when a non-Enum object is a returned

[Ethan Furman]

Ethan Furman  added the comment:


New changeset 019f0a0cb85ebc234356415f3638b9bd77528e55 by Ethan Furman in 
branch 'master':
bpo-34536: raise error for invalid _missing_ results (GH-9147)
https://github.com/python/cpython/commit/019f0a0cb85ebc234356415f3638b9bd77528e55


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34536] Enum._missing_ doesn't raise TypeError when a non-Enum object is a returned

[Ethan Furman]

Change by Ethan Furman :


--
keywords: +patch, patch, patch
pull_requests: +8636, 8637, 8638
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34536] Enum._missing_ doesn't raise TypeError when a non-Enum object is a returned

[Ethan Furman]

Change by Ethan Furman :


--
keywords: +patch, patch
pull_requests: +8636, 8637
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34536] Enum._missing_ doesn't raise TypeError when a non-Enum object is a returned

[Ethan Furman]

Change by Ethan Furman :


--
keywords: +patch
pull_requests: +8636
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34536] Enum._missing_ doesn't raise TypeError when a non-Enum object is a returned

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34536] Enum._missing_ doesn't raise TypeError when a non-Enum object is a returned

[Ethan Furman]

Change by Ethan Furman :


--
assignee:  -> ethan.furman
nosy: +ethan.furman

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34536] Enum._missing_ doesn't raise TypeError when a non-Enum object is a returned

[Paul Pinterits]

New submission from Paul Pinterits :

In a conversation with Ethan Furman (the author of the enum module) I've been 
informed that Enum automatically checks whether the _missing_ method has 
returned an instance of the correct class, and raises a TypeError if not. 
(Link: https://stackoverflow.com/a/52064774/1222951)

However, this simply does not happen.

```
import enum

class MyEnum(enum.Enum):
FOO = "foo"

@classmethod
def _missing_(cls, value):
return 5

print(MyEnum('bar'))  # output: 5
```

--
components: Library (Lib)
messages: 324282
nosy: Paul Pinterits
priority: normal
severity: normal
status: open
title: Enum._missing_ doesn't raise TypeError when a non-Enum object is a 
returned
type: behavior
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com