[issue34624] -W option does not accept module regexes

[Thomas Gläßle]

Thomas Gläßle  added the comment:

Thanks for your response. I have opened a PR at [1] that would remove the 
re.escape such that the implementation matches the documentation if you decide 
that this is fine.

[1]: https://github.com/python/cpython/pull/9358

Personally, I would go even further and always add the `(\..*)?$` suffix 
(instead of only `$`) to make it easier to match all modules in a package which 
is probably the most important use-case for the case of packages. What do you 
think?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34624] -W option does not accept module regexes

[Thomas Gläßle]

Change by Thomas Gläßle :


--
keywords: +patch
pull_requests: +8781
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34624] -W option does not accept module regexes

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

The original escape was done with 2a862c614d6d3ff50dc644150670651fdc9f3a99 
which was in 2000. The doc example you are referring to at [1] was added with 
https://bugs.python.org/issue31975 and there doesn't seem to be a test 
involving regular expression as I can see from the PR. Adding Nick to the issue 
since he had committed the doc and might help here.


[1] https://docs.python.org/3/library/warnings.html#describing-warning-filters

Thanks

--
nosy: +ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34624] -W option does not accept module regexes

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34624] -W option does not accept module regexes

[Thomas Gläßle]

Thomas Gläßle  added the comment:

Very sorry, the example command above should read:

  python -Wi -W'default:::.*' -c 'import warnings; warnings.warn("This should 
show up")'

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34624] -W option does not accept module regexes

[Thomas Gläßle]

New submission from Thomas Gläßle :

Hi,

This command does not report a warning, while it should:

  python -c 'import warnings; warnings.warn("This should show up")' -Wi 
-W'default:::.*'

If the regex `.*` is replaced by `__main__` it works as expected.

Same applies for regexes in PYTHONWARNINGS and for the `message` part of the 
argument. 

The reason can be found in Lib/warnings.py:144 (def _setoption):

  module = re.escape(module)

This point-blank escape makes me think that it was intended that no regexes can 
be passed to message/module. On the other, the documentation reads as if it 
should be supported.

Specifically, the -W option is documented in [1]. While this page lists only 
basic examples, it refers to [2] and [3] for more details. [2] states that 
message/module are regexes. [3] seems to be written to specifically address the 
syntax of the PYTHONWARNINGS and the -W option and explicitly lists an example 
with a regex.

[1]: https://docs.python.org/3/using/cmdline.html#cmdoption-w
[2]: https://docs.python.org/3/library/warnings.html#warning-filter
[3]: https://docs.python.org/3/library/warnings.html#describing-warning-filters

I would welcome if we could remove `re.escape` to make the implementation fit 
the documentation, or are there any downsides to this?


Best regards, Thomas

--
components: Library (Lib)
messages: 324959
nosy: coldfix
priority: normal
severity: normal
status: open
title: -W option does not accept module regexes
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com