[issue36711] duplicate method definition in Lib/email/feedparser.py

[Benjamin Peterson]

Benjamin Peterson  added the comment:


New changeset b239ab9107cd5bcbfbfa3b46290191298718ced3 by Benjamin Peterson 
(Zackery Spytz) in branch '2.7':
closes bpo-36711: Remove duplicate method in Lib/email/feedparser.py. (GH-14801)
https://github.com/python/cpython/commit/b239ab9107cd5bcbfbfa3b46290191298718ced3


--
nosy: +benjamin.peterson
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36711] duplicate method definition in Lib/email/feedparser.py

[Zackery Spytz]

Change by Zackery Spytz :


--
nosy: +ZackerySpytz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36711] duplicate method definition in Lib/email/feedparser.py

[Zackery Spytz]

Change by Zackery Spytz :


--
keywords: +patch
pull_requests: +14597
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/14801

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36711] duplicate method definition in Lib/email/feedparser.py

[Martin Panter]

Martin Panter  added the comment:

This is caused by Serhiy’s first change to 2.7 in Issue 21448. Compare 
Mercurial rev. 1b1f92e39462 (3.4 branch) with ba90bd01c5f1 (2.7). In 2.7, he 
applied the Python 3 version of the code, which used “str.splitlines” rather 
than a regular expression “NLCRE_crack.split”. This seems reasonable, but the 
old Python 2 code remains under a spurious “def pushlines” block.

I think that first block of “pushlines” can safely be removed, just leaving the 
second version, a single line of code like in Python 3.

--
components: +email -Library (Lib)
nosy: +barry, martin.panter, r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36711] duplicate method definition in Lib/email/feedparser.py

[Xavier de Gaye]

New submission from Xavier de Gaye :

As reported in issue 16079, the following method is a duplicate:

Lib/email/feedparser.py:140 BufferedSubFile.pushlines

--
components: Library (Lib)
messages: 340778
nosy: xdegaye
priority: normal
severity: normal
stage: needs patch
status: open
title: duplicate method definition in Lib/email/feedparser.py
type: behavior
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com