[issue44515] contextlib test incompatibility with non-refcounted GC

[Łukasz Langa]

Łukasz Langa  added the comment:

Thanks, Nick! ✨  ✨

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44515] contextlib test incompatibility with non-refcounted GC

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset 0ea5e0d792a85b435ef299319dcd52e59f535cb1 by Miss Islington (bot) 
in branch '3.10':
bpo-44515: handle non-refcounted GC in contextlib tests (GH-26910) (GH-27379)
https://github.com/python/cpython/commit/0ea5e0d792a85b435ef299319dcd52e59f535cb1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44515] contextlib test incompatibility with non-refcounted GC

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 2.0 -> 3.0
pull_requests: +25914
pull_request: https://github.com/python/cpython/pull/27379

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44515] contextlib test incompatibility with non-refcounted GC

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset a2c45e5bcf9d3dfff9f2699dbc161489897616b5 by Nick Coghlan in 
branch 'main':
bpo-44515: handle non-refcounted GC in contextlib tests (GH-26910)
https://github.com/python/cpython/commit/a2c45e5bcf9d3dfff9f2699dbc161489897616b5


--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44515] contextlib test incompatibility with non-refcounted GC

[Nick Coghlan]

Change by Nick Coghlan :


--
keywords: +patch
pull_requests: +25486
stage: commit review -> patch review
pull_request: https://github.com/python/cpython/pull/26910

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44515] contextlib test incompatibility with non-refcounted GC

[Nick Coghlan]

Change by Nick Coghlan :


--
versions: +Python 3.10, Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue44515] contextlib test incompatibility with non-refcounted GC

[Nick Coghlan]

New submission from Nick Coghlan :

Backporting the latest contextlib module and test suite to contextlib2, I ran 
into a couple of CI failures on PyPy3.

Investigation showed that a couple of the new test cases were assuming the use 
of a refcounted GC. One could be fixed by switching to using a synchronous 
context manager instead of a ``__del__`` method, but the other needed a few 
explicit gc.collect() calls.

--
assignee: ncoghlan
keywords: 3.10regression
messages: 396545
nosy: ncoghlan, yselivanov
priority: normal
severity: normal
stage: commit review
status: open
title: contextlib test incompatibility with non-refcounted GC
type: behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com