[issue47090] Make zlib required on all platforms (simplifies code)

[Gregory P. Smith]

Gregory P. Smith  added the comment:

Bringing this up on discord, others point out that the windows build requires 
zlib for convenience when we transitioned from having a vendored copy in our 
repo and that smaller "embedded" use cases may not like this if they don't 
already need the dep. But there have been no complaints about it on the Windows 
side.

`binascii.crc32` was one thing that motivated me to look into "just require 
zlib" to get out of carrying our own suboptimal crc32 code.  along those lines, 
we should recommend people choose https://github.com/zlib-ng/zlib-ng rather 
than zlib.net for better performance.

looking over my PR, it can make for some awkward code with zlib right next to 
others that we treat as optionals.  good bad or indifferent?  i'm leaning 
towards indifferent and still enjoying fewer lines of code.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47090] Make zlib required on all platforms (simplifies code)

[Gregory P. Smith]

Change by Gregory P. Smith :


--
keywords: +patch
pull_requests: +30133
pull_request: https://github.com/python/cpython/pull/32043

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue47090] Make zlib required on all platforms (simplifies code)

[Gregory P. Smith]

New submission from Gregory P. Smith :

We have a pile of conditionals and extra code in CPython to deal with building 
on systems that do not have zlib.  The zlib C library has been around forever 
at this point and should be present on every system in the world.

zlib is already required on Windows to build CPython.

Proposal: simplify our code by removing the conditionals around zlib being 
optional.  I'm attaching a draft PR to show what this would look like.

--
assignee: gregory.p.smith
components: Build, Extension Modules, Library (Lib)
messages: 415750
nosy: gregory.p.smith
priority: normal
severity: normal
stage: patch review
status: open
title: Make zlib required on all platforms (simplifies code)
versions: Python 3.11

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com