[issue8110] subprocess.py doesn't correctly detect Windows machines

[Zachary Ware]

Change by Zachary Ware :


--
versions:  -Python 2.7, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Gregory P. Smith]

Gregory P. Smith  added the comment:

lets call this fixed.  if and only if another Python implementation pipes up as 
happier if this exists in an older than 3.8 version we can consider backporting 
the same refactoring to that code.

--
resolution:  -> fixed
stage: patch review -> commit review
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Zachary Ware]

Zachary Ware  added the comment:

Do we want to bother backporting anything, or call it fixed in 3.8 and move on?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Zachary Ware]

Zachary Ware  added the comment:


New changeset 880d42a3b247306f67837aa95e23f7c3471a30a3 by Zachary Ware in 
branch 'master':
bpo-8110: Refactor platform detection in subprocess (GH-9053)
https://github.com/python/cpython/commit/880d42a3b247306f67837aa95e23f7c3471a30a3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Zachary Ware]

Zachary Ware  added the comment:

This one has nothing to do with Cygwin, this is about minimizing patching that 
IronPython (or other implementations) have to do to standard library modules.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[STINNER Victor]

STINNER Victor  added the comment:

I don't think that we should backport this change to 3.7 and older.

I understand that the change is about supporting Cygwin. My policy to support a 
new platform is always the same: first fix *all* issues in master, get a 
working CI, find a core developer responsible to fix all issues specific to 
this platform, and only after that we can start discussing about backporting 
specific changes for that platform.

https://pythondev.readthedocs.io/cpython.html#i-want-cpython-to-support-my-platform

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Zachary Ware]

Zachary Ware  added the comment:

The real question isn't "are we on Windows?" but rather "should we use 
msvcrt/_winapi or _posixsubprocess/select?", which is what my PR is designed to 
better fit.  I could see how we wouldn't want to backport that patch to 
maintenance branches, though; it's a significant rearrangement.  If we do want 
to backport *a* fix, I agree that simply adding `or os.name == 'nt'` should be 
sufficiently low-impact.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Giampaolo Rodola']

Giampaolo Rodola'  added the comment:

If os.name == 'nt' is True on IronPython then why not simply do:

mswindows = sys.platform == "win32" or os.name == "nt"

For the record, both variants are used in different places in cPython source 
code. It would nice to figure out a golden standard and apply it everywhere. 
Maybe even add it as a new WINDOWS constant in the platform module.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Zachary Ware]

Change by Zachary Ware :


--
nosy: +giampaolo.rodola, gregory.p.smith
versions: +Python 3.6, Python 3.7, Python 3.8 -Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Mark Lawrence]

Change by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Zachary Ware]

Change by Zachary Ware :


--
pull_requests: +8514

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Brian Curtin]

Changes by Brian Curtin br...@python.org:


--
nosy:  -brian.curtin

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Mark Lawrence]

Mark Lawrence added the comment:

Just to note that this is referenced from #19453 pydoc and ironpython.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Zachary Ware]

Zachary Ware added the comment:

How about this?  Should apply equally to 3.4 and default, 2.7 is different but 
can use the same concept (with s/_winapi/_subprocess/ among other changes).

--
nosy: +zach.ware
stage: test needed - patch review
versions: +Python 3.4, Python 3.5 -Python 2.6, Python 3.1, Python 3.2
Added file: http://bugs.python.org/file36063/issue8110.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Jim Jewett]

Jim Jewett added the comment:

It would be good to have the library work unchanged on both implementations.

If subprocess only failed later, it would be less good, as the stdlib would 
then set an example that doesn't actually succeed.

Note that the attached patch (by flox) does NOT implement the discussed or 
tests on sysm.platform; it instead checks whether _subprocess it importable.  
Is the assumption of an accelerator module itself too implementation-specific?  
I'm also not sure that the test in the patch isn't too broad -- is windows the 
only platform with _subprocess?  Because if not, then the new test would mess 
up logic later in the file, such as that at line 635 in Popen.__init__

--
nosy: +Jim.Jewett

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Jim Jewett]

Jim Jewett added the comment:

(The above concerns -- other than whether it is sufficient to work -- do not 
apply to the change at 
https://bitbucket.org/ironpython/ironlanguages/commits/b6bb2a9a7bc5/  )

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[STINNER Victor]

STINNER Victor added the comment:

 sys.platform == cli or sys.platform == silverlight

It cannot happen in CPython, so I think that it's fine to leave CPython stdlib 
unchanged. I consider that the issue is fixed because the bug report was for 
IronPython and the bug was fixed there.

--
nosy: +haypo
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[R. David Murray]

R. David Murray added the comment:

It doesn't matter that it can't happen in CPython.  The idea is that IronPython 
should be able to copy as much of the stdlib as possible without having to 
change it.

That said, I'm not going to object if people decide this is in some sense a 
step too far in that direction.  So I'm +0.5, Brain is +1, and Victor is -1.  
Any other votes?  (Obviously IronPython hasn't wanted it enough to push it, so 
that could be considered as weighing on the negative side.)

--
resolution: fixed - 
status: closed - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Mark Lawrence]

Mark Lawrence added the comment:

The important line from the link in msg122717 is :-

mswindows = (sys.platform == win32 or (sys.platform == cli and os.name == 
'nt'))

so +1 from me unless someone can show one or more problems with it.

--
nosy: +BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[STINNER Victor]

STINNER Victor added the comment:

Oh oh, new try in english:

I vote -0, I don't really care :-) It's just that the issue is old and didn't 
get much attention.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[STINNER Victor]

STINNER Victor added the comment:

I'm -0, I don't really care :-) I just that the issue is old and
didn't get much attention.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Brian Curtin]

Brian Curtin cur...@acm.org added the comment:

Jeff Hardy just made this change for IronPython 2.7: 
http://bitbucket.org/ironpython/ironlanguages/changeset/b6bb2a9a7bc5

Any opposition to us matching that so they don't need to patch 
Lib/subprocess.py?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Florent Xicluna]

Changes by Florent Xicluna florent.xicl...@gmail.com:


--
nosy:  -flox

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Antoine Pitrou]

Antoine Pitrou pit...@free.fr added the comment:

Florent's patch makes sense to me.

--
nosy: +pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Michael Foord]

Changes by Michael Foord mich...@voidspace.org.uk:


--
nosy:  -michael.foord

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc amaur...@gmail.com added the comment:

What does the patch achieve?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Brian Curtin]

Changes by Brian Curtin cur...@acm.org:


--
components: +Windows
priority:  - normal
stage:  - test needed
versions:  -Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[R. David Murray]

R. David Murray rdmur...@bitdance.com added the comment:

Probably it should use platform.system() == 'Windows' instead.

--
keywords: +easy
nosy: +dino.viehland, michael.foord, r.david.murray

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc amaur...@gmail.com added the comment:

but, does it work even with your fix?
it seems to me that from _subprocess import * will fail miserably.

--
nosy: +amaury.forgeotdarc

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Brian Curtin]

Brian Curtin cur...@acm.org added the comment:

Also, using platform.system() == 'Windows' would exclude IronPython running on 
Mono.

--
nosy: +brian.curtin

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Dave Fugate]

Dave Fugate dfug...@microsoft.com added the comment:

platform.system()==Windows won't work unless you change platform as well:
IronPython 2.6.1 DEBUG (2.6.10920.0) on .NET 2.0.50727.4927
Type help, copyright, credits or license for more information.
 import platform
 platform.system()
'cli'

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc amaur...@gmail.com added the comment:

it's not about platform detection; does IronPython have the equivalent of 
msvcrt.open_osfhandle()?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Florent Xicluna]

Florent Xicluna florent.xicl...@gmail.com added the comment:

Proposed patch, with duck subprocessing. :D

--
keywords: +patch
Added file: http://bugs.python.org/file16518/issue8110_subprocess_mswindows.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8110] subprocess.py doesn't correctly detect Windows machines

[Brian Curtin]

Brian Curtin cur...@acm.org added the comment:

Amaury is right. On Windows, _subprocess is a built-in, so the platform stuff 
just currently enables further failure.

Dave: My C# skills aren't the greatest, but looking at PC/_subprocess.c there 
are a few Win32 functions you might need to P/Invoke, but I believe a lot of 
the functionality is supported in .NET.

--
keywords:  -easy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8110
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com