[Python-modules-team] Bug#822197: Memory addresses still seem to appear in sphinx docs...

2017-05-24 Thread Dmitry Shachnev 
On Tue, May 23, 2017 at 11:33:26PM -0400, Justin Cappos wrote:
> So I had a look and think there may be an easier way to handle this.  What
> if the ' at ' was removed from the memory regex in
> https://github.com/sphinx-doc/sphinx/blob/1.5.5/sphinx/util/inspect.py#L23

That would introduce many false positives.

What if one has a legit hex constant in the code, i.e. 0x12345678?

Also, please move this discussion upstream — I will not add any patches
unless they are accepted upstream.

--
Dmitry Shachnev


signature.asc
Description: PGP signature
___
Python-modules-team mailing list
Python-modules-team@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team

[Python-modules-team] Bug#822197: Memory addresses still seem to appear in sphinx docs...

2017-05-23 Thread Justin Cappos 
So I had a look and think there may be an easier way to handle this.  What
if the ' at ' was removed from the memory regex in
https://github.com/sphinx-doc/sphinx/blob/1.5.5/sphinx/util/inspect.py#L23

On Tue, May 23, 2017 at 11:54 AM, Justin Cappos  wrote:

> Okay, I will try to get this fixed further upstream in celery.
>
> Justin
>
> On Tue, May 23, 2017 at 9:05 AM, Dmitry Shachnev 
> wrote:
>
>> Hi Justin,
>>
>> On Sun, May 07, 2017 at 11:39:50AM -0400, Justin Cappos wrote:
>> > Okay, I have opened a new bug about this in sphinx:
>> > https://github.com/sphinx-doc/sphinx/issues/3722
>>
>> According to upstream response, this is because Celery is using a
>> non-standard
>> format for memory addresses, and the regex in Sphinx does not catch it.
>>
>> We will not add hacks for every specific project in Sphinx, so I don’t
>> think
>> I can do anything about this.
>>
>> --
>> Dmitry Shachnev
>>
>
>
___
Python-modules-team mailing list
Python-modules-team@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team

[Python-modules-team] Bug#822197: Memory addresses still seem to appear in sphinx docs...

2017-05-23 Thread Justin Cappos 
Okay, I will try to get this fixed further upstream in celery.

Justin

On Tue, May 23, 2017 at 9:05 AM, Dmitry Shachnev  wrote:

> Hi Justin,
>
> On Sun, May 07, 2017 at 11:39:50AM -0400, Justin Cappos wrote:
> > Okay, I have opened a new bug about this in sphinx:
> > https://github.com/sphinx-doc/sphinx/issues/3722
>
> According to upstream response, this is because Celery is using a
> non-standard
> format for memory addresses, and the regex in Sphinx does not catch it.
>
> We will not add hacks for every specific project in Sphinx, so I don’t
> think
> I can do anything about this.
>
> --
> Dmitry Shachnev
>
___
Python-modules-team mailing list
Python-modules-team@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team

[Python-modules-team] Bug#822197: Memory addresses still seem to appear in sphinx docs...

2017-05-23 Thread Dmitry Shachnev 
Hi Justin,

On Sun, May 07, 2017 at 11:39:50AM -0400, Justin Cappos wrote:
> Okay, I have opened a new bug about this in sphinx:
> https://github.com/sphinx-doc/sphinx/issues/3722

According to upstream response, this is because Celery is using a non-standard
format for memory addresses, and the regex in Sphinx does not catch it.

We will not add hacks for every specific project in Sphinx, so I don’t think
I can do anything about this.

--
Dmitry Shachnev


signature.asc
Description: PGP signature
___
Python-modules-team mailing list
Python-modules-team@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team

[Python-modules-team] Bug#822197: Memory addresses still seem to appear in sphinx docs...

2017-05-07 Thread Justin Cappos 
Okay, I have opened a new bug about this in sphinx:
https://github.com/sphinx-doc/sphinx/issues/3722

Thanks,
Justin

On Sun, May 7, 2017 at 6:38 AM, Dmitry Shachnev  wrote:

> Hi Justin,
>
> On Fri, May 05, 2017 at 06:01:22AM -0400, Justin Cappos wrote:
> > I am taking a look at some of the reproducible-builds packages that are
> > still failing and still see some issues that look like they may be from
> > memory addresses being output by sphinx.
> >
> > For example, django-celery outputs the following memory address
> > [...]
> >
> > I checked the github issue tracker and this doesn't seem to be listed
> > there, but it is possible that this issue is related:
> > https://github.com/sphinx-doc/sphinx/issues/1721.
>
> Can you please file a new bug for upstream Sphinx, or ping the existing
> issue you mentioned?
>
> I am afraid I don’t have time to look at this myself, so help from upstream
> would be nice.
>
> --
> Dmitry Shachnev
>
___
Python-modules-team mailing list
Python-modules-team@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team

[Python-modules-team] Bug#822197: Memory addresses still seem to appear in sphinx docs...

2017-05-07 Thread Dmitry Shachnev 
Hi Justin,

On Fri, May 05, 2017 at 06:01:22AM -0400, Justin Cappos wrote:
> I am taking a look at some of the reproducible-builds packages that are
> still failing and still see some issues that look like they may be from
> memory addresses being output by sphinx.
>
> For example, django-celery outputs the following memory address
> [...]
>
> I checked the github issue tracker and this doesn't seem to be listed
> there, but it is possible that this issue is related:
> https://github.com/sphinx-doc/sphinx/issues/1721.

Can you please file a new bug for upstream Sphinx, or ping the existing
issue you mentioned?

I am afraid I don’t have time to look at this myself, so help from upstream
would be nice.

--
Dmitry Shachnev

___
Python-modules-team mailing list
Python-modules-team@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team