[Python-modules-team] Bug#872270: celery: FTBFS with Sphinx 1.6: AttributeError: 'Sphinx' object has no attribute 'domains'

2017-08-15 Thread Dmitry Shachnev
On Tue, Aug 15, 2017 at 05:46:29PM +0300, Dmitry Shachnev wrote:
> celery fails to build with Sphinx 1.6, currently available in experimental:
>
> [...]
>
> This commit from upstream Celery should fix this:
> https://github.com/celery/celery/commit/3c98e6216167d7e5

Sorry, that commit is not enough, because after applying it the build fails
with a new error:

  Traceback (most recent call last):
[...]
File "/usr/lib/python2.7/dist-packages/sphinx/domains/std.py", line 592, in 
note_citation_refs
  if node['refdomain'] == 'std' and node['reftype'] == 'citation':
File "/usr/lib/python2.7/dist-packages/docutils/nodes.py", line 567, in 
__getitem__
  return self.attributes[key]
  KeyError: 'refdomain'

So you also need to apply this patch to docs/_ext/githubsphinx.py file:
https://github.com/celery/sphinx_celery/commit/28d8f42b43d5a28a

After applying both patches the build succeeds.

--
Dmitry Shachnev


signature.asc
Description: PGP signature
___
Python-modules-team mailing list
Python-modules-team@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team

[Python-modules-team] Bug#872270: celery: FTBFS with Sphinx 1.6: AttributeError: 'Sphinx' object has no attribute 'domains'

2017-08-15 Thread Dmitry Shachnev
Source: celery
Version: 3.1.23-7
Severity: important
Tags: fixed-upstream
User: python-modules-team@lists.alioth.debian.org
Usertags: sphinx1.6

Dear maintainer,

celery fails to build with Sphinx 1.6, currently available in experimental:

  Running Sphinx v1.6.3
  making output directory...
  Generating grammar tables from /usr/share/sphinx/pycode/Grammar-py2.txt
  WARNING: sphinx.ext.pngmath has been deprecated. Please use 
sphinx.ext.imgmath instead.

  Exception occurred:
File "/tmp/celery-3.1.23/docs/../celery/contrib/sphinx.py", line 75, in 
setup
  app.domains['py'].directives['task'] = TaskDirective
  AttributeError: 'Sphinx' object has no attribute 'domains'
  The full traceback has been saved in /tmp/sphinx-err-KsCJml.log, if you want 
to report the issue to the developers.

And the full traceback from the mentioned file is:

  Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/sphinx/cmdline.py", line 305, in main
  opts.warningiserror, opts.tags, opts.verbosity, opts.jobs)
File "/usr/lib/python2.7/dist-packages/sphinx/application.py", line 196, in 
__init__
  self.setup_extension(extension)
File "/usr/lib/python2.7/dist-packages/sphinx/application.py", line 456, in 
setup_extension
  self.registry.load_extension(self, extname)
File "/usr/lib/python2.7/dist-packages/sphinx/registry.py", line 207, in 
load_extension
  metadata = mod.setup(app)
File "/tmp/celery-3.1.23/docs/../celery/contrib/sphinx.py", line 75, in 
setup
  app.domains['py'].directives['task'] = TaskDirective
  AttributeError: 'Sphinx' object has no attribute 'domains'

This looks like a result of this Sphinx commit:
https://github.com/sphinx-doc/sphinx/commit/8ca9bdfbd41cc547

This commit from upstream Celery should fix this:
https://github.com/celery/celery/commit/3c98e6216167d7e5

--
Dmitry Shachnev


signature.asc
Description: PGP signature
___
Python-modules-team mailing list
Python-modules-team@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/python-modules-team