[pywikibot] Re: pywikibot is making a mockery of my tests
OK, thank you, that's a correct answer, and means that the question was valid. :-) ___ pywikibot mailing list -- pywikibot@lists.wikimedia.org To unsubscribe send an email to pywikibot-le...@lists.wikimedia.org
[pywikibot] Re: pywikibot is making a mockery of my tests
I did not tell anything like this. The question mark indacates that it was a question. You personally were mislead by this capitalization, and I am thankful that you discovered this for us, and others don't have to suffer. I just want to understand things. Russell Blau ezt írta (időpont: 2022. nov. 29., K, 17:37): > Oh yes. Please, please break every single script written by every user, > just so we can have perfect capitalization style. > > -- > *From:* Bináris > *Sent:* Tuesday, November 29, 2022 11:32 AM > *To:* Pywikibot discussion list > *Subject:* [pywikibot] Re: pywikibot is making a mockery of my tests > > > > Roy Smith ezt írta (időpont: 2022. nov. 29., K, 17:26): > >> Ah, I've got this. The problem is that pywikibot.Site isn't a class, >> it's a factory function that returns cached instances of APISite. >> > > Should it not have a lower case name in this case? > ___ > pywikibot mailing list -- pywikibot@lists.wikimedia.org > To unsubscribe send an email to pywikibot-le...@lists.wikimedia.org > -- Bináris ___ pywikibot mailing list -- pywikibot@lists.wikimedia.org To unsubscribe send an email to pywikibot-le...@lists.wikimedia.org
[pywikibot] Re: pywikibot is making a mockery of my tests
Oh yes. Please, please break every single script written by every user, just so we can have perfect capitalization style. From: Bináris Sent: Tuesday, November 29, 2022 11:32 AMTo: Pywikibot discussion list Subject: [pywikibot] Re: pywikibot is making a mockery of my tests Roy Smith <r...@panix.com> ezt írta (időpont: 2022. nov. 29., K, 17:26):Ah, I've got this. The problem is that pywikibot.Site isn't a class, it's a factory function that returns cached instances of APISite. Should it not have a lower case name in this case? ___ pywikibot mailing list -- pywikibot@lists.wikimedia.org To unsubscribe send an email to pywikibot-le...@lists.wikimedia.org
[pywikibot] Re: pywikibot is making a mockery of my tests
Roy Smith ezt írta (időpont: 2022. nov. 29., K, 17:26): > Ah, I've got this. The problem is that pywikibot.Site isn't a class, it's > a factory function that returns cached instances of APISite. > Should it not have a lower case name in this case? ___ pywikibot mailing list -- pywikibot@lists.wikimedia.org To unsubscribe send an email to pywikibot-le...@lists.wikimedia.org
[pywikibot] Re: pywikibot is making a mockery of my tests
Ah, I've got this. The problem is that pywikibot.Site isn't a class, it's a
factory function that returns cached instances of APISite. It looks like if
you want to mock Site, you need to do:
mock_Site = mocker.patch('pywikibot.site.APISite', autospec=True)
or this works too (and is probably cleaner):
mock_Site = mocker.patch('pywikibot.Site',
autospec=pywikibot.site.APISite)
I still don't fully understand why my original test passes; mock_Site should
have the same attributes as the mocked function, which does not include
"xxyyzz", so it should fail. But I'll just chalk that up to "Every time I
finally think I understand how unittest.mock works, I discover something new".
> On Nov 29, 2022, at 10:49 AM, Roy Smith wrote:
>
> That's a good observation, thanks, but fixing that doesn't change anything.
> This:
>
> def test_ip(mocker):
> mock_IPv4Address = mocker.patch('ipaddress.IPv4Address', autospec=True)
> ip = mock_IPv4Address('1.2.3.4')
> assert ip.xxyyzz
>
> fails in exactly the same way.
>
>> On Nov 28, 2022, at 11:01 PM, Dalba > > wrote:
>>
>> That does not look like a fair comparison. In `test_ip` you are tryign to
>> get the xxyyzz attribute of the mock object itself, but in `test_site`
>> you're accessing the attribute on the instance of the mock.
>> I think one of the assertions needs to be changed. Either change ` assert
>> site.xxyyzz ` to ` assert mock_Site.xxyyzz ` or ` assert
>> mock_IPv4Address.xxyyzz ` to ` assert ip.xxyyzz `.
>>
>> On Tue, Nov 29, 2022 at 5:19 AM Roy Smith > > wrote:
>> I've got:
>>
>> platform darwin -- Python 3.9.13, pytest-7.2.0, pluggy-1.0.0
>> rootdir: /Users/roy/dev/dyk-tools, configfile: src/pages/pytest.ini
>> plugins: mock-3.10.0, socket-0.5.1
>>
>>
>> When I run the following:
>>
>> def test_ip(mocker):
>> mock_IPv4Address = mocker.patch('ipaddress.IPv4Address', autospec=True)
>> ip = mock_IPv4Address('1.2.3.4')
>> assert mock_IPv4Address.xxyyzz
>>
>>
>> def test_site(mocker):
>> mock_Site = mocker.patch('pywikibot.Site', autospec=True)
>> site = mock_Site('en', 'wikipedia')
>> assert site.xxyyzz
>>
>>
>> test_ip() fails, as I expect it to, with AttributeError: Mock object has no
>> attribute 'xxyyzz'. But, test_site() passes. WTF? Why does it not also
>> fail with the same error?
>>
>> ___
>> pywikibot mailing list -- pywikibot@lists.wikimedia.org
>>
>> To unsubscribe send an email to pywikibot-le...@lists.wikimedia.org
>>
>> ___
>> pywikibot mailing list -- pywikibot@lists.wikimedia.org
>>
>> To unsubscribe send an email to pywikibot-le...@lists.wikimedia.org
>>
>
> ___
> pywikibot mailing list -- pywikibot@lists.wikimedia.org
> To unsubscribe send an email to pywikibot-le...@lists.wikimedia.org
___
pywikibot mailing list -- pywikibot@lists.wikimedia.org
To unsubscribe send an email to pywikibot-le...@lists.wikimedia.org
[pywikibot] Re: pywikibot is making a mockery of my tests
That's a good observation, thanks, but fixing that doesn't change anything.
This:
def test_ip(mocker):
mock_IPv4Address = mocker.patch('ipaddress.IPv4Address', autospec=True)
ip = mock_IPv4Address('1.2.3.4')
assert ip.xxyyzz
fails in exactly the same way.
> On Nov 28, 2022, at 11:01 PM, Dalba wrote:
>
> That does not look like a fair comparison. In `test_ip` you are tryign to get
> the xxyyzz attribute of the mock object itself, but in `test_site` you're
> accessing the attribute on the instance of the mock.
> I think one of the assertions needs to be changed. Either change ` assert
> site.xxyyzz ` to ` assert mock_Site.xxyyzz ` or ` assert
> mock_IPv4Address.xxyyzz ` to ` assert ip.xxyyzz `.
>
> On Tue, Nov 29, 2022 at 5:19 AM Roy Smith > wrote:
> I've got:
>
> platform darwin -- Python 3.9.13, pytest-7.2.0, pluggy-1.0.0
> rootdir: /Users/roy/dev/dyk-tools, configfile: src/pages/pytest.ini
> plugins: mock-3.10.0, socket-0.5.1
>
>
> When I run the following:
>
> def test_ip(mocker):
> mock_IPv4Address = mocker.patch('ipaddress.IPv4Address', autospec=True)
> ip = mock_IPv4Address('1.2.3.4')
> assert mock_IPv4Address.xxyyzz
>
>
> def test_site(mocker):
> mock_Site = mocker.patch('pywikibot.Site', autospec=True)
> site = mock_Site('en', 'wikipedia')
> assert site.xxyyzz
>
>
> test_ip() fails, as I expect it to, with AttributeError: Mock object has no
> attribute 'xxyyzz'. But, test_site() passes. WTF? Why does it not also
> fail with the same error?
>
> ___
> pywikibot mailing list -- pywikibot@lists.wikimedia.org
>
> To unsubscribe send an email to pywikibot-le...@lists.wikimedia.org
>
> ___
> pywikibot mailing list -- pywikibot@lists.wikimedia.org
> To unsubscribe send an email to pywikibot-le...@lists.wikimedia.org
___
pywikibot mailing list -- pywikibot@lists.wikimedia.org
To unsubscribe send an email to pywikibot-le...@lists.wikimedia.org
[pywikibot] Re: pywikibot is making a mockery of my tests
Just an idea but I haven’t verified: BaseSite has a __getattr__ method defined
which delegates methods to its Family class. Maybe mock.patch has a side effect
which leads to that behaviour you described due to this method. To verify you
could comment out this method and test again.
Best
xqt
> Am 29.11.2022 um 02:49 schrieb Roy Smith :
>
>
> I've got:
>
> platform darwin -- Python 3.9.13, pytest-7.2.0, pluggy-1.0.0
> rootdir: /Users/roy/dev/dyk-tools, configfile: src/pages/pytest.ini
> plugins: mock-3.10.0, socket-0.5.1
>
>
> When I run the following:
>
> def test_ip(mocker):
> mock_IPv4Address = mocker.patch('ipaddress.IPv4Address', autospec=True)
> ip = mock_IPv4Address('1.2.3.4')
> assert mock_IPv4Address.xxyyzz
>
>
> def test_site(mocker):
> mock_Site = mocker.patch('pywikibot.Site', autospec=True)
> site = mock_Site('en', 'wikipedia')
> assert site.xxyyzz
>
>
> test_ip() fails, as I expect it to, with AttributeError: Mock object has no
> attribute 'xxyyzz'. But, test_site() passes. WTF? Why does it not also
> fail with the same error?
>
> ___
> pywikibot mailing list -- pywikibot@lists.wikimedia.org
> To unsubscribe send an email to pywikibot-le...@lists.wikimedia.org
___
pywikibot mailing list -- pywikibot@lists.wikimedia.org
To unsubscribe send an email to pywikibot-le...@lists.wikimedia.org
