Re: Please review the draft for week 149's blog post
Chris Lamb wrote: > Please review the draft for week 149's blog post: This has now been published. :) Thanks to all who contributed as usual. Please promote the following URLs as appropriate: https://reproducible.alioth.debian.org/blog/posts/149/ https://twitter.com/ReproBuilds/status/971225242558451712 Best wishes, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
Bug#892240: diffoscope: crashes comparing directories with python3-xattr installed
Package: diffoscope Version: 91 Severity: wishlist Usertags: crash diffoscope crashes when comparing directories when the python3-xattr package is installed but the python3-pyxattr package is not installed. I would suggest that diffoscope should either conflict with the incompatible python3-xattr package (as python3-pyxattr does), or add support for the API provided by the python3-xattr package. Personally I would prefer the latter, since python3-xattr has a useful command-line tool in the xattr package that I sometimes use. $ mkdir foo bar $ diffoscope foo bar Traceback (most recent call last): File "/usr/lib/python3/dist-packages/diffoscope/main.py", line 422, in main sys.exit(run_diffoscope(parsed_args)) File "/usr/lib/python3/dist-packages/diffoscope/main.py", line 394, in run_diffoscope difference = compare_root_paths(path1, path2) File "/usr/lib/python3/dist-packages/diffoscope/comparators/utils/compare.py", line 62, in compare_root_paths return compare_directories(path1, path2) File "/usr/lib/python3/dist-packages/diffoscope/comparators/directory.py", line 165, in compare_directories return FilesystemDirectory(path1).compare(FilesystemDirectory(path2)) File "/usr/lib/python3/dist-packages/diffoscope/comparators/directory.py", line 216, in compare differences.extend(compare_meta(self.name, other.name)) File "/usr/lib/python3/dist-packages/diffoscope/comparators/directory.py", line 161, in compare_meta differences.append(xattr(path1, path2)) File "/usr/lib/python3/dist-packages/diffoscope/comparators/directory.py", line 124, in xattr fn(path1), fn(path2), path1, path2, source='extended file attributes', File "/usr/lib/python3/dist-packages/diffoscope/comparators/directory.py", line 121, in fn ) for k, v in sorted(xattr.get_all(x))) AttributeError: module 'xattr' has no attribute 'get_all' -- System Information: Debian Release: buster/sid APT prefers testing-debug APT policy: (900, 'testing-debug'), (900, 'testing'), (800, 'unstable-debug'), (800, 'unstable'), (790, 'buildd-unstable'), (700, 'experimental-debug'), (700, 'experimental'), (690, 'buildd-experimental') Architecture: amd64 (x86_64) Kernel: Linux 4.14.0-3-amd64 (SMP w/4 CPU cores) Locale: LANG=en_AU.utf8, LC_CTYPE=en_AU.utf8 (charmap=UTF-8), LANGUAGE=en_AU.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages diffoscope depends on: ii python33.6.4-1 ii python3-distro 1.0.1-2 ii python3-libarchive-c 2.1-3.1 ii python3-magic 2:0.4.15-1 ii python3-pkg-resources 38.4.0-1 Versions of packages diffoscope recommends: ii abootimg 0.6-1+b2 ii acl 2.2.52-3+b1 ii apktool 2.3.1+dfsg-1 ii binutils-multiarch 2.30-5 ii bzip21.0.6-8.1 ii caca-utils 0.99.beta19-2+b2 ii colord 1.3.3-2 ii db-util 5.3.1 ii default-jdk [java-sdk] 2:1.8-59 ii default-jdk-headless 2:1.8-59 pn device-tree-compiler pn docx2txt ii e2fsprogs1.43.9-2 ii enjarify 1:1.0.3-3 ii fontforge-extras 0.3-4 pn fp-utils ii genisoimage 9:1.1.11-3+b2 ii gettext 0.19.8.1-4 ii ghc 8.0.2-11 ii ghostscript 9.22~dfsg-2 ii giflib-tools 5.1.4-2 ii gnupg2.2.5-1 ii imagemagick 8:6.9.9.34+dfsg-3 ii imagemagick-6.q16 [imagemagick] 8:6.9.9.34+dfsg-3 ii jsbeautifier 1.6.4-6 pn libarchive-tools ii llvm 1:4.0-40 pn mono-utils pn odt2txt pn oggvideotools ii openjdk-8-jdk [java-sdk] 8u151-b12-1 ii openssh-client 1:7.6p1-4 ii pdftk2.02-4+b2 ii pgpdump 0.31-0.2 ii poppler-utils0.61.1-2 pn procyon-decompiler ii python3-argcomplete 1.8.1-1 ii python3-binwalk 2.1.1-16 ii python3-debian 0.1.32 pn python3-defusedxml pn python3-guestfs ii python3-jsondiff 1.1.1-1 ii python3-progressbar 2.3-4 ii python3-rpm 4.14.0+dfsg1-2 ii python3-tlsh 3.4.4+20151206-1+b3 ii python3-xattr [python3-pyxattr] 0.9.3-1 pn r-base-core ii rpm2cpio 4.14.0+dfsg1-2 ii sng 1.1.0-1+b1 ii sqlite3 3.22.0-1 ii squashfs-tools
diffoscope_91~bpo9+1_source.changes ACCEPTED into stretch-backports
Accepted: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Format: 1.8 Date: Tue, 06 Mar 2018 11:34:17 +0100 Source: diffoscope Binary: diffoscope Architecture: source Version: 91~bpo9+1 Distribution: stretch-backports Urgency: medium Maintainer: Reproducible builds folksChanged-By: Mattia Rizzolo Description: diffoscope - in-depth comparison of files, archives, and directories Closes: 849386 863879 863880 877726 886736 886963 887180 888112 888401 888402 890528 Changes: diffoscope (91~bpo9+1) stretch-backports; urgency=medium . * Rebuild for stretch-backports. . diffoscope (91) unstable; urgency=medium . [ Mattia Rizzolo ] * d/clean: Remove .cache/. * diff: Wrap long regular expression for improved readability. * comparators.json: Fix UnicodeDecodeError with a non-UTF8 locale. * d/copyright: Update for the new year. * d/control: Bump Standards-Version to 4.1.3, no changes needed. * tests/android: + Skip tests involving abootimg on BE archs (see #725729). . [ Daniel Shahaf ] * diffoscope.diff: Document feeders. Closes: #863880 * Optimize the common case of feeders. Closes: #863879 . [ Juliana Oliveira ] * {tempfiles, utils.archive}: catch possible FileNotFoundError. * comparators.java: add support for procyon-decompiler. Closes: #849386 * {command, feeders, diff}: replaces subprocess.Popen() by .run(). This is done in preparation for work on multiprocessing (#842837). + {command, zip, feeders}: replaces .wait by the new .returncode property. + comparators.utils.command: replaces .stderr_content by .stderr. * tests: + test_progress: fix test case for some broken versions of python-progressbar. Closes: #877726 + utils.tools: add support for modules on skip_unless* annotations. . [ Chris Lamb ] * comparators: + utils/compare: - Show extended filesystem metadata even when directly comparing two files, not just when we specify two directories. Closes: #888402 + macho: - If the If the LLVM disassembler does not work, try the internal one. Closes: #886736 - Always strip the filename, not just when by itself. + json: - Do some cheap fuzzy parsing to detect JSON files not named .json. - Also match unicode JSON files. - Optionally compare JSONs with the jsondiff module. Closes: #888112 + directory: - Report differences in extended file attributes when comparing files. Closes: #888401 + xsb: - Add support for comparing XMLBeans binary schemas. + barkeley_db: - Add support for comparing Berkeley DB files. Closes: #890528 * Misc code cleaup. * tests: + comparators.test_elf: Return '0' if we can't parse the readelf version number. Closes: #886963 * debian: + Explicitly build-depend and recommend e2fsprogs. Closes: #887180 . [ Ximin Luo ] * Partially revert the changes done for #888402 to maintain the current. behaviour of --exclude-directory-metadata. * Refactor how the configuration is loaded: + Move the defaults into a Config.reset() method. + reset() the configuration at the end of main(), to help the testsuite. Checksums-Sha1: 21b3eb84069b916e4ab6f077bbc0706a8a0e8288 3460 diffoscope_91~bpo9+1.dsc 0b646d4f9f4e8422e539e97d7c8ef2d06557c7be 18064336 diffoscope_91~bpo9+1.tar.xz c9fb0a4042bdec8d4c8784038a8e1f6552819864 19974 diffoscope_91~bpo9+1_amd64.buildinfo Checksums-Sha256: 450c19737784505cb603db26f3a6bd69d478daf6d92bea58bd95c1ac23fbc285 3460 diffoscope_91~bpo9+1.dsc a8b595363d455113e376c6efbdcc0832ced7da8d92b34169c245ea3fea210411 18064336 diffoscope_91~bpo9+1.tar.xz 755ff9d76f2e2f806e7ad0e1dfff46ba336ae8e20da72736c07cfb9821415d66 19974 diffoscope_91~bpo9+1_amd64.buildinfo Files: 477b482634ba8ac244ecb16a98e9d72d 3460 devel optional diffoscope_91~bpo9+1.dsc 369ee73d343224b8a1e9c299f0c4f260 18064336 devel optional diffoscope_91~bpo9+1.tar.xz 1e53b1ba8d5e19ed99f78598795bd225 19974 devel optional diffoscope_91~bpo9+1_amd64.buildinfo -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEEi3hoeGwz5cZMTQpICBa54Yx2K60FAlqecLwACgkQCBa54Yx2 K604ZxAAvOr20BRHPmMSfQFt5K+Jtvk947vsI+l32yqczvuynkUVbHOCg4amrqzE SArj4nNuVhh+G0yV4eXac4XkZtsYMwkwnAX+bBT/sZxxe48rqc+vwJFa7j1+ffwd NbE8eJuCHhGnZ6mNFt2ganVkVW8m33pDNXC7Djk5t8rDOlFyJJ7bmjepOcog5HQw FV6jdzIQolQkmkFpIpSK6a8S6jDEgKsHz/R9R2w8jgZdBGvHlUd6eTbZIq8gPapF xG9Iomc87RfGH7xYRV8qcMD1qw8/1Ti0LVIUcfO46CbPq/n1vCqnxHUZr7/zmHuP yZ/oyYsc66Gz9Wi7A4lexXWP48jpP7KQpL+f+Ywmn8HiGOZy4/IaYifeu55/54yq ySvyAEZfDBS5/Krw4nzAEKVaXSF16nBjUP/vkp2c5rTRMbeWVxdVCTyTKXxnzlKm O4+LbgIdrW/qANf6J+LDYtXsrhGzFkQZxcNzfqrORqZsxyRHF0eY9padSwmsETJ7 zy4e/lRvBU4arReOr7+OQI9bbDrN581/rPucugph9Au8INmbSDNDYLTPpSmnf/la qBjgKt1xWzdDW4oqWCndhDsL383R/hZWp8a/FcSUXvbWjh2sXnWs8bVE4a96uzVa uvA0j3We5KeA5T8A3WkLBiehyU82uYrIVkdBim5YgJzE0NmB+yg= =TTRb -END PGP SIGNATURE- Thank
Accepted diffoscope 91~bpo9+1 (source) into stretch-backports
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Format: 1.8 Date: Tue, 06 Mar 2018 11:34:17 +0100 Source: diffoscope Binary: diffoscope Architecture: source Version: 91~bpo9+1 Distribution: stretch-backports Urgency: medium Maintainer: Reproducible builds folksChanged-By: Mattia Rizzolo Description: diffoscope - in-depth comparison of files, archives, and directories Closes: 849386 863879 863880 877726 886736 886963 887180 888112 888401 888402 890528 Changes: diffoscope (91~bpo9+1) stretch-backports; urgency=medium . * Rebuild for stretch-backports. . diffoscope (91) unstable; urgency=medium . [ Mattia Rizzolo ] * d/clean: Remove .cache/. * diff: Wrap long regular expression for improved readability. * comparators.json: Fix UnicodeDecodeError with a non-UTF8 locale. * d/copyright: Update for the new year. * d/control: Bump Standards-Version to 4.1.3, no changes needed. * tests/android: + Skip tests involving abootimg on BE archs (see #725729). . [ Daniel Shahaf ] * diffoscope.diff: Document feeders. Closes: #863880 * Optimize the common case of feeders. Closes: #863879 . [ Juliana Oliveira ] * {tempfiles, utils.archive}: catch possible FileNotFoundError. * comparators.java: add support for procyon-decompiler. Closes: #849386 * {command, feeders, diff}: replaces subprocess.Popen() by .run(). This is done in preparation for work on multiprocessing (#842837). + {command, zip, feeders}: replaces .wait by the new .returncode property. + comparators.utils.command: replaces .stderr_content by .stderr. * tests: + test_progress: fix test case for some broken versions of python-progressbar. Closes: #877726 + utils.tools: add support for modules on skip_unless* annotations. . [ Chris Lamb ] * comparators: + utils/compare: - Show extended filesystem metadata even when directly comparing two files, not just when we specify two directories. Closes: #888402 + macho: - If the If the LLVM disassembler does not work, try the internal one. Closes: #886736 - Always strip the filename, not just when by itself. + json: - Do some cheap fuzzy parsing to detect JSON files not named .json. - Also match unicode JSON files. - Optionally compare JSONs with the jsondiff module. Closes: #888112 + directory: - Report differences in extended file attributes when comparing files. Closes: #888401 + xsb: - Add support for comparing XMLBeans binary schemas. + barkeley_db: - Add support for comparing Berkeley DB files. Closes: #890528 * Misc code cleaup. * tests: + comparators.test_elf: Return '0' if we can't parse the readelf version number. Closes: #886963 * debian: + Explicitly build-depend and recommend e2fsprogs. Closes: #887180 . [ Ximin Luo ] * Partially revert the changes done for #888402 to maintain the current. behaviour of --exclude-directory-metadata. * Refactor how the configuration is loaded: + Move the defaults into a Config.reset() method. + reset() the configuration at the end of main(), to help the testsuite. Checksums-Sha1: 21b3eb84069b916e4ab6f077bbc0706a8a0e8288 3460 diffoscope_91~bpo9+1.dsc 0b646d4f9f4e8422e539e97d7c8ef2d06557c7be 18064336 diffoscope_91~bpo9+1.tar.xz c9fb0a4042bdec8d4c8784038a8e1f6552819864 19974 diffoscope_91~bpo9+1_amd64.buildinfo Checksums-Sha256: 450c19737784505cb603db26f3a6bd69d478daf6d92bea58bd95c1ac23fbc285 3460 diffoscope_91~bpo9+1.dsc a8b595363d455113e376c6efbdcc0832ced7da8d92b34169c245ea3fea210411 18064336 diffoscope_91~bpo9+1.tar.xz 755ff9d76f2e2f806e7ad0e1dfff46ba336ae8e20da72736c07cfb9821415d66 19974 diffoscope_91~bpo9+1_amd64.buildinfo Files: 477b482634ba8ac244ecb16a98e9d72d 3460 devel optional diffoscope_91~bpo9+1.dsc 369ee73d343224b8a1e9c299f0c4f260 18064336 devel optional diffoscope_91~bpo9+1.tar.xz 1e53b1ba8d5e19ed99f78598795bd225 19974 devel optional diffoscope_91~bpo9+1_amd64.buildinfo -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEEi3hoeGwz5cZMTQpICBa54Yx2K60FAlqecLwACgkQCBa54Yx2 K604ZxAAvOr20BRHPmMSfQFt5K+Jtvk947vsI+l32yqczvuynkUVbHOCg4amrqzE SArj4nNuVhh+G0yV4eXac4XkZtsYMwkwnAX+bBT/sZxxe48rqc+vwJFa7j1+ffwd NbE8eJuCHhGnZ6mNFt2ganVkVW8m33pDNXC7Djk5t8rDOlFyJJ7bmjepOcog5HQw FV6jdzIQolQkmkFpIpSK6a8S6jDEgKsHz/R9R2w8jgZdBGvHlUd6eTbZIq8gPapF xG9Iomc87RfGH7xYRV8qcMD1qw8/1Ti0LVIUcfO46CbPq/n1vCqnxHUZr7/zmHuP yZ/oyYsc66Gz9Wi7A4lexXWP48jpP7KQpL+f+Ywmn8HiGOZy4/IaYifeu55/54yq ySvyAEZfDBS5/Krw4nzAEKVaXSF16nBjUP/vkp2c5rTRMbeWVxdVCTyTKXxnzlKm O4+LbgIdrW/qANf6J+LDYtXsrhGzFkQZxcNzfqrORqZsxyRHF0eY9padSwmsETJ7 zy4e/lRvBU4arReOr7+OQI9bbDrN581/rPucugph9Au8INmbSDNDYLTPpSmnf/la qBjgKt1xWzdDW4oqWCndhDsL383R/hZWp8a/FcSUXvbWjh2sXnWs8bVE4a96uzVa uvA0j3We5KeA5T8A3WkLBiehyU82uYrIVkdBim5YgJzE0NmB+yg= =TTRb -END PGP SIGNATURE-
Processing of diffoscope_91~bpo9+1_source.changes
diffoscope_91~bpo9+1_source.changes uploaded successfully to localhost along with the files: diffoscope_91~bpo9+1.dsc diffoscope_91~bpo9+1.tar.xz diffoscope_91~bpo9+1_amd64.buildinfo Greetings, Your Debian queue daemon (running on host usper.debian.org) ___ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds