[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15801 ) Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct .. KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct This takes the Arena* member of RowBlock and moves it into a new RowBlockMemory structure. The RowBlockMemory structure will later be extended to include a list of reference-counted block handles. Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 Reviewed-on: http://gerrit.cloudera.org:8080/15801 Reviewed-by: Andrew Wong Tested-by: Kudu Jenkins --- M src/kudu/cfile/block_handle.h M src/kudu/cfile/cfile-test-base.h M src/kudu/cfile/cfile-test.cc M src/kudu/cfile/cfile_util.cc M src/kudu/cfile/encoding-test.cc M src/kudu/codegen/codegen-test.cc M src/kudu/common/column_predicate-test.cc A src/kudu/common/columnblock-test-util.h M src/kudu/common/columnblock-test.cc M src/kudu/common/columnblock.cc M src/kudu/common/columnblock.h M src/kudu/common/generic_iterators-test.cc M src/kudu/common/generic_iterators.cc M src/kudu/common/rowblock.cc M src/kudu/common/rowblock.h A src/kudu/common/rowblock_memory.h M src/kudu/common/wire_protocol-test.cc M src/kudu/integration-tests/linked_list-test-util.h M src/kudu/master/sys_catalog.cc M src/kudu/tablet/cfile_set-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_compaction.cc M src/kudu/tablet/deltafile-test.cc M src/kudu/tablet/diskrowset-test-base.h M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/mt-rowset_delta_compaction-test.cc M src/kudu/tablet/mt-tablet-test.cc M src/kudu/tablet/tablet-decoder-eval-test.cc M src/kudu/tablet/tablet-test-base.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet-test.cc M src/kudu/tablet/tablet_random_access-test.cc M src/kudu/tools/tool_action_local_replica.cc M src/kudu/tools/tool_action_perf.cc M src/kudu/transactions/txn_status_tablet.cc M src/kudu/tserver/tablet_server-test-base.cc M src/kudu/tserver/tablet_service.cc 38 files changed, 351 insertions(+), 257 deletions(-) Approvals: Andrew Wong: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/15801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 Gerrit-Change-Number: 15801 Gerrit-PatchSet: 7 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15801 ) Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 Gerrit-Change-Number: 15801 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Thu, 13 Aug 2020 23:15:25 + Gerrit-HasComments: No
[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15801 ) Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 Gerrit-Change-Number: 15801 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Thu, 13 Aug 2020 22:25:10 + Gerrit-HasComments: No
[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15801 to look at the new patch set (#5). Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct .. KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct This takes the Arena* member of RowBlock and moves it into a new RowBlockMemory structure. The RowBlockMemory structure will later be extended to include a list of reference-counted block handles. Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 --- M src/kudu/cfile/block_handle.h M src/kudu/cfile/cfile-test-base.h M src/kudu/cfile/cfile-test.cc M src/kudu/cfile/cfile_util.cc M src/kudu/cfile/encoding-test.cc M src/kudu/codegen/codegen-test.cc M src/kudu/common/column_predicate-test.cc A src/kudu/common/columnblock-test-util.h M src/kudu/common/columnblock-test.cc M src/kudu/common/columnblock.cc M src/kudu/common/columnblock.h M src/kudu/common/generic_iterators-test.cc M src/kudu/common/generic_iterators.cc M src/kudu/common/rowblock.cc M src/kudu/common/rowblock.h A src/kudu/common/rowblock_memory.h M src/kudu/common/wire_protocol-test.cc M src/kudu/integration-tests/linked_list-test-util.h M src/kudu/master/sys_catalog.cc M src/kudu/tablet/cfile_set-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_compaction.cc M src/kudu/tablet/deltafile-test.cc M src/kudu/tablet/diskrowset-test-base.h M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/mt-rowset_delta_compaction-test.cc M src/kudu/tablet/mt-tablet-test.cc M src/kudu/tablet/tablet-decoder-eval-test.cc M src/kudu/tablet/tablet-test-base.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet-test.cc M src/kudu/tablet/tablet_random_access-test.cc M src/kudu/tools/tool_action_local_replica.cc M src/kudu/tools/tool_action_perf.cc M src/kudu/transactions/txn_status_tablet.cc M src/kudu/tserver/tablet_server-test-base.cc M src/kudu/tserver/tablet_service.cc 38 files changed, 351 insertions(+), 257 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/15801/5 -- To view, visit http://gerrit.cloudera.org:8080/15801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 Gerrit-Change-Number: 15801 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15801 ) Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 Gerrit-Change-Number: 15801 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Thu, 13 Aug 2020 05:27:37 + Gerrit-HasComments: No
[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15801 ) Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct .. Patch Set 4: Verified+1 Test failure is likely unrelated: TabletHistoryGcITest.TestUndoDeltaBlockGc -- To view, visit http://gerrit.cloudera.org:8080/15801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 Gerrit-Change-Number: 15801 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Thu, 13 Aug 2020 05:13:32 + Gerrit-HasComments: No
[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct
Andrew Wong has removed a vote on this change. Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 Gerrit-Change-Number: 15801 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15801 to look at the new patch set (#4). Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct .. KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct This takes the Arena* member of RowBlock and moves it into a new RowBlockMemory structure. The RowBlockMemory structure will later be extended to include a list of reference-counted block handles. Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 --- M src/kudu/cfile/block_handle.h M src/kudu/cfile/cfile-test-base.h M src/kudu/cfile/cfile-test.cc M src/kudu/cfile/cfile_util.cc M src/kudu/cfile/encoding-test.cc M src/kudu/codegen/codegen-test.cc M src/kudu/common/column_predicate-test.cc A src/kudu/common/columnblock-test-util.h M src/kudu/common/columnblock-test.cc M src/kudu/common/columnblock.cc M src/kudu/common/columnblock.h M src/kudu/common/generic_iterators-test.cc M src/kudu/common/generic_iterators.cc M src/kudu/common/rowblock.cc M src/kudu/common/rowblock.h A src/kudu/common/rowblock_memory.h M src/kudu/common/wire_protocol-test.cc M src/kudu/integration-tests/linked_list-test-util.h M src/kudu/master/sys_catalog.cc M src/kudu/tablet/cfile_set-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_compaction.cc M src/kudu/tablet/deltafile-test.cc M src/kudu/tablet/diskrowset-test-base.h M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/mt-rowset_delta_compaction-test.cc M src/kudu/tablet/mt-tablet-test.cc M src/kudu/tablet/tablet-decoder-eval-test.cc M src/kudu/tablet/tablet-test-base.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet-test.cc M src/kudu/tablet/tablet_random_access-test.cc M src/kudu/tools/tool_action_local_replica.cc M src/kudu/tools/tool_action_perf.cc M src/kudu/transactions/txn_status_tablet.cc M src/kudu/tserver/tablet_server-test-base.cc M src/kudu/tserver/tablet_service.cc 38 files changed, 351 insertions(+), 257 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/15801/4 -- To view, visit http://gerrit.cloudera.org:8080/15801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 Gerrit-Change-Number: 15801 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15801 ) Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/15801/3/src/kudu/cfile/cfile-test.cc File src/kudu/cfile/cfile-test.cc: http://gerrit.cloudera.org:8080/#/c/15801/3/src/kudu/cfile/cfile-test.cc@639 PS3, Line 639: ASSERT_EQ(5000u, iter->GetCurrentOrdinal()); > warning: integer literal has suffix 'u', which is not uppercase [readabilit Done http://gerrit.cloudera.org:8080/#/c/15801/3/src/kudu/cfile/cfile-test.cc@706 PS3, Line 706: EXPECT_EQ(0u, iter->GetCurrentOrdinal()); > warning: integer literal has suffix 'u', which is not uppercase [readabilit Done http://gerrit.cloudera.org:8080/#/c/15801/3/src/kudu/cfile/cfile-test.cc@712 PS3, Line 712: ASSERT_EQ(0u, iter->GetCurrentOrdinal()); > warning: integer literal has suffix 'u', which is not uppercase [readabilit Done http://gerrit.cloudera.org:8080/#/c/15801/3/src/kudu/tablet/memrowset-test.cc File src/kudu/tablet/memrowset-test.cc: http://gerrit.cloudera.org:8080/#/c/15801/3/src/kudu/tablet/memrowset-test.cc@216 PS3, Line 216: mem.Reset(); > This wasn't necessary, was it? It's just good practice? yep http://gerrit.cloudera.org:8080/#/c/15801/3/src/kudu/tablet/tablet-decoder-eval-test.cc File src/kudu/tablet/tablet-decoder-eval-test.cc: http://gerrit.cloudera.org:8080/#/c/15801/3/src/kudu/tablet/tablet-decoder-eval-test.cc@267 PS3, Line 267: string column_str_a, column_str_b; > warning: multiple declarations in a single statement reduces readability [r Done http://gerrit.cloudera.org:8080/#/c/15801/3/src/kudu/tablet/tablet-test-util.h File src/kudu/tablet/tablet-test-util.h: http://gerrit.cloudera.org:8080/#/c/15801/3/src/kudu/tablet/tablet-test-util.h@200 PS3, Line 200: static inline Status SilentIterateToStringList(RowwiseIterator* iter, > warning: unused function 'SilentIterateToStringList' [clang-diagnostic-unus this function is actually used by other files that include it -- To view, visit http://gerrit.cloudera.org:8080/15801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 Gerrit-Change-Number: 15801 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Wed, 12 Aug 2020 21:27:52 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15801 ) Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15801/3/src/kudu/tablet/memrowset-test.cc File src/kudu/tablet/memrowset-test.cc: http://gerrit.cloudera.org:8080/#/c/15801/3/src/kudu/tablet/memrowset-test.cc@216 PS3, Line 216: mem.Reset(); This wasn't necessary, was it? It's just good practice? -- To view, visit http://gerrit.cloudera.org:8080/15801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 Gerrit-Change-Number: 15801 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 01 May 2020 05:33:43 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15801 to look at the new patch set (#3). Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct .. KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct This takes the Arena* member of RowBlock and moves it into a new RowBlockMemory structure. The RowBlockMemory structure will later be extended to include a list of reference-counted block handles. Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 --- M src/kudu/cfile/binary_prefix_block.cc M src/kudu/cfile/block_handle.h M src/kudu/cfile/cfile-test-base.h M src/kudu/cfile/cfile-test.cc M src/kudu/cfile/cfile_util.cc M src/kudu/cfile/encoding-test.cc M src/kudu/codegen/codegen-test.cc M src/kudu/common/column_predicate-test.cc A src/kudu/common/columnblock-test-util.h M src/kudu/common/columnblock-test.cc M src/kudu/common/columnblock.cc M src/kudu/common/columnblock.h M src/kudu/common/generic_iterators-test.cc M src/kudu/common/generic_iterators.cc M src/kudu/common/rowblock.cc M src/kudu/common/rowblock.h A src/kudu/common/rowblock_memory.h M src/kudu/common/wire_protocol-test.cc M src/kudu/integration-tests/linked_list-test-util.h M src/kudu/master/sys_catalog.cc M src/kudu/tablet/cfile_set-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_compaction.cc M src/kudu/tablet/deltafile-test.cc M src/kudu/tablet/diskrowset-test-base.h M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/mt-rowset_delta_compaction-test.cc M src/kudu/tablet/mt-tablet-test.cc M src/kudu/tablet/tablet-decoder-eval-test.cc M src/kudu/tablet/tablet-test-base.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet-test.cc M src/kudu/tablet/tablet_random_access-test.cc M src/kudu/tools/tool_action_local_replica.cc M src/kudu/tools/tool_action_perf.cc M src/kudu/tserver/tablet_server-test-base.cc M src/kudu/tserver/tablet_service.cc 38 files changed, 323 insertions(+), 223 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/15801/3 -- To view, visit http://gerrit.cloudera.org:8080/15801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 Gerrit-Change-Number: 15801 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct
Hello Tidy Bot, Andrew Wong, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15801 to look at the new patch set (#2). Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct .. KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct This takes the Arena* member of RowBlock and moves it into a new RowBlockMemory structure. The RowBlockMemory structure will later be extended to include a list of reference-counted block handles. Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 --- M src/kudu/cfile/binary_prefix_block.cc M src/kudu/cfile/block_handle.h M src/kudu/cfile/cfile-test-base.h M src/kudu/cfile/cfile-test.cc M src/kudu/cfile/cfile_util.cc M src/kudu/cfile/encoding-test.cc M src/kudu/codegen/codegen-test.cc M src/kudu/common/column_predicate-test.cc M src/kudu/common/columnar_serialization.cc A src/kudu/common/columnblock-test-util.h M src/kudu/common/columnblock-test.cc M src/kudu/common/columnblock.cc M src/kudu/common/columnblock.h M src/kudu/common/generic_iterators-test.cc M src/kudu/common/generic_iterators.cc M src/kudu/common/rowblock.cc M src/kudu/common/rowblock.h A src/kudu/common/rowblock_memory.h M src/kudu/common/wire_protocol-test.cc M src/kudu/common/wire_protocol.cc M src/kudu/integration-tests/linked_list-test-util.h M src/kudu/master/sys_catalog.cc M src/kudu/tablet/cfile_set-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_compaction.cc M src/kudu/tablet/deltafile-test.cc M src/kudu/tablet/diskrowset-test-base.h M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/mt-rowset_delta_compaction-test.cc M src/kudu/tablet/mt-tablet-test.cc M src/kudu/tablet/tablet-decoder-eval-test.cc M src/kudu/tablet/tablet-test-base.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet-test.cc M src/kudu/tablet/tablet_random_access-test.cc M src/kudu/tools/tool_action_local_replica.cc M src/kudu/tools/tool_action_perf.cc M src/kudu/tserver/tablet_server-test-base.cc M src/kudu/tserver/tablet_service.cc 40 files changed, 326 insertions(+), 225 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/15801/2 -- To view, visit http://gerrit.cloudera.org:8080/15801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 Gerrit-Change-Number: 15801 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15801 to review the following change. Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct .. KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct This takes the Arena* member of RowBlock and moves it into a new RowBlockMemory structure. The RowBlockMemory structure will later be extended to include a list of reference-counted block handles. Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 --- M src/kudu/cfile/binary_prefix_block.cc M src/kudu/cfile/block_handle.h M src/kudu/cfile/cfile-test-base.h M src/kudu/cfile/cfile-test.cc M src/kudu/cfile/cfile_util.cc M src/kudu/cfile/encoding-test.cc M src/kudu/codegen/codegen-test.cc M src/kudu/common/column_predicate-test.cc M src/kudu/common/columnar_serialization.cc A src/kudu/common/columnblock-test-util.h M src/kudu/common/columnblock-test.cc M src/kudu/common/columnblock.cc M src/kudu/common/columnblock.h M src/kudu/common/generic_iterators-test.cc M src/kudu/common/generic_iterators.cc M src/kudu/common/rowblock.cc M src/kudu/common/rowblock.h A src/kudu/common/rowblock_memory.h M src/kudu/common/wire_protocol-test.cc M src/kudu/common/wire_protocol.cc M src/kudu/integration-tests/linked_list-test-util.h M src/kudu/master/sys_catalog.cc M src/kudu/tablet/cfile_set-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_compaction.cc M src/kudu/tablet/deltafile-test.cc M src/kudu/tablet/diskrowset-test-base.h M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/mt-rowset_delta_compaction-test.cc M src/kudu/tablet/mt-tablet-test.cc M src/kudu/tablet/tablet-decoder-eval-test.cc M src/kudu/tablet/tablet-test-base.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet-test.cc M src/kudu/tablet/tablet_random_access-test.cc M src/kudu/tools/tool_action_local_replica.cc M src/kudu/tools/tool_action_perf.cc M src/kudu/tserver/tablet_server-test-base.cc M src/kudu/tserver/tablet_service.cc 40 files changed, 323 insertions(+), 224 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/15801/1 -- To view, visit http://gerrit.cloudera.org:8080/15801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 Gerrit-Change-Number: 15801 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong