[GitHub] [spark] SparkQA commented on pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source
SparkQA commented on pull request #34596: URL: https://github.com/apache/spark/pull/34596#issuecomment-979761329 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50128/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34720: [SPARK-37469][WebUI] unified shuffle read block time to shuffle read fetch wait time in StagePage
SparkQA commented on pull request #34720: URL: https://github.com/apache/spark/pull/34720#issuecomment-979760810 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50129/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979760611 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50126/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA removed a comment on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979703670 **[Test build #145656 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145656/testReport)** for PR 34715 at commit [`f69941e`](https://github.com/apache/spark/commit/f69941e931ec2e3ff0be433db928b4c9ee5bf0a7). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979751257 **[Test build #145656 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145656/testReport)** for PR 34715 at commit [`f69941e`](https://github.com/apache/spark/commit/f69941e931ec2e3ff0be433db928b4c9ee5bf0a7). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #34712: [SPARK-37463][SQL] Read/Write Timestamp ntz or ltz to Orc uses UTC timestamp
beliefer commented on a change in pull request #34712:
URL: https://github.com/apache/spark/pull/34712#discussion_r757277336
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
##
@@ -214,6 +213,21 @@ class OrcFileFormat
}
}
+ // This method references createRecordReader of OrcInputFormat.
+ // Just for call useUTCTimestamp of OrcFile.ReaderOptions.
+ private def createRecordReader[V <: WritableComparable[_]](
+ inputSplit: InputSplit,
+ taskAttemptContext: TaskAttemptContext):
mapreduce.OrcMapreduceRecordReader[V] = {
+val split = inputSplit.asInstanceOf[FileSplit]
+val conf = taskAttemptContext.getConfiguration()
+val readOptions = OrcFile.readerOptions(conf)
+ .maxLength(OrcConf.MAX_FILE_LENGTH.getLong(conf)).useUTCTimestamp(true)
Review comment:
@bersprockets Thank you for your investigation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34712: [SPARK-37463][SQL] Read/Write Timestamp ntz or ltz to Orc uses UTC timestamp
SparkQA commented on pull request #34712: URL: https://github.com/apache/spark/pull/34712#issuecomment-979749033 **[Test build #145660 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145660/testReport)** for PR 34712 at commit [`87be39c`](https://github.com/apache/spark/commit/87be39c9204430685ecb2e8edc227897dcda9a5c). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34720: [SPARK-37469][WebUI] unified shuffle read block time to shuffle read fetch wait time in StagePage
AmplabJenkins removed a comment on pull request #34720: URL: https://github.com/apache/spark/pull/34720#issuecomment-979719055 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34720: [SPARK-37469][WebUI] unified shuffle read block time to shuffle read fetch wait time in StagePage
SparkQA commented on pull request #34720: URL: https://github.com/apache/spark/pull/34720#issuecomment-979742130 **[Test build #145659 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145659/testReport)** for PR 34720 at commit [`bb10b06`](https://github.com/apache/spark/commit/bb10b06c597ff5814da5070a7e475a8d386a7893). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979740872 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50127/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34713: [SPARK-37464][SQL] SCHEMA and DATABASE should simply be aliases of NAMESPACE
AmplabJenkins removed a comment on pull request #34713: URL: https://github.com/apache/spark/pull/34713#issuecomment-979740580 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145641/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34713: [SPARK-37464][SQL] SCHEMA and DATABASE should simply be aliases of NAMESPACE
AmplabJenkins commented on pull request #34713: URL: https://github.com/apache/spark/pull/34713#issuecomment-979740580 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145641/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34719: [SPARK-37381][SQL] Unify v1 and v2 SHOW CREATE TABLE tests
AmplabJenkins removed a comment on pull request #34719: URL: https://github.com/apache/spark/pull/34719#issuecomment-979740143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
AmplabJenkins removed a comment on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979740142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34702: [SPARK-37455][SQL] Replace hash with sort aggregate if child is already sorted
AmplabJenkins removed a comment on pull request #34702: URL: https://github.com/apache/spark/pull/34702#issuecomment-979740144 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50120/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34575: [SPARK-37273][SQL] Support hidden file metadata columns in Spark SQL
AmplabJenkins removed a comment on pull request #34575: URL: https://github.com/apache/spark/pull/34575#issuecomment-979740140 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50121/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
AmplabJenkins commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979740142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34719: [SPARK-37381][SQL] Unify v1 and v2 SHOW CREATE TABLE tests
AmplabJenkins commented on pull request #34719: URL: https://github.com/apache/spark/pull/34719#issuecomment-979740143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34575: [SPARK-37273][SQL] Support hidden file metadata columns in Spark SQL
AmplabJenkins commented on pull request #34575: URL: https://github.com/apache/spark/pull/34575#issuecomment-979740140 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50121/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34702: [SPARK-37455][SQL] Replace hash with sort aggregate if child is already sorted
AmplabJenkins commented on pull request #34702: URL: https://github.com/apache/spark/pull/34702#issuecomment-979740144 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50120/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34713: [SPARK-37464][SQL] SCHEMA and DATABASE should simply be aliases of NAMESPACE
SparkQA removed a comment on pull request #34713: URL: https://github.com/apache/spark/pull/34713#issuecomment-979619854 **[Test build #145641 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145641/testReport)** for PR 34713 at commit [`eca043f`](https://github.com/apache/spark/commit/eca043f67805d774a1ac24ec5270e4673ea7a188). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] toujours33 commented on pull request #34720: [SPARK-37469][WebUI] unified shuffle read block time to shuffle read fetch wait time in StagePage
toujours33 commented on pull request #34720: URL: https://github.com/apache/spark/pull/34720#issuecomment-979739800 > @toujours33 nit, but could you update the [screenshot](http://spark.apache.org/docs/latest/img/AllStagesPageDetail6.png) in the [doc](spark.apache.org/docs/latest/web-ui.html) ? ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34713: [SPARK-37464][SQL] SCHEMA and DATABASE should simply be aliases of NAMESPACE
SparkQA commented on pull request #34713: URL: https://github.com/apache/spark/pull/34713#issuecomment-979739731 **[Test build #145641 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145641/testReport)** for PR 34713 at commit [`eca043f`](https://github.com/apache/spark/commit/eca043f67805d774a1ac24ec5270e4673ea7a188). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979737447 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50125/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34719: [SPARK-37381][SQL] Unify v1 and v2 SHOW CREATE TABLE tests
SparkQA commented on pull request #34719: URL: https://github.com/apache/spark/pull/34719#issuecomment-979737271 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50122/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979734720 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50126/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34575: [SPARK-37273][SQL] Support hidden file metadata columns in Spark SQL
SparkQA commented on pull request #34575: URL: https://github.com/apache/spark/pull/34575#issuecomment-979734219 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50121/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34702: [SPARK-37455][SQL] Replace hash with sort aggregate if child is already sorted
SparkQA commented on pull request #34702: URL: https://github.com/apache/spark/pull/34702#issuecomment-979733581 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50120/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #34710: [SPARK-37461][YARN] YARN-CLIENT mode client.appId is always null
sarutak edited a comment on pull request #34710: URL: https://github.com/apache/spark/pull/34710#issuecomment-979695437 @AngersZh Could you describe what you propose in `What changes were proposed in this pull request?`? `YARN-CLIENT mode client.appId is always null` doesn't describe what you propose, but what the problem is (maybe, `Why are the changes needed?` needs to be modified together). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979732404 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50124/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34719: [SPARK-37381][SQL] Unify v1 and v2 SHOW CREATE TABLE tests
SparkQA commented on pull request #34719: URL: https://github.com/apache/spark/pull/34719#issuecomment-979732281 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50123/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] Peng-Lei commented on pull request #34719: [SPARK-37381][SQL] Unify v1 and v2 SHOW CREATE TABLE tests
Peng-Lei commented on pull request #34719: URL: https://github.com/apache/spark/pull/34719#issuecomment-979730567 @MaxGekk @cloud-fan @imback82 Could you take a look? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #34720: [SPARK-37469][WebUI] unified shuffle read block time to shuffle read fetch wait time in StagePage
sarutak commented on pull request #34720: URL: https://github.com/apache/spark/pull/34720#issuecomment-979729069 Also, could you add the screenshot of before/after this change to the description? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] Peng-Lei commented on a change in pull request #34719: [SPARK-37381][SQL] Unify v1 and v2 SHOW CREATE TABLE tests
Peng-Lei commented on a change in pull request #34719:
URL: https://github.com/apache/spark/pull/34719#discussion_r757257983
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/ShowCreateTableSuite.scala
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.command.v2
+
+import org.apache.spark.sql.AnalysisException
+import org.apache.spark.sql.execution.command
+
+/**
+ * The class contains tests for the `SHOW CREATE TABLE` command to check V2
table catalogs.
+ */
+class ShowCreateTableSuite extends command.ShowCreateTableSuiteBase with
CommandSuiteBase {
+ test("SPARK-33898: SHOW CREATE TABLE AS SERDE") {
+val db = "ns1"
+val table = "tbl"
+withNamespaceAndTable(db, table) { t =>
+ spark.sql(s"CREATE TABLE $t (id bigint, data string) $defaultUsing")
+ val e = intercept[AnalysisException] {
+sql(s"SHOW CREATE TABLE $t AS SERDE")
+ }
+ assert(e.message.contains(s"SHOW CREATE TABLE AS SERDE is not supported
for v2 tables."))
+}
+ }
+
+ test("CTAS") {
+val db = "ns1"
+val table = "ddl_test"
+withNamespaceAndTable(db, table) { t =>
+ sql(
+s"""CREATE TABLE $t
+ |$defaultUsing
+ |PARTITIONED BY (a)
+ |COMMENT 'This is a comment'
+ |TBLPROPERTIES ('a' = '1')
+ |AS SELECT 1 AS a, "foo" AS b
+ """.stripMargin
+ )
+ val showDDL = getShowCreateDDL(s"SHOW CREATE TABLE $t")
+ assert(showDDL === Array(
+s"CREATE TABLE $t (",
+"`a` INT,",
+"`b` STRING)",
+defaultUsing,
+"PARTITIONED BY (a)",
+"COMMENT 'This is a comment'",
+"TBLPROPERTIES(",
+"'a' = '1')"
+ ))
+}
+ }
+
+ test("SPARK-33898: SHOW CREATE TABLE") {
+val db = "ns1"
+val table = "tbl"
+withNamespaceAndTable(db, table) { t =>
+ sql(
+s"""
+ |CREATE TABLE $t (
+ | a bigint NOT NULL,
+ | b bigint,
+ | c bigint,
+ | `extraCol` ARRAY,
+ | `` STRUCT>
+ |)
+ |$defaultUsing
+ |OPTIONS (
+ | from = 0,
+ | to = 1,
+ | via = 2)
+ |COMMENT 'This is a comment'
+ |TBLPROPERTIES ('prop1' = '1', 'prop2' = '2', 'prop3' = 3, 'prop4'
= 4)
+ |PARTITIONED BY (a)
+ |LOCATION '/tmp'
+""".stripMargin)
+ val showDDL = getShowCreateDDL(s"SHOW CREATE TABLE $t")
+ assert(showDDL === Array(
+s"CREATE TABLE $t (",
+"`a` BIGINT NOT NULL,",
+"`b` BIGINT,",
+"`c` BIGINT,",
+"`extraCol` ARRAY,",
+"`` STRUCT<`x`: INT, `y`: ARRAY>)",
+defaultUsing,
+"OPTIONS(",
+"'from' = '0',",
+"'to' = '1',",
+"'via' = '2')",
+"PARTITIONED BY (a)",
+"COMMENT 'This is a comment'",
+"LOCATION '/tmp'",
+"TBLPROPERTIES(",
+"'prop1' = '1',",
+"'prop2' = '2',",
+"'prop3' = '3',",
+"'prop4' = '4')"
+ ))
+}
+ }
+
+ test("SPARK-33898: SHOW CREATE TABLE PARTITIONED BY TRANSFORMS") {
+val db = "ns1"
+val table = "tbl"
+withNamespaceAndTable(db, table) { t =>
+ sql(
+s"""
+ |CREATE TABLE $t (a INT, b STRING, ts TIMESTAMP) $defaultUsing
+ |PARTITIONED BY (
+ |a,
+ |bucket(16, b),
+ |years(ts),
+ |months(ts),
+ |days(ts),
+ |hours(ts))
+ """.stripMargin)
+ // V1 transforms cannot be converted to partition columns:
bucket,year,...)
+ val showDDL = getShowCreateDDL(s"SHOW CREATE TABLE $t")
Review comment:
As we could not convert to patition columns for v1,so put it here just
for v2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [spark] sarutak commented on pull request #34720: [SPARK-37469][WebUI] unified shuffle read block time to shuffle read fetch wait time in StagePage
sarutak commented on pull request #34720: URL: https://github.com/apache/spark/pull/34720#issuecomment-979728617 @toujours33 nit, but could you update the [screenshot](http://spark.apache.org/docs/latest/img/AllStagesPageDetail6.png) in the [doc](spark.apache.org/docs/latest/web-ui.html) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] Peng-Lei commented on a change in pull request #34719: [SPARK-37381][SQL] Unify v1 and v2 SHOW CREATE TABLE tests
Peng-Lei commented on a change in pull request #34719:
URL: https://github.com/apache/spark/pull/34719#discussion_r757256714
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowCreateTableSuite.scala
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.command.v1
+
+import org.apache.spark.sql.catalyst.TableIdentifier
+import org.apache.spark.sql.catalyst.catalog.CatalogTable
+import org.apache.spark.sql.execution.command
+
+/**
+ * This base suite contains unified tests for the `SHOW CREATE TABLE` command
that checks V1
+ * table catalogs. The tests that cannot run for all V1 catalogs are located
in more
+ * specific test suites:
+ *
+ * - V1 In-Memory catalog:
`org.apache.spark.sql.execution.command.v1.ShowCreateTableSuite`
+ * - V1 Hive External catalog:
+ * `org.apache.spark.sql.hive.execution.command.ShowCreateTableSuite`
+ */
+trait ShowCreateTableSuiteBase extends command.ShowCreateTableSuiteBase
+with command.TestsV1AndV2Commands {
+
+ test("CATS") {
+val table = "ddl_test"
+withTable(table) {
+ sql(
+s"""CREATE TABLE $table
+ |USING json
+ |PARTITIONED BY (c)
+ |CLUSTERED BY (a) SORTED BY (b) INTO 2 BUCKETS
+ |COMMENT 'This is a comment'
+ |TBLPROPERTIES ('a' = '1')
+ |AS SELECT 1 AS a, "foo" AS b, 2.5 AS c
+ """.stripMargin
+ )
+ checkCreateTable(table)
+}
+ }
+
+ protected def checkCreateTable(table: String, serde: Boolean = false): Unit
= {
+checkCreateTableOrView(TableIdentifier(table, Some("default")), "TABLE",
serde)
+ }
+
+ protected def checkCreateView(table: String, serde: Boolean = false): Unit =
{
+checkCreateTableOrView(TableIdentifier(table, Some("default")), "VIEW",
serde)
+ }
+
+ protected def checkCreateTableOrView(
+ table: TableIdentifier,
+ checkType: String,
+ serde: Boolean): Unit = {
+val db = table.database.getOrElse("default")
+val expected = spark.sharedState.externalCatalog.getTable(db, table.table)
+val shownDDL = if (serde) {
+ sql(s"SHOW CREATE TABLE ${table.quotedString} AS
SERDE").head().getString(0)
+} else {
+ sql(s"SHOW CREATE TABLE ${table.quotedString}").head().getString(0)
+}
+sql(s"DROP $checkType ${table.quotedString}")
+try {
+ sql(shownDDL)
+ val actual = spark.sharedState.externalCatalog.getTable(db, table.table)
+ checkCatalogTables(expected, actual)
+} finally {
+ sql(s"DROP $checkType IF EXISTS ${table.table}")
+}
+ }
+
+ protected def checkCatalogTables(expected: CatalogTable, actual:
CatalogTable): Unit = {
+assert(CatalogTable.normalize(actual) == CatalogTable.normalize(expected))
+ }
+}
+
+/**
+ * The class contains tests for the `SHOW CREATE TABLE` command to check V1
In-Memory
+ * table catalog.
+ */
+class ShowCreateTableSuite extends ShowCreateTableSuiteBase with
CommandSuiteBase {
+ override def commandVersion: String =
super[ShowCreateTableSuiteBase].commandVersion
+
+ test("SHOW CREATE TABLE") {
+val t = "tbl"
+withTable(t) {
+ sql(
+s"""
+ |CREATE TABLE $t (
+ | a bigint NOT NULL,
+ | b bigint,
+ | c bigint,
+ | `extraCol` ARRAY,
+ | `` STRUCT>
+ |)
+ |$defaultUsing
+ |OPTIONS (
+ | from = 0,
+ | to = 1,
+ | via = 2)
+ |COMMENT 'This is a comment'
+ |TBLPROPERTIES ('prop1' = '1', 'prop2' = '2', 'prop3' = 3, 'prop4'
= 4)
+ |PARTITIONED BY (a)
+ |LOCATION '/tmp'
+""".stripMargin)
+ val showDDL = getShowCreateDDL(s"SHOW CREATE TABLE $t")
+ assert(showDDL === Array(
+s"CREATE TABLE `default`.`$t` (",
+"`b` BIGINT,",
+"`c` BIGINT,",
+"`extraCol` ARRAY,",
+"`` STRUCT<`x`: INT, `y`: ARRAY>,",
+"`a` BIGINT NOT NULL)",
+defaultUsing,
+"OPTIONS (",
+"`from` '0',",
+"`to` '1',",
+"`via` '2')",
+"PARTITIONED BY (a)",
+"COMMENT 'This is a comment'",
+
[GitHub] [spark] Peng-Lei commented on a change in pull request #34719: [SPARK-37381][SQL] Unify v1 and v2 SHOW CREATE TABLE tests
Peng-Lei commented on a change in pull request #34719:
URL: https://github.com/apache/spark/pull/34719#discussion_r757256714
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowCreateTableSuite.scala
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.command.v1
+
+import org.apache.spark.sql.catalyst.TableIdentifier
+import org.apache.spark.sql.catalyst.catalog.CatalogTable
+import org.apache.spark.sql.execution.command
+
+/**
+ * This base suite contains unified tests for the `SHOW CREATE TABLE` command
that checks V1
+ * table catalogs. The tests that cannot run for all V1 catalogs are located
in more
+ * specific test suites:
+ *
+ * - V1 In-Memory catalog:
`org.apache.spark.sql.execution.command.v1.ShowCreateTableSuite`
+ * - V1 Hive External catalog:
+ * `org.apache.spark.sql.hive.execution.command.ShowCreateTableSuite`
+ */
+trait ShowCreateTableSuiteBase extends command.ShowCreateTableSuiteBase
+with command.TestsV1AndV2Commands {
+
+ test("CATS") {
+val table = "ddl_test"
+withTable(table) {
+ sql(
+s"""CREATE TABLE $table
+ |USING json
+ |PARTITIONED BY (c)
+ |CLUSTERED BY (a) SORTED BY (b) INTO 2 BUCKETS
+ |COMMENT 'This is a comment'
+ |TBLPROPERTIES ('a' = '1')
+ |AS SELECT 1 AS a, "foo" AS b, 2.5 AS c
+ """.stripMargin
+ )
+ checkCreateTable(table)
+}
+ }
+
+ protected def checkCreateTable(table: String, serde: Boolean = false): Unit
= {
+checkCreateTableOrView(TableIdentifier(table, Some("default")), "TABLE",
serde)
+ }
+
+ protected def checkCreateView(table: String, serde: Boolean = false): Unit =
{
+checkCreateTableOrView(TableIdentifier(table, Some("default")), "VIEW",
serde)
+ }
+
+ protected def checkCreateTableOrView(
+ table: TableIdentifier,
+ checkType: String,
+ serde: Boolean): Unit = {
+val db = table.database.getOrElse("default")
+val expected = spark.sharedState.externalCatalog.getTable(db, table.table)
+val shownDDL = if (serde) {
+ sql(s"SHOW CREATE TABLE ${table.quotedString} AS
SERDE").head().getString(0)
+} else {
+ sql(s"SHOW CREATE TABLE ${table.quotedString}").head().getString(0)
+}
+sql(s"DROP $checkType ${table.quotedString}")
+try {
+ sql(shownDDL)
+ val actual = spark.sharedState.externalCatalog.getTable(db, table.table)
+ checkCatalogTables(expected, actual)
+} finally {
+ sql(s"DROP $checkType IF EXISTS ${table.table}")
+}
+ }
+
+ protected def checkCatalogTables(expected: CatalogTable, actual:
CatalogTable): Unit = {
+assert(CatalogTable.normalize(actual) == CatalogTable.normalize(expected))
+ }
+}
+
+/**
+ * The class contains tests for the `SHOW CREATE TABLE` command to check V1
In-Memory
+ * table catalog.
+ */
+class ShowCreateTableSuite extends ShowCreateTableSuiteBase with
CommandSuiteBase {
+ override def commandVersion: String =
super[ShowCreateTableSuiteBase].commandVersion
+
+ test("SHOW CREATE TABLE") {
+val t = "tbl"
+withTable(t) {
+ sql(
+s"""
+ |CREATE TABLE $t (
+ | a bigint NOT NULL,
+ | b bigint,
+ | c bigint,
+ | `extraCol` ARRAY,
+ | `` STRUCT>
+ |)
+ |$defaultUsing
+ |OPTIONS (
+ | from = 0,
+ | to = 1,
+ | via = 2)
+ |COMMENT 'This is a comment'
+ |TBLPROPERTIES ('prop1' = '1', 'prop2' = '2', 'prop3' = 3, 'prop4'
= 4)
+ |PARTITIONED BY (a)
+ |LOCATION '/tmp'
+""".stripMargin)
+ val showDDL = getShowCreateDDL(s"SHOW CREATE TABLE $t")
+ assert(showDDL === Array(
+s"CREATE TABLE `default`.`$t` (",
+"`b` BIGINT,",
+"`c` BIGINT,",
+"`extraCol` ARRAY,",
+"`` STRUCT<`x`: INT, `y`: ARRAY>,",
+"`a` BIGINT NOT NULL)",
+defaultUsing,
+"OPTIONS (",
+"`from` '0',",
+"`to` '1',",
+"`via` '2')",
+"PARTITIONED BY (a)",
+"COMMENT 'This is a comment'",
+
[GitHub] [spark] Peng-Lei commented on a change in pull request #34719: [SPARK-37381][SQL] Unify v1 and v2 SHOW CREATE TABLE tests
Peng-Lei commented on a change in pull request #34719:
URL: https://github.com/apache/spark/pull/34719#discussion_r757256714
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowCreateTableSuite.scala
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.command.v1
+
+import org.apache.spark.sql.catalyst.TableIdentifier
+import org.apache.spark.sql.catalyst.catalog.CatalogTable
+import org.apache.spark.sql.execution.command
+
+/**
+ * This base suite contains unified tests for the `SHOW CREATE TABLE` command
that checks V1
+ * table catalogs. The tests that cannot run for all V1 catalogs are located
in more
+ * specific test suites:
+ *
+ * - V1 In-Memory catalog:
`org.apache.spark.sql.execution.command.v1.ShowCreateTableSuite`
+ * - V1 Hive External catalog:
+ * `org.apache.spark.sql.hive.execution.command.ShowCreateTableSuite`
+ */
+trait ShowCreateTableSuiteBase extends command.ShowCreateTableSuiteBase
+with command.TestsV1AndV2Commands {
+
+ test("CATS") {
+val table = "ddl_test"
+withTable(table) {
+ sql(
+s"""CREATE TABLE $table
+ |USING json
+ |PARTITIONED BY (c)
+ |CLUSTERED BY (a) SORTED BY (b) INTO 2 BUCKETS
+ |COMMENT 'This is a comment'
+ |TBLPROPERTIES ('a' = '1')
+ |AS SELECT 1 AS a, "foo" AS b, 2.5 AS c
+ """.stripMargin
+ )
+ checkCreateTable(table)
+}
+ }
+
+ protected def checkCreateTable(table: String, serde: Boolean = false): Unit
= {
+checkCreateTableOrView(TableIdentifier(table, Some("default")), "TABLE",
serde)
+ }
+
+ protected def checkCreateView(table: String, serde: Boolean = false): Unit =
{
+checkCreateTableOrView(TableIdentifier(table, Some("default")), "VIEW",
serde)
+ }
+
+ protected def checkCreateTableOrView(
+ table: TableIdentifier,
+ checkType: String,
+ serde: Boolean): Unit = {
+val db = table.database.getOrElse("default")
+val expected = spark.sharedState.externalCatalog.getTable(db, table.table)
+val shownDDL = if (serde) {
+ sql(s"SHOW CREATE TABLE ${table.quotedString} AS
SERDE").head().getString(0)
+} else {
+ sql(s"SHOW CREATE TABLE ${table.quotedString}").head().getString(0)
+}
+sql(s"DROP $checkType ${table.quotedString}")
+try {
+ sql(shownDDL)
+ val actual = spark.sharedState.externalCatalog.getTable(db, table.table)
+ checkCatalogTables(expected, actual)
+} finally {
+ sql(s"DROP $checkType IF EXISTS ${table.table}")
+}
+ }
+
+ protected def checkCatalogTables(expected: CatalogTable, actual:
CatalogTable): Unit = {
+assert(CatalogTable.normalize(actual) == CatalogTable.normalize(expected))
+ }
+}
+
+/**
+ * The class contains tests for the `SHOW CREATE TABLE` command to check V1
In-Memory
+ * table catalog.
+ */
+class ShowCreateTableSuite extends ShowCreateTableSuiteBase with
CommandSuiteBase {
+ override def commandVersion: String =
super[ShowCreateTableSuiteBase].commandVersion
+
+ test("SHOW CREATE TABLE") {
+val t = "tbl"
+withTable(t) {
+ sql(
+s"""
+ |CREATE TABLE $t (
+ | a bigint NOT NULL,
+ | b bigint,
+ | c bigint,
+ | `extraCol` ARRAY,
+ | `` STRUCT>
+ |)
+ |$defaultUsing
+ |OPTIONS (
+ | from = 0,
+ | to = 1,
+ | via = 2)
+ |COMMENT 'This is a comment'
+ |TBLPROPERTIES ('prop1' = '1', 'prop2' = '2', 'prop3' = 3, 'prop4'
= 4)
+ |PARTITIONED BY (a)
+ |LOCATION '/tmp'
+""".stripMargin)
+ val showDDL = getShowCreateDDL(s"SHOW CREATE TABLE $t")
+ assert(showDDL === Array(
+s"CREATE TABLE `default`.`$t` (",
+"`b` BIGINT,",
+"`c` BIGINT,",
+"`extraCol` ARRAY,",
+"`` STRUCT<`x`: INT, `y`: ARRAY>,",
+"`a` BIGINT NOT NULL)",
+defaultUsing,
+"OPTIONS (",
+"`from` '0',",
+"`to` '1',",
+"`via` '2')",
+"PARTITIONED BY (a)",
+"COMMENT 'This is a comment'",
+
[GitHub] [spark] sarutak commented on pull request #34720: [SPARK-37469][WebUI] unified shuffle read block time to shuffle read fetch wait time in StagePage
sarutak commented on pull request #34720: URL: https://github.com/apache/spark/pull/34720#issuecomment-979727702 ok to test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] Peng-Lei commented on a change in pull request #34719: [SPARK-37381][SQL] Unify v1 and v2 SHOW CREATE TABLE tests
Peng-Lei commented on a change in pull request #34719:
URL: https://github.com/apache/spark/pull/34719#discussion_r757256714
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowCreateTableSuite.scala
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.command.v1
+
+import org.apache.spark.sql.catalyst.TableIdentifier
+import org.apache.spark.sql.catalyst.catalog.CatalogTable
+import org.apache.spark.sql.execution.command
+
+/**
+ * This base suite contains unified tests for the `SHOW CREATE TABLE` command
that checks V1
+ * table catalogs. The tests that cannot run for all V1 catalogs are located
in more
+ * specific test suites:
+ *
+ * - V1 In-Memory catalog:
`org.apache.spark.sql.execution.command.v1.ShowCreateTableSuite`
+ * - V1 Hive External catalog:
+ * `org.apache.spark.sql.hive.execution.command.ShowCreateTableSuite`
+ */
+trait ShowCreateTableSuiteBase extends command.ShowCreateTableSuiteBase
+with command.TestsV1AndV2Commands {
+
+ test("CATS") {
+val table = "ddl_test"
+withTable(table) {
+ sql(
+s"""CREATE TABLE $table
+ |USING json
+ |PARTITIONED BY (c)
+ |CLUSTERED BY (a) SORTED BY (b) INTO 2 BUCKETS
+ |COMMENT 'This is a comment'
+ |TBLPROPERTIES ('a' = '1')
+ |AS SELECT 1 AS a, "foo" AS b, 2.5 AS c
+ """.stripMargin
+ )
+ checkCreateTable(table)
+}
+ }
+
+ protected def checkCreateTable(table: String, serde: Boolean = false): Unit
= {
+checkCreateTableOrView(TableIdentifier(table, Some("default")), "TABLE",
serde)
+ }
+
+ protected def checkCreateView(table: String, serde: Boolean = false): Unit =
{
+checkCreateTableOrView(TableIdentifier(table, Some("default")), "VIEW",
serde)
+ }
+
+ protected def checkCreateTableOrView(
+ table: TableIdentifier,
+ checkType: String,
+ serde: Boolean): Unit = {
+val db = table.database.getOrElse("default")
+val expected = spark.sharedState.externalCatalog.getTable(db, table.table)
+val shownDDL = if (serde) {
+ sql(s"SHOW CREATE TABLE ${table.quotedString} AS
SERDE").head().getString(0)
+} else {
+ sql(s"SHOW CREATE TABLE ${table.quotedString}").head().getString(0)
+}
+sql(s"DROP $checkType ${table.quotedString}")
+try {
+ sql(shownDDL)
+ val actual = spark.sharedState.externalCatalog.getTable(db, table.table)
+ checkCatalogTables(expected, actual)
+} finally {
+ sql(s"DROP $checkType IF EXISTS ${table.table}")
+}
+ }
+
+ protected def checkCatalogTables(expected: CatalogTable, actual:
CatalogTable): Unit = {
+assert(CatalogTable.normalize(actual) == CatalogTable.normalize(expected))
+ }
+}
+
+/**
+ * The class contains tests for the `SHOW CREATE TABLE` command to check V1
In-Memory
+ * table catalog.
+ */
+class ShowCreateTableSuite extends ShowCreateTableSuiteBase with
CommandSuiteBase {
+ override def commandVersion: String =
super[ShowCreateTableSuiteBase].commandVersion
+
+ test("SHOW CREATE TABLE") {
+val t = "tbl"
+withTable(t) {
+ sql(
+s"""
+ |CREATE TABLE $t (
+ | a bigint NOT NULL,
+ | b bigint,
+ | c bigint,
+ | `extraCol` ARRAY,
+ | `` STRUCT>
+ |)
+ |$defaultUsing
+ |OPTIONS (
+ | from = 0,
+ | to = 1,
+ | via = 2)
+ |COMMENT 'This is a comment'
+ |TBLPROPERTIES ('prop1' = '1', 'prop2' = '2', 'prop3' = 3, 'prop4'
= 4)
+ |PARTITIONED BY (a)
+ |LOCATION '/tmp'
+""".stripMargin)
+ val showDDL = getShowCreateDDL(s"SHOW CREATE TABLE $t")
+ assert(showDDL === Array(
+s"CREATE TABLE `default`.`$t` (",
+"`b` BIGINT,",
+"`c` BIGINT,",
+"`extraCol` ARRAY,",
+"`` STRUCT<`x`: INT, `y`: ARRAY>,",
+"`a` BIGINT NOT NULL)",
+defaultUsing,
+"OPTIONS (",
+"`from` '0',",
+"`to` '1',",
+"`via` '2')",
+"PARTITIONED BY (a)",
+"COMMENT 'This is a comment'",
+
[GitHub] [spark] Peng-Lei commented on a change in pull request #34719: [SPARK-37381][SQL] Unify v1 and v2 SHOW CREATE TABLE tests
Peng-Lei commented on a change in pull request #34719:
URL: https://github.com/apache/spark/pull/34719#discussion_r757256714
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowCreateTableSuite.scala
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.command.v1
+
+import org.apache.spark.sql.catalyst.TableIdentifier
+import org.apache.spark.sql.catalyst.catalog.CatalogTable
+import org.apache.spark.sql.execution.command
+
+/**
+ * This base suite contains unified tests for the `SHOW CREATE TABLE` command
that checks V1
+ * table catalogs. The tests that cannot run for all V1 catalogs are located
in more
+ * specific test suites:
+ *
+ * - V1 In-Memory catalog:
`org.apache.spark.sql.execution.command.v1.ShowCreateTableSuite`
+ * - V1 Hive External catalog:
+ * `org.apache.spark.sql.hive.execution.command.ShowCreateTableSuite`
+ */
+trait ShowCreateTableSuiteBase extends command.ShowCreateTableSuiteBase
+with command.TestsV1AndV2Commands {
+
+ test("CATS") {
+val table = "ddl_test"
+withTable(table) {
+ sql(
+s"""CREATE TABLE $table
+ |USING json
+ |PARTITIONED BY (c)
+ |CLUSTERED BY (a) SORTED BY (b) INTO 2 BUCKETS
+ |COMMENT 'This is a comment'
+ |TBLPROPERTIES ('a' = '1')
+ |AS SELECT 1 AS a, "foo" AS b, 2.5 AS c
+ """.stripMargin
+ )
+ checkCreateTable(table)
+}
+ }
+
+ protected def checkCreateTable(table: String, serde: Boolean = false): Unit
= {
+checkCreateTableOrView(TableIdentifier(table, Some("default")), "TABLE",
serde)
+ }
+
+ protected def checkCreateView(table: String, serde: Boolean = false): Unit =
{
+checkCreateTableOrView(TableIdentifier(table, Some("default")), "VIEW",
serde)
+ }
+
+ protected def checkCreateTableOrView(
+ table: TableIdentifier,
+ checkType: String,
+ serde: Boolean): Unit = {
+val db = table.database.getOrElse("default")
+val expected = spark.sharedState.externalCatalog.getTable(db, table.table)
+val shownDDL = if (serde) {
+ sql(s"SHOW CREATE TABLE ${table.quotedString} AS
SERDE").head().getString(0)
+} else {
+ sql(s"SHOW CREATE TABLE ${table.quotedString}").head().getString(0)
+}
+sql(s"DROP $checkType ${table.quotedString}")
+try {
+ sql(shownDDL)
+ val actual = spark.sharedState.externalCatalog.getTable(db, table.table)
+ checkCatalogTables(expected, actual)
+} finally {
+ sql(s"DROP $checkType IF EXISTS ${table.table}")
+}
+ }
+
+ protected def checkCatalogTables(expected: CatalogTable, actual:
CatalogTable): Unit = {
+assert(CatalogTable.normalize(actual) == CatalogTable.normalize(expected))
+ }
+}
+
+/**
+ * The class contains tests for the `SHOW CREATE TABLE` command to check V1
In-Memory
+ * table catalog.
+ */
+class ShowCreateTableSuite extends ShowCreateTableSuiteBase with
CommandSuiteBase {
+ override def commandVersion: String =
super[ShowCreateTableSuiteBase].commandVersion
+
+ test("SHOW CREATE TABLE") {
+val t = "tbl"
+withTable(t) {
+ sql(
+s"""
+ |CREATE TABLE $t (
+ | a bigint NOT NULL,
+ | b bigint,
+ | c bigint,
+ | `extraCol` ARRAY,
+ | `` STRUCT>
+ |)
+ |$defaultUsing
+ |OPTIONS (
+ | from = 0,
+ | to = 1,
+ | via = 2)
+ |COMMENT 'This is a comment'
+ |TBLPROPERTIES ('prop1' = '1', 'prop2' = '2', 'prop3' = 3, 'prop4'
= 4)
+ |PARTITIONED BY (a)
+ |LOCATION '/tmp'
+""".stripMargin)
+ val showDDL = getShowCreateDDL(s"SHOW CREATE TABLE $t")
+ assert(showDDL === Array(
+s"CREATE TABLE `default`.`$t` (",
+"`b` BIGINT,",
+"`c` BIGINT,",
+"`extraCol` ARRAY,",
+"`` STRUCT<`x`: INT, `y`: ARRAY>,",
+"`a` BIGINT NOT NULL)",
+defaultUsing,
+"OPTIONS (",
+"`from` '0',",
+"`to` '1',",
+"`via` '2')",
+"PARTITIONED BY (a)",
+"COMMENT 'This is a comment'",
+
[GitHub] [spark] Peng-Lei commented on a change in pull request #34719: [SPARK-37381][SQL] Unify v1 and v2 SHOW CREATE TABLE tests
Peng-Lei commented on a change in pull request #34719:
URL: https://github.com/apache/spark/pull/34719#discussion_r757254642
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowCreateTableSuite.scala
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.command.v1
+
+import org.apache.spark.sql.catalyst.TableIdentifier
+import org.apache.spark.sql.catalyst.catalog.CatalogTable
+import org.apache.spark.sql.execution.command
+
+/**
+ * This base suite contains unified tests for the `SHOW CREATE TABLE` command
that checks V1
+ * table catalogs. The tests that cannot run for all V1 catalogs are located
in more
+ * specific test suites:
+ *
+ * - V1 In-Memory catalog:
`org.apache.spark.sql.execution.command.v1.ShowCreateTableSuite`
+ * - V1 Hive External catalog:
+ * `org.apache.spark.sql.hive.execution.command.ShowCreateTableSuite`
+ */
+trait ShowCreateTableSuiteBase extends command.ShowCreateTableSuiteBase
+with command.TestsV1AndV2Commands {
+
+ test("CATS") {
+val table = "ddl_test"
+withTable(table) {
+ sql(
+s"""CREATE TABLE $table
+ |USING json
+ |PARTITIONED BY (c)
+ |CLUSTERED BY (a) SORTED BY (b) INTO 2 BUCKETS
+ |COMMENT 'This is a comment'
+ |TBLPROPERTIES ('a' = '1')
+ |AS SELECT 1 AS a, "foo" AS b, 2.5 AS c
+ """.stripMargin
+ )
+ checkCreateTable(table)
+}
+ }
Review comment:
As could not convert `CLUSTERTED` `SORTED` into transform, So we could
not put it to `ShowCreateTableBaseSuite` for V2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] Peng-Lei commented on a change in pull request #34719: [SPARK-37381][SQL] Unify v1 and v2 SHOW CREATE TABLE tests
Peng-Lei commented on a change in pull request #34719:
URL: https://github.com/apache/spark/pull/34719#discussion_r757251460
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/ShowCreateTableSuite.scala
##
@@ -1,241 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- *http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.spark.sql
-
-import org.apache.spark.sql.catalyst.TableIdentifier
-import org.apache.spark.sql.catalyst.catalog.CatalogTable
-import org.apache.spark.sql.sources.SimpleInsertSource
-import org.apache.spark.sql.test.{SharedSparkSession, SQLTestUtils}
-import org.apache.spark.util.Utils
-
-class SimpleShowCreateTableSuite extends ShowCreateTableSuite with
SharedSparkSession
-
-abstract class ShowCreateTableSuite extends QueryTest with SQLTestUtils {
- import testImplicits._
-
- test("data source table with user specified schema") {
-withTable("ddl_test") {
- val jsonFilePath =
Utils.getSparkClassLoader.getResource("sample.json").getFile
-
- sql(
-s"""CREATE TABLE ddl_test (
- | a STRING,
- | b STRING,
- | `extra col` ARRAY,
- | `` STRUCT>
- |)
- |USING json
- |OPTIONS (
- | PATH '$jsonFilePath'
- |)
- """.stripMargin
- )
-
- checkCreateTable("ddl_test")
-}
- }
-
- test("data source table CTAS") {
-withTable("ddl_test") {
- sql(
-s"""CREATE TABLE ddl_test
- |USING json
- |AS SELECT 1 AS a, "foo" AS b
- """.stripMargin
- )
-
- checkCreateTable("ddl_test")
-}
- }
-
- test("partitioned data source table") {
-withTable("ddl_test") {
- sql(
-s"""CREATE TABLE ddl_test
- |USING json
- |PARTITIONED BY (b)
- |AS SELECT 1 AS a, "foo" AS b
- """.stripMargin
- )
-
- checkCreateTable("ddl_test")
-}
- }
-
- test("bucketed data source table") {
-withTable("ddl_test") {
- sql(
-s"""CREATE TABLE ddl_test
- |USING json
- |CLUSTERED BY (a) SORTED BY (b) INTO 2 BUCKETS
- |AS SELECT 1 AS a, "foo" AS b
- """.stripMargin
- )
-
- checkCreateTable("ddl_test")
-}
- }
-
- test("partitioned bucketed data source table") {
-withTable("ddl_test") {
- sql(
-s"""CREATE TABLE ddl_test
- |USING json
- |PARTITIONED BY (c)
- |CLUSTERED BY (a) SORTED BY (b) INTO 2 BUCKETS
- |AS SELECT 1 AS a, "foo" AS b, 2.5 AS c
- """.stripMargin
- )
-
- checkCreateTable("ddl_test")
-}
- }
-
- test("data source table with a comment") {
-withTable("ddl_test") {
- sql(
-s"""CREATE TABLE ddl_test
- |USING json
- |COMMENT 'This is a comment'
- |AS SELECT 1 AS a, "foo" AS b, 2.5 AS c
- """.stripMargin
- )
-
- checkCreateTable("ddl_test")
-}
- }
-
- test("data source table with table properties") {
-withTable("ddl_test") {
- sql(
-s"""CREATE TABLE ddl_test
- |USING json
- |TBLPROPERTIES ('a' = '1')
- |AS SELECT 1 AS a, "foo" AS b, 2.5 AS c
- """.stripMargin
- )
-
- checkCreateTable("ddl_test")
-}
- }
Review comment:
Merge into one testcase `test("CATS")` in `ShowCreateTableBaseSuite`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34702: [SPARK-37455][SQL] Replace hash with sort aggregate if child is already sorted
AmplabJenkins removed a comment on pull request #34702: URL: https://github.com/apache/spark/pull/34702#issuecomment-979723310 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145649/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34702: [SPARK-37455][SQL] Replace hash with sort aggregate if child is already sorted
SparkQA removed a comment on pull request #34702: URL: https://github.com/apache/spark/pull/34702#issuecomment-979683124 **[Test build #145649 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145649/testReport)** for PR 34702 at commit [`a683137`](https://github.com/apache/spark/commit/a683137de1b6b6ab247f94a0ebf7a41c46ee8c62). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34702: [SPARK-37455][SQL] Replace hash with sort aggregate if child is already sorted
AmplabJenkins commented on pull request #34702: URL: https://github.com/apache/spark/pull/34702#issuecomment-979723310 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145649/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34702: [SPARK-37455][SQL] Replace hash with sort aggregate if child is already sorted
SparkQA commented on pull request #34702: URL: https://github.com/apache/spark/pull/34702#issuecomment-979723157 **[Test build #145649 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145649/testReport)** for PR 34702 at commit [`a683137`](https://github.com/apache/spark/commit/a683137de1b6b6ab247f94a0ebf7a41c46ee8c62). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] Peng-Lei commented on a change in pull request #34719: [SPARK-37381][SQL] Unify v1 and v2 SHOW CREATE TABLE tests
Peng-Lei commented on a change in pull request #34719:
URL: https://github.com/apache/spark/pull/34719#discussion_r757251460
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/ShowCreateTableSuite.scala
##
@@ -1,241 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- *http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.spark.sql
-
-import org.apache.spark.sql.catalyst.TableIdentifier
-import org.apache.spark.sql.catalyst.catalog.CatalogTable
-import org.apache.spark.sql.sources.SimpleInsertSource
-import org.apache.spark.sql.test.{SharedSparkSession, SQLTestUtils}
-import org.apache.spark.util.Utils
-
-class SimpleShowCreateTableSuite extends ShowCreateTableSuite with
SharedSparkSession
-
-abstract class ShowCreateTableSuite extends QueryTest with SQLTestUtils {
- import testImplicits._
-
- test("data source table with user specified schema") {
-withTable("ddl_test") {
- val jsonFilePath =
Utils.getSparkClassLoader.getResource("sample.json").getFile
-
- sql(
-s"""CREATE TABLE ddl_test (
- | a STRING,
- | b STRING,
- | `extra col` ARRAY,
- | `` STRUCT>
- |)
- |USING json
- |OPTIONS (
- | PATH '$jsonFilePath'
- |)
- """.stripMargin
- )
-
- checkCreateTable("ddl_test")
-}
- }
-
- test("data source table CTAS") {
-withTable("ddl_test") {
- sql(
-s"""CREATE TABLE ddl_test
- |USING json
- |AS SELECT 1 AS a, "foo" AS b
- """.stripMargin
- )
-
- checkCreateTable("ddl_test")
-}
- }
-
- test("partitioned data source table") {
-withTable("ddl_test") {
- sql(
-s"""CREATE TABLE ddl_test
- |USING json
- |PARTITIONED BY (b)
- |AS SELECT 1 AS a, "foo" AS b
- """.stripMargin
- )
-
- checkCreateTable("ddl_test")
-}
- }
-
- test("bucketed data source table") {
-withTable("ddl_test") {
- sql(
-s"""CREATE TABLE ddl_test
- |USING json
- |CLUSTERED BY (a) SORTED BY (b) INTO 2 BUCKETS
- |AS SELECT 1 AS a, "foo" AS b
- """.stripMargin
- )
-
- checkCreateTable("ddl_test")
-}
- }
-
- test("partitioned bucketed data source table") {
-withTable("ddl_test") {
- sql(
-s"""CREATE TABLE ddl_test
- |USING json
- |PARTITIONED BY (c)
- |CLUSTERED BY (a) SORTED BY (b) INTO 2 BUCKETS
- |AS SELECT 1 AS a, "foo" AS b, 2.5 AS c
- """.stripMargin
- )
-
- checkCreateTable("ddl_test")
-}
- }
-
- test("data source table with a comment") {
-withTable("ddl_test") {
- sql(
-s"""CREATE TABLE ddl_test
- |USING json
- |COMMENT 'This is a comment'
- |AS SELECT 1 AS a, "foo" AS b, 2.5 AS c
- """.stripMargin
- )
-
- checkCreateTable("ddl_test")
-}
- }
-
- test("data source table with table properties") {
-withTable("ddl_test") {
- sql(
-s"""CREATE TABLE ddl_test
- |USING json
- |TBLPROPERTIES ('a' = '1')
- |AS SELECT 1 AS a, "foo" AS b, 2.5 AS c
- """.stripMargin
- )
-
- checkCreateTable("ddl_test")
-}
- }
Review comment:
Merge into one testcase `test("CATS")` in `v1.ShowCreateTableSuite`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979720733 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50125/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34720: [SPARK-37469][WebUI] unified shuffle read block time to shuffle read fetch wait time in StagePage
AmplabJenkins commented on pull request #34720: URL: https://github.com/apache/spark/pull/34720#issuecomment-979719055 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source
SparkQA commented on pull request #34596: URL: https://github.com/apache/spark/pull/34596#issuecomment-979718731 **[Test build #145658 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145658/testReport)** for PR 34596 at commit [`662460f`](https://github.com/apache/spark/commit/662460f8c8a365d51fc634c1d8cc37e61e7aef08). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] toujours33 opened a new pull request #34720: [SPARK-37469][WebUI] unified shuffle read block time to shuffle read fetch wait time in StagePage
toujours33 opened a new pull request #34720: URL: https://github.com/apache/spark/pull/34720 ### What changes were proposed in this pull request? Change the metrics name `Shuffle Read Block Time` to `Shuffle Read Fetch Wait Time` in StagePage ### Why are the changes needed? `ShuffleReadMetrics._fetchWaitTime` shown as "Shuffle Read Block Time" in Stage page, and "fetch wait time" in the SQL page, which make us confused whether shuffle read includes fetch wait & read Actually `read block time` is just a kind of display name for `fetch wait time`, So we'd better change it in same ### Does this PR introduce _any_ user-facing change? `shuffleReadBlockTime` metric will be changed into `Shuffle Read Fetch Wait Time` in StagePage ### How was this patch tested? Pass GA -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979718612 **[Test build #145657 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145657/testReport)** for PR 34715 at commit [`36fc3fe`](https://github.com/apache/spark/commit/36fc3fe4483179a3c884ff418e1763317c35775b). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
AmplabJenkins removed a comment on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979718074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34718: [SPARK-37460][DOCS] Add the description of ALTER DATABASE SET LOCATION
AmplabJenkins removed a comment on pull request #34718: URL: https://github.com/apache/spark/pull/34718#issuecomment-979718075 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50118/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34718: [SPARK-37460][DOCS] Add the description of ALTER DATABASE SET LOCATION
AmplabJenkins commented on pull request #34718: URL: https://github.com/apache/spark/pull/34718#issuecomment-979718075 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50118/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
AmplabJenkins commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979718076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34719: [SPARK-37381][SQL] Unify v1 and v2 SHOW CREATE TABLE tests
SparkQA commented on pull request #34719: URL: https://github.com/apache/spark/pull/34719#issuecomment-979716499 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50123/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979716442 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50124/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA removed a comment on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979654601 **[Test build #145642 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145642/testReport)** for PR 34715 at commit [`b2b40d5`](https://github.com/apache/spark/commit/b2b40d56fc445386a8928a2c8f1d22f728b00073). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979715522 **[Test build #145642 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145642/testReport)** for PR 34715 at commit [`b2b40d5`](https://github.com/apache/spark/commit/b2b40d56fc445386a8928a2c8f1d22f728b00073). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34719: [SPARK-37381][SQL] Unify v1 and v2 SHOW CREATE TABLE tests
SparkQA commented on pull request #34719: URL: https://github.com/apache/spark/pull/34719#issuecomment-979714836 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50122/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34702: [SPARK-37455][SQL] Replace hash with sort aggregate if child is already sorted
SparkQA commented on pull request #34702: URL: https://github.com/apache/spark/pull/34702#issuecomment-979714259 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50120/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34718: [SPARK-37460][DOCS] Add the description of ALTER DATABASE SET LOCATION
SparkQA commented on pull request #34718: URL: https://github.com/apache/spark/pull/34718#issuecomment-979713631 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50118/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34575: [SPARK-37273][SQL] Support hidden file metadata columns in Spark SQL
SparkQA commented on pull request #34575: URL: https://github.com/apache/spark/pull/34575#issuecomment-979713031 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50121/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979712340 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50119/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] sadikovi commented on pull request #34596: [SPARK-37326][SQL] Support TimestampNTZ in CSV data source
sadikovi commented on pull request #34596: URL: https://github.com/apache/spark/pull/34596#issuecomment-979711191 jenkins retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34716: [SPARK-37468][SQL] Support ANSI intervals and TimestampNTZ for UnionEstimation
AmplabJenkins removed a comment on pull request #34716: URL: https://github.com/apache/spark/pull/34716#issuecomment-979703941 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50115/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34716: [SPARK-37468][SQL] Support ANSI intervals and TimestampNTZ for UnionEstimation
AmplabJenkins commented on pull request #34716: URL: https://github.com/apache/spark/pull/34716#issuecomment-979703941 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50115/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34716: [SPARK-37468][SQL] Support ANSI intervals and TimestampNTZ for UnionEstimation
SparkQA commented on pull request #34716: URL: https://github.com/apache/spark/pull/34716#issuecomment-979703925 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50115/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979703670 **[Test build #145656 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145656/testReport)** for PR 34715 at commit [`f69941e`](https://github.com/apache/spark/commit/f69941e931ec2e3ff0be433db928b4c9ee5bf0a7). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
AmplabJenkins removed a comment on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979703355 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145655/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA removed a comment on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979702461 **[Test build #145655 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145655/testReport)** for PR 34715 at commit [`ed1d0d8`](https://github.com/apache/spark/commit/ed1d0d8dc7c52653571e8b79ebc3a6b4f0695305). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu edited a comment on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
AngersZh edited a comment on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979677759 Should we need to clarify this change in https://spark.apache.org/docs/latest/api/python/getting_started/install.html#manually-downloading ? cc @HyukjinKwon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
AmplabJenkins commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979703355 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145655/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979703340 **[Test build #145655 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145655/testReport)** for PR 34715 at commit [`ed1d0d8`](https://github.com/apache/spark/commit/ed1d0d8dc7c52653571e8b79ebc3a6b4f0695305). * This patch **fails Python style tests**. * This patch merges cleanly. * This patch adds no public classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
AmplabJenkins removed a comment on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979702134 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145654/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979702461 **[Test build #145655 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145655/testReport)** for PR 34715 at commit [`ed1d0d8`](https://github.com/apache/spark/commit/ed1d0d8dc7c52653571e8b79ebc3a6b4f0695305). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
AmplabJenkins commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979702134 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145654/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979702124 **[Test build #145654 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145654/testReport)** for PR 34715 at commit [`08cf8af`](https://github.com/apache/spark/commit/08cf8afd15829a1c37bf63f25a23dfb95ad65e29). * This patch **fails Python style tests**. * This patch merges cleanly. * This patch adds no public classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA removed a comment on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979701395 **[Test build #145654 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145654/testReport)** for PR 34715 at commit [`08cf8af`](https://github.com/apache/spark/commit/08cf8afd15829a1c37bf63f25a23dfb95ad65e29). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979701395 **[Test build #145654 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145654/testReport)** for PR 34715 at commit [`08cf8af`](https://github.com/apache/spark/commit/08cf8afd15829a1c37bf63f25a23dfb95ad65e29). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
AmplabJenkins removed a comment on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979701043 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145653/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA removed a comment on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979700274 **[Test build #145653 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145653/testReport)** for PR 34715 at commit [`7f9b1f0`](https://github.com/apache/spark/commit/7f9b1f020e37faa95d2a36f484d9bc18b7bb0273). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
AmplabJenkins commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979701043 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145653/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979701025 **[Test build #145653 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145653/testReport)** for PR 34715 at commit [`7f9b1f0`](https://github.com/apache/spark/commit/7f9b1f020e37faa95d2a36f484d9bc18b7bb0273). * This patch **fails Python style tests**. * This patch merges cleanly. * This patch adds no public classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979700274 **[Test build #145653 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145653/testReport)** for PR 34715 at commit [`7f9b1f0`](https://github.com/apache/spark/commit/7f9b1f020e37faa95d2a36f484d9bc18b7bb0273). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34719: [SPARK-37381][SQL] Unify v1 and v2 SHOW CREATE TABLE tests
SparkQA commented on pull request #34719: URL: https://github.com/apache/spark/pull/34719#issuecomment-979700216 **[Test build #145652 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145652/testReport)** for PR 34719 at commit [`22356f7`](https://github.com/apache/spark/commit/22356f775deacd193203bd6f50e72de2751f2797). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
AmplabJenkins removed a comment on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979699596 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50113/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34367: [SPARK-37099][SQL] Impl a rank-based filter to optimize top-k computation
AmplabJenkins removed a comment on pull request #34367: URL: https://github.com/apache/spark/pull/34367#issuecomment-979699595 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50116/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
AmplabJenkins removed a comment on pull request #31830: URL: https://github.com/apache/spark/pull/31830#issuecomment-979699594 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50114/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34717: Bump minimum pandas version to 1.0.0
AmplabJenkins removed a comment on pull request #34717: URL: https://github.com/apache/spark/pull/34717#issuecomment-979699593 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50117/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34717: Bump minimum pandas version to 1.0.0
AmplabJenkins commented on pull request #34717: URL: https://github.com/apache/spark/pull/34717#issuecomment-979699593 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50117/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34367: [SPARK-37099][SQL] Impl a rank-based filter to optimize top-k computation
AmplabJenkins commented on pull request #34367: URL: https://github.com/apache/spark/pull/34367#issuecomment-979699595 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50116/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
AmplabJenkins commented on pull request #31830: URL: https://github.com/apache/spark/pull/31830#issuecomment-979699594 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50114/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
AmplabJenkins commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979699596 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50113/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #34710: [SPARK-37461][YARN] YARN-CLIENT mode client.appId is always null
AngersZh commented on pull request #34710: URL: https://github.com/apache/spark/pull/34710#issuecomment-979699477 > @AngersZh Could you describe what you proposes in `What changes were proposed in this pull request?`? `YARN-CLIENT mode client.appId is always null` doesn't describe what you proposes, but what the problem is (maybe, `Why are the changes needed?` needs to be modified together). How about current? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34715: [WIP][SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
SparkQA commented on pull request #34715: URL: https://github.com/apache/spark/pull/34715#issuecomment-979698060 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50119/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31830: [SPARK-34735][SQL][UI] Add modified configs for SQL execution in UI
SparkQA commented on pull request #31830: URL: https://github.com/apache/spark/pull/31830#issuecomment-979697013 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50114/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34717: Bump minimum pandas version to 1.0.0
SparkQA commented on pull request #34717: URL: https://github.com/apache/spark/pull/34717#issuecomment-979696936 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50117/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
