[GitHub] [spark] MichaelChirico commented on pull request #29007: [SPARK-XXXXX][SQL][DOCS] consistency in argument naming for time functions
MichaelChirico commented on pull request #29007: URL: https://github.com/apache/spark/pull/29007#issuecomment-654781966 no, since there are subtle but important differences and the respective APIs are easy to find right alongside one another on the Spark docs website. I can personally assure I read [R](https://spark.apache.org/docs/latest/api/R/) for R reference, [SQL](https://spark.apache.org/docs/latest/api/sql/) for SQL reference, and [Python](https://spark.apache.org/docs/latest/api/python/) for python reference. I also see headings for [Java](https://spark.apache.org/docs/latest/api/java/) and [Scala](https://spark.apache.org/docs/latest/api/scala/) referenced in the [same directory](https://spark.apache.org/docs/latest/api/), but I rarely use those APIs so can't personally say I use them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] MichaelChirico commented on pull request #29007: [SPARK-XXXXX][SQL][DOCS] consistency in argument naming for time functions
MichaelChirico commented on pull request #29007: URL: https://github.com/apache/spark/pull/29007#issuecomment-654710558 Note that this PR only changes the docstrings in the SQL API, AFAIK SQL doesn't support named arguments This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] MichaelChirico commented on pull request #29007: [SPARK-XXXXX][SQL][DOCS] consistency in argument naming for time functions
MichaelChirico commented on pull request #29007: URL: https://github.com/apache/spark/pull/29007#issuecomment-654702101 `fmt` could very clearly not mean any of those things in this context Further, spelled-out `format` is written in the plain-English usage section of every one of these functions so I don't see any scope for confusion. I chose to abbreviate because it was easier for my use case -- `format` has more than one meaning in the documentation (e.g. `DDL format`), so looking for `fmt` made my search more precise -- distinguishing argument names from plain English descriptions This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] MichaelChirico commented on pull request #29007: [SPARK-XXXXX][SQL][DOCS] consistency in argument naming for time functions
MichaelChirico commented on pull request #29007: URL: https://github.com/apache/spark/pull/29007#issuecomment-654292711 > That's all of them? In fact I found one more (in `from_unixtime`). Fixed now. Pattern searched: > `usage[^)]*format` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
