[GitHub] [spark] beliefer commented on pull request #31847: [SPARK-34755][SQL] Support the utils for transform number format
beliefer commented on pull request #31847: URL: https://github.com/apache/spark/pull/31847#issuecomment-1002886939 @cloud-fan Thanks for the review. I will update these change into https://github.com/apache/spark/pull/35060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #31847: [SPARK-34755][SQL] Support the utils for transform number format
beliefer commented on pull request #31847: URL: https://github.com/apache/spark/pull/31847#issuecomment-1002456763 @MaxGekk Thank you for hard work. I will open another PR to implement` to_number` and `to_char`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #31847: [SPARK-34755][SQL] Support the utils for transform number format
beliefer commented on pull request #31847: URL: https://github.com/apache/spark/pull/31847#issuecomment-993113337 > @beliefer Please, update PR's description and add links like in the PR #31448 Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #31847: [SPARK-34755][SQL] Support the utils for transform number format
beliefer commented on pull request #31847: URL: https://github.com/apache/spark/pull/31847#issuecomment-989762118 ping @MaxGekk Could you have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #31847: [SPARK-34755][SQL] Support the utils for transform number format
beliefer commented on pull request #31847: URL: https://github.com/apache/spark/pull/31847#issuecomment-985118890 > @beliefer Could you expose the util functions to Spark SQL via creating expressions and bind them names in `FunctionRegistry` Based on discussion ten months ago, I split the origin [PR](https://github.com/apache/spark/pull/31448). Because the utils should be review better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #31847: [SPARK-34755][SQL] Support the utils for transform number format
beliefer commented on pull request #31847: URL: https://github.com/apache/spark/pull/31847#issuecomment-983199750 ping @MaxGekk cc @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #31847: [SPARK-34755][SQL] Support the utils for transform number format
beliefer commented on pull request #31847: URL: https://github.com/apache/spark/pull/31847#issuecomment-873945468 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #31847: [SPARK-34755][SQL] Support the utils for transform number format
beliefer commented on pull request #31847: URL: https://github.com/apache/spark/pull/31847#issuecomment-873945468 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #31847: [SPARK-34755][SQL] Support the utils for transform number format
beliefer commented on pull request #31847: URL: https://github.com/apache/spark/pull/31847#issuecomment-835387824 ping @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #31847: [SPARK-34755][SQL] Support the utils for transform number format
beliefer commented on pull request #31847: URL: https://github.com/apache/spark/pull/31847#issuecomment-827484986 ping @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #31847: [SPARK-34755][SQL] Support the utils for transform number format
beliefer commented on pull request #31847: URL: https://github.com/apache/spark/pull/31847#issuecomment-822920093 ping @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #31847: [SPARK-34755][SQL] Support the utils for transform number format
beliefer commented on pull request #31847: URL: https://github.com/apache/spark/pull/31847#issuecomment-822321909 Retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #31847: [SPARK-34755][SQL] Support the utils for transform number format
beliefer commented on pull request #31847: URL: https://github.com/apache/spark/pull/31847#issuecomment-803736320 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #31847: [SPARK-34755][SQL] Support the utils for transform number format
beliefer commented on pull request #31847: URL: https://github.com/apache/spark/pull/31847#issuecomment-801747980 ping @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org