[GitHub] spark issue #16676: delete useless var “j”
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16676 Merged to master. Please read http://spark.apache.org/contributing.html for next time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16676: delete useless var “j”
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16676 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16676: delete useless var “j”
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16676 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71927/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16676: delete useless var “j”
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16676 **[Test build #71927 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71927/testReport)** for PR 16676 at commit [`cf8211a`](https://github.com/apache/spark/commit/cf8211a0057b5cc5652414eb96bb453c0e2618fa). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16676: delete useless var “j”
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16676 **[Test build #71927 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71927/testReport)** for PR 16676 at commit [`cf8211a`](https://github.com/apache/spark/commit/cf8211a0057b5cc5652414eb96bb453c0e2618fa). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16676: delete useless var “j”
Github user MLnick commented on the issue: https://github.com/apache/spark/pull/16676 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16676: delete useless var “j”
Github user xiaoyesoso commented on the issue: https://github.com/apache/spark/pull/16676 @srowen Yes, it's my first contribution.Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16676: delete useless var “j”
Github user srowen commented on the issue: https://github.com/apache/spark/pull/16676 @xiaoyesoso we usually do not merge changes this trivial, that have no real impact on the code. I agree it can be removed. It would be helpful if you can look for other unused variables -- IDEs like IntelliJ can do this. We could try to fix many of these at once. If it's your first contribution we often will merge something like this anyway but not regularly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #16676: delete useless var “j”
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16676 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org