[GitHub] spark issue #18836: Update SortMergeJoinExec.scala
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18836 @BoleynSu Sure, I can do it. Will give all the credits to you. Please continue to help us report new issues or fixes. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18836: Update SortMergeJoinExec.scala
Github user BoleynSu commented on the issue: https://github.com/apache/spark/pull/18836 @gatorsmile I am not familiar with the PR process, it is great that you can take it over. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18836: Update SortMergeJoinExec.scala
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18836 @BoleynSu Do you want to continue the PR? or you want us to take it over? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18836: Update SortMergeJoinExec.scala
Github user BoleynSu commented on the issue:
https://github.com/apache/spark/pull/18836
A test case to make the existing code fail.
@srowen I am sorry that this pull request is not well formatted but I just
want to help.
```scala
import org.apache.spark.sql.SparkSession
object Test extends App {
val spark =
SparkSession.builder().master("local").appName("test").getOrCreate()
import spark.sqlContext.implicits._
case class T(i: Int)
spark.sparkContext.parallelize(List(T(1), T(3),
T(3))).toDF.createOrReplaceTempView("T")
val in = "select distinct a.i + 1,a.* from T a cross join T t where a.i >
1 and t.i = a.i group by a.i having a.i > 2"
val sql = spark.sql(in)
sql.queryExecution.executedPlan.children.map { x =>
x.children.map { x =>
x.children.map { x =>
x.children.map { x =>
x.children.map { x =>
x.children.map { x =>
println(x.outputOrdering)
}
}
}
}
}
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18836: Update SortMergeJoinExec.scala
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18836 Thanks for fixing this. Please follow the contribution guideline. Also, you need to add a test case. You can follow what we did in this PR: https://github.com/apache/spark/pull/17339 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18836: Update SortMergeJoinExec.scala
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/18836 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #18836: Update SortMergeJoinExec.scala
Github user srowen commented on the issue: https://github.com/apache/spark/pull/18836 You didn't read the link above, I take it? http://spark.apache.org/contributing.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
