[GitHub] spark issue #19126: [SPARK-21915][ML][PySpark]Model 1 and Model 2 ParamMaps ...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19126 No, no change has been made. @BryanCutler suggests that the change isn't needed in `master` but could be applied to `branch-2.2`. To do that you need to reopen a new PR against that branch. It still wouldn't make any existing docs update, but would affect the next release and its docs. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19126: [SPARK-21915][ML][PySpark]Model 1 and Model 2 ParamMaps ...
Github user marktab commented on the issue: https://github.com/apache/spark/pull/19126 @srowen since I am a new to this review process, should I be seeing the change at http://spark.apache.org/docs/latest/ml-pipeline.html --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19126: [SPARK-21915][ML][PySpark]Model 1 and Model 2 ParamMaps ...
Github user marktab commented on the issue: https://github.com/apache/spark/pull/19126 Thanks @srowen --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19126: [SPARK-21915][ML][PySpark]Model 1 and Model 2 ParamMaps ...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/19126 @marktab you can either close this or reopen vs branch-2.2 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19126: [SPARK-21915][ML][PySpark]Model 1 and Model 2 ParamMaps ...
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/19126 Yeah, I checked and this is not a problem in master since #17849 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19126: [SPARK-21915][ML][PySpark]Model 1 and Model 2 ParamMaps ...
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/19126 So I'm wondering if @BryanCutler's change for copying the params means that this should only be applied to old branches (2.2)? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19126: [SPARK-21915][ML][PySpark]Model 1 and Model 2 ParamMaps ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19126 **[Test build #81413 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81413/testReport)** for PR 19126 at commit [`76e5da7`](https://github.com/apache/spark/commit/76e5da7b14d71338cf82352e9cf5628640e732a2). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19126: [SPARK-21915][ML][PySpark]Model 1 and Model 2 ParamMaps ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19126 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81413/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19126: [SPARK-21915][ML][PySpark]Model 1 and Model 2 ParamMaps ...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19126 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19126: [SPARK-21915][ML][PySpark]Model 1 and Model 2 ParamMaps ...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19126 **[Test build #81413 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81413/testReport)** for PR 19126 at commit [`76e5da7`](https://github.com/apache/spark/commit/76e5da7b14d71338cf82352e9cf5628640e732a2). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19126: [SPARK-21915][ML][PySpark]Model 1 and Model 2 ParamMaps ...
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/19126 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
