[GitHub] spark issue #19238: [SPARK-22016][SQL] Add HiveDialect for JDBC connection t...

2018-06-19 Thread paulstaab
Github user paulstaab commented on the issue:

https://github.com/apache/spark/pull/19238
  
This merge request would partly solve 
https://issues.apache.org/jira/browse/SPARK-21063


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19238: [SPARK-22016][SQL] Add HiveDialect for JDBC connection t...

2017-09-18 Thread danielfx90
Github user danielfx90 commented on the issue:

https://github.com/apache/spark/pull/19238
  
Seems logical. Then, unless someone disagrees, feel free to close this PR 
and we will create a new spark package with this feature in a new repository.

Thanks!


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19238: [SPARK-22016][SQL] Add HiveDialect for JDBC connection t...

2017-09-18 Thread gatorsmile
Github user gatorsmile commented on the issue:

https://github.com/apache/spark/pull/19238
  
I can see the value, but it does not perform well in most cases if we using 
JDBC connection. Instead of adding the extra dialect to upstream, could you 
please add Hive as a separate data source? Thanks!

https://spark.apache.org/third-party-projects.html


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19238: [SPARK-22016][SQL] Add HiveDialect for JDBC connection t...

2017-09-15 Thread danielfx90
Github user danielfx90 commented on the issue:

https://github.com/apache/spark/pull/19238
  
@gatorsmile if Hive lies on the same infrastructure as the application, 
then the metastore should definitely solve the issue, but a connection over 
JDBC is needed when data comes from an external source which **only** exposes 
such a connection through its Hive server. We encountered this and ended up 
adding the HiveDialect to solve it.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19238: [SPARK-22016][SQL] Add HiveDialect for JDBC connection t...

2017-09-14 Thread gatorsmile
Github user gatorsmile commented on the issue:

https://github.com/apache/spark/pull/19238
  
Why not directly connecting to Hive metastore?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #19238: [SPARK-22016][SQL] Add HiveDialect for JDBC connection t...

2017-09-14 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/19238
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org