[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19321 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82140/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19321 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19321 **[Test build #82140 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82140/testReport)** for PR 19321 at commit [`1d26f50`](https://github.com/apache/spark/commit/1d26f501c6e9870969f5312b2a91b05c7e97cef3). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19321 Please update the PR title and description. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19321 **[Test build #82140 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82140/testReport)** for PR 19321 at commit [`1d26f50`](https://github.com/apache/spark/commit/1d26f501c6e9870969f5312b2a91b05c7e97cef3). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/19321 Could you document the change in the output type of `percentile_approx ` in the following section? https://spark.apache.org/docs/latest/sql-programming-guide.html#migration-guide --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/19321 That's a good point, thanks --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19321 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82108/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19321 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19321 **[Test build #82108 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82108/testReport)** for PR 19321 at commit [`0d34053`](https://github.com/apache/spark/commit/0d34053f36b9f03bf3d5cf6ca1b3c13b348d24cb). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/19321 @felixcheung For percentiles, I think the type of results should be the same as input data type. In these tests, the type of data is int, so actually `30` is more accurate than `30.0`. The previous answer is `30.0` because `ApproximatePercentile` only accepts double input type and outputs double results before this PR. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19321 **[Test build #82108 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82108/testReport)** for PR 19321 at commit [`0d34053`](https://github.com/apache/spark/commit/0d34053f36b9f03bf3d5cf6ca1b3c13b348d24cb). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19321 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19321 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82101/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19321 **[Test build #82101 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82101/testReport)** for PR 19321 at commit [`45e655f`](https://github.com/apache/spark/commit/45e655f14f9beed6bc6bc584b73619ba46a51c43). * This patch **fails SparkR unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19321 **[Test build #82101 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82101/testReport)** for PR 19321 at commit [`45e655f`](https://github.com/apache/spark/commit/45e655f14f9beed6bc6bc584b73619ba46a51c43). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19321 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82099/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19321 **[Test build #82099 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82099/testReport)** for PR 19321 at commit [`db2c110`](https://github.com/apache/spark/commit/db2c11056cf973708b10b5e5fdcd8ec705e27d21). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19321 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19321 **[Test build #82099 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82099/testReport)** for PR 19321 at commit [`db2c110`](https://github.com/apache/spark/commit/db2c11056cf973708b10b5e5fdcd8ec705e27d21). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19321 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82073/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19321 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19321 **[Test build #82073 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82073/testReport)** for PR 19321 at commit [`958715b`](https://github.com/apache/spark/commit/958715b54d36d4bd5875c53ec59d71e4cd22cade). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user wzhfy commented on the issue: https://github.com/apache/spark/pull/19321 cc @cloud-fan @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #19321: [SPARK-22100] [SQL] Make percentile_approx support numer...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19321 **[Test build #82073 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/82073/testReport)** for PR 19321 at commit [`958715b`](https://github.com/apache/spark/commit/958715b54d36d4bd5875c53ec59d71e4cd22cade). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
