[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-24 Thread Lemonjing
Github user Lemonjing commented on the issue:

https://github.com/apache/spark/pull/20889
  
@felixcheung thanks a lot. and i closed it.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-24 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/spark/pull/20889
  
@Lemonjing you need to close the PR from github.com - we don't have access 
to close it


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-23 Thread Lemonjing
Github user Lemonjing commented on the issue:

https://github.com/apache/spark/pull/20889
  
can someone help me to close this pr?  i have merged these commits to a new 
pr.
https://github.com/apache/spark/pull/20897


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-23 Thread Lemonjing
Github user Lemonjing commented on the issue:

https://github.com/apache/spark/pull/20889
  
@HyukjinKwon Thanks a lot, could u help me to review these commits if u 
have time。


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/20889
  
I think you can add all other typos into here.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-23 Thread Lemonjing
Github user Lemonjing commented on the issue:

https://github.com/apache/spark/pull/20889
  
@felixcheung hi,In my reading process,I found another md file typos and 
fix it. Do I need to close this pr and merge it into one commit and give a new 
pr?  Thanks.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-23 Thread Lemonjing
Github user Lemonjing commented on the issue:

https://github.com/apache/spark/pull/20889
  
@felixcheung Yes, I read the entire docs of Spark Mlib. There is no problem 
with other mds (I may not have seen it or other contributors solved it). This 
error is obvious, and it affects the link of the later issue, so i found it.
[http://spark.apache.org/docs/latest/ml-guide.html#breaking-changes](url)


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-23 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/spark/pull/20889
  
can you check if we have other typo in the md file?
or similar type of typo in other md files?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20889
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20889: [MINOR][DOC] Fix ml-guide markdown typos

2018-03-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20889
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org