[GitHub] spark issue #20899: Bug fix in sendMessage() of pregel implementation in Pag...

2018-10-31 Thread WenqianZhao
Github user WenqianZhao commented on the issue:

https://github.com/apache/spark/pull/20899
  
> @WenqianZhao I think the point of sending deltas instead of absolute 
ranks was that, as parts of the graph converge, their deltas would go to zero. 
GraphX would then be able to compress those zero messages more efficiently.

Got it! Thank you!


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20899: Bug fix in sendMessage() of pregel implementation in Pag...

2018-10-31 Thread ankurdave
Github user ankurdave commented on the issue:

https://github.com/apache/spark/pull/20899
  
@WenqianZhao I think the point of sending deltas instead of absolute ranks 
was that, as parts of the graph converge, their deltas would go to zero. GraphX 
would then be able to stop sending those messages.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20899: Bug fix in sendMessage() of pregel implementation in Pag...

2018-10-31 Thread WenqianZhao
Github user WenqianZhao commented on the issue:

https://github.com/apache/spark/pull/20899
  
By the way, @ankurdave , hi, I'm very curious about why you use delta 
instead of just newPR as the message. Is that for better performance or just at 
chance? Could you please answer this question when you are free? Thank you so 
much.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20899: Bug fix in sendMessage() of pregel implementation in Pag...

2018-10-31 Thread WenqianZhao
Github user WenqianZhao commented on the issue:

https://github.com/apache/spark/pull/20899
  
You can check the 
[comment](https://github.com/apache/spark/pull/2100#issuecomment-53311125) in 
pull request [#2100](https://github.com/apache/spark/pull/2100).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20899: Bug fix in sendMessage() of pregel implementation in Pag...

2018-06-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20899
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20899: Bug fix in sendMessage() of pregel implementation in Pag...

2018-06-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20899
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #20899: Bug fix in sendMessage() of pregel implementation in Pag...

2018-03-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/20899
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org