[GitHub] spark issue #21057: [MINOR][PYTHON] 2 Improvements to Pyspark docs

[viirya]

Github user viirya commented on the issue:

https://github.com/apache/spark/pull/21057
  
:-)


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21057: [MINOR][PYTHON] 2 Improvements to Pyspark docs

[HyukjinKwon]

Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/21057
  
( I regret I happened to come over form Korea to Singapore too fast before 
your flight :-) )


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21057: [MINOR][PYTHON] 2 Improvements to Pyspark docs

[HyukjinKwon]

Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/21057
  
It's not urgent at all. I would appreciate it.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21057: [MINOR][PYTHON] 2 Improvements to Pyspark docs

[viirya]

Github user viirya commented on the issue:

https://github.com/apache/spark/pull/21057
  
I will flight to Korea for a company workshop today. I can do this maybe
only in at tonight. If this isn't urgent, then it is okay.

On Wed, Apr 18, 2018, 10:03 AM Hyukjin Kwon 
wrote:

> Actually @viirya , would you be interested in
> this if you are available? I will do this by myself but I am currently not
> quite available. If you are busy too, let me try it anyway.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21057: [MINOR][PYTHON] 2 Improvements to Pyspark docs

[HyukjinKwon]

Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/21057
  
Actually @viirya, would you be interested in this if you are available? I 
will do this by myself but I am currently not quite available. If you are busy 
too, let me try it anyway.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21057: [MINOR][PYTHON] 2 Improvements to Pyspark docs

[HyukjinKwon]

Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/21057
  
Right, let me try to cherry-pick and see if I can write a test. Will try to 
have some time and open a PR after cherry-picking your commit. I think you can 
close this PR. 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21057: [MINOR][PYTHON] 2 Improvements to Pyspark docs

[aviv-ebates]

Github user aviv-ebates commented on the issue:

https://github.com/apache/spark/pull/21057
  
If you're not clear about what I've done here, ask away. I don't wish to 
create a jira account in addition; Feel free to create whatever tickets you 
think are required.
I've already paid my price for this particular deficiency in Spark 
documentation, so I don't need this docfix for myself. I was hoping you'd like 
to improve the docs, so that the next guy would have an easier experience using 
Spark/Pyspark, but that's totally up to you.
I think I've done all that is reasonable to do for this documents 
improvements for your project. If you want this change, merge it in; If you 
don't, don't. 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21057: [MINOR][PYTHON] 2 Improvements to Pyspark docs

[HyukjinKwon]

Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/21057
  
It would be helpful if you open a JIRA and describe the issue. It could 
help other guys think a better way to test or would give clearer ideas to see 
if it's really difficult to add a test. Usually, JIRA is made first. See also 
https://spark.apache.org/contributing.html.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21057: [MINOR][PYTHON] 2 Improvements to Pyspark docs

[aviv-ebates]

Github user aviv-ebates commented on the issue:

https://github.com/apache/spark/pull/21057
  
1. Updated title
2. Updated text to one suggested by @HyukjinKwon 
3. I don't have a reasonable way to make a test. Test scenario is 
"Configure pythong listener, run actual spark streaming". If you have a way to 
test that,  that would be great; I don't know how to set up this test.
4. Feel free to create a ticket and update commit messages when you merge 
this.
5. I consider this a documentation change, because the method is already 
**available and required**; All I did is make sure it shows up in documentation 
(and incidentally, make it not-required). Feel free to change commit messages 
and pr text to reflect your understanding of this change.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21057: [MINOR][PYTHON] 2 Improvements to Pyspark docs

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21057
  
Merged build finished. Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21057: [MINOR][PYTHON] 2 Improvements to Pyspark docs

[AmplabJenkins]

Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21057
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89399/
Test FAILed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21057: [MINOR][PYTHON] 2 Improvements to Pyspark docs

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21057
  
**[Test build #89399 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89399/testReport)**
 for PR 21057 at commit 
[`010de10`](https://github.com/apache/spark/commit/010de10544ca97ff57032d25961ff340aa1384e1).
 * This patch **fails Python style tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21057: [MINOR][PYTHON] 2 Improvements to Pyspark docs

[SparkQA]

Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/21057
  
**[Test build #89399 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89399/testReport)**
 for PR 21057 at commit 
[`010de10`](https://github.com/apache/spark/commit/010de10544ca97ff57032d25961ff340aa1384e1).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org