[GitHub] spark issue #21597: [SPARK-24603] Fix findTightestCommonType reference in co...

2018-06-20 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/21597
  
@Fokko, thanks for bearing with it. (see also 
https://spark.apache.org/contributing.html).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21597: [SPARK-24603] Fix findTightestCommonType reference in co...

2018-06-20 Thread Fokko
Github user Fokko commented on the issue:

https://github.com/apache/spark/pull/21597
  
@HyukjinKwon Ok, some Apache projects are really strict with the Jira 
tickets.

@maropu I've updated the commit


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21597: [SPARK-24603] Fix findTightestCommonType reference in co...

2018-06-20 Thread maropu
Github user maropu commented on the issue:

https://github.com/apache/spark/pull/21597
  
nitpicking though... plz add `[SQL]` in the title, `[SPARK-24603][SQL] Fix`


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21597: [SPARK-24603] Fix findTightestCommonType reference in co...

2018-06-20 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/21597
  
BTW, typo change doesn't need a JIRA. Let's avoid next time.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21597: [SPARK-24603] Fix findTightestCommonType reference in co...

2018-06-20 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/21597
  
It's okay but mind taking another look and see if there are some typos 
while we are here? I am pretty sure there are more and it should be good to 
catch them in batch while we are here.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21597: [SPARK-24603] Fix findTightestCommonType reference in co...

2018-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21597
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21597: [SPARK-24603] Fix findTightestCommonType reference in co...

2018-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21597
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #21597: [SPARK-24603] Fix findTightestCommonType reference in co...

2018-06-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/21597
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org