[GitHub] spark issue #22522: [SPARK-25510][TEST] Create new trait replace BenchmarkWi...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22522
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96783/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22522: [SPARK-25510][TEST] Create new trait replace BenchmarkWi...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22522
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22522: [SPARK-25510][TEST] Create new trait replace BenchmarkWi...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22522
  
**[Test build #96783 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96783/testReport)**
 for PR 22522 at commit 
[`20668ad`](https://github.com/apache/spark/commit/20668adc843815e97b3d1950ed2ab86bdb66540f).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:
  * `trait SqlBasedBenchmark extends BenchmarkBase with SQLHelper `


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22522: [SPARK-25510][TEST] Create new trait replace BenchmarkWi...

2018-09-28 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22522
  
**[Test build #96783 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96783/testReport)**
 for PR 22522 at commit 
[`20668ad`](https://github.com/apache/spark/commit/20668adc843815e97b3d1950ed2ab86bdb66540f).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22522: [SPARK-25510][TEST] Create new trait replace BenchmarkWi...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22522
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3584/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22522: [SPARK-25510][TEST] Create new trait replace BenchmarkWi...

2018-09-28 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22522
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22522: [SPARK-25510][TEST] Create new trait replace BenchmarkWi...

2018-09-28 Thread wangyum
Github user wangyum commented on the issue:

https://github.com/apache/spark/pull/22522
  
cc @dongjoon-hyun


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22522: [SPARK-25510][TEST] Create new trait replace BenchmarkWi...

2018-09-22 Thread gengliangwang
Github user gengliangwang commented on the issue:

https://github.com/apache/spark/pull/22522
  
@wangyum I have left my comment in 
https://github.com/apache/spark/pull/22484 .
Also, should we close this one and move to 
https://github.com/apache/spark/pull/22484 ?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22522: [SPARK-25510][TEST] Create new trait replace BenchmarkWi...

2018-09-22 Thread wangyum
Github user wangyum commented on the issue:

https://github.com/apache/spark/pull/22522
  
Thanks @cloud-fan I have migrate 
[`AggregateBenchmark`](https://github.com/apache/spark/pull/22484/files) to use 
new trait.
 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22522: [SPARK-25510][TEST] Create new trait replace BenchmarkWi...

2018-09-22 Thread cloud-fan
Github user cloud-fan commented on the issue:

https://github.com/apache/spark/pull/22522
  
I think this change is necessary, but I'd like to migrate one benchmark to 
use this new trait as an example. We can migrate others in follow up PRs.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22522: [SPARK-25510][TEST] Create new trait replace BenchmarkWi...

2018-09-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22522
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96452/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22522: [SPARK-25510][TEST] Create new trait replace BenchmarkWi...

2018-09-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22522
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22522: [SPARK-25510][TEST] Create new trait replace BenchmarkWi...

2018-09-21 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22522
  
**[Test build #96452 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96452/testReport)**
 for PR 22522 at commit 
[`275cc6c`](https://github.com/apache/spark/commit/275cc6c5f8f106eb339c7ed01734e279a223705e).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22522: [SPARK-25510][TEST] Create new trait replace BenchmarkWi...

2018-09-21 Thread wangyum
Github user wangyum commented on the issue:

https://github.com/apache/spark/pull/22522
  
cc @cloud-fan @gengliangwang  @dongjoon-hyun


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22522: [SPARK-25510][TEST] Create new trait replace BenchmarkWi...

2018-09-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22522
  
Merged build finished. Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22522: [SPARK-25510][TEST] Create new trait replace BenchmarkWi...

2018-09-21 Thread SparkQA
Github user SparkQA commented on the issue:

https://github.com/apache/spark/pull/22522
  
**[Test build #96452 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96452/testReport)**
 for PR 22522 at commit 
[`275cc6c`](https://github.com/apache/spark/commit/275cc6c5f8f106eb339c7ed01734e279a223705e).


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22522: [SPARK-25510][TEST] Create new trait replace BenchmarkWi...

2018-09-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22522
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 

https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3361/
Test PASSed.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org