[GitHub] spark issue #22840: [SPARK-25840][BUILD] `make-distribution.sh` should not f...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22840 Oops. My bad. I'll monitor the branch. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22840: [SPARK-25840][BUILD] `make-distribution.sh` should not f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22840 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22840: [SPARK-25840][BUILD] `make-distribution.sh` should not f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22840 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98051/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22840: [SPARK-25840][BUILD] `make-distribution.sh` should not f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22840 **[Test build #98051 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98051/testReport)** for PR 22840 at commit [`0950bb8`](https://github.com/apache/spark/commit/0950bb86ac028655c665687398c7dcfce1853f04). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22840: [SPARK-25840][BUILD] `make-distribution.sh` should not f...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22840 Thank you, @srowen and @HyukjinKwon . Merged to master/branch-2.4. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22840: [SPARK-25840][BUILD] `make-distribution.sh` should not f...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22840 Yeah ... I read that as being about the source tree from the repo. But it does say only "... like the ones distributed by the project". OK I think this is fine, for 2.4. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22840: [SPARK-25840][BUILD] `make-distribution.sh` should not f...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22840 @srowen . It's a documented feature. - http://spark.apache.org/docs/latest/building-spark.html#building-a-runnable-distribution I know that you're not against it, but Spark 2.4.0 had better respect the document. Are we going to document it; From Spark 2.4.0 source distribution, we cannot build it from the source.? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22840: [SPARK-25840][BUILD] `make-distribution.sh` should not f...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22840 Hm, I'm not dead-set against it, though it seems a little deceptive; you won't actually get the exact binary distro out, and that's what the script purports to do. (Arguably, why do we bundle the script then?) Is it needed to test the source release? I'd expect we compile and run tests, as those are the things that are meant to work from the source release. I'm not against it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22840: [SPARK-25840][BUILD] `make-distribution.sh` should not f...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22840 I noted that this doesn't aim to reproduce the provided binary release. This aims to help individual contributor participate to test the source artifacts during voting phase. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22840: [SPARK-25840][BUILD] `make-distribution.sh` should not f...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22840 Hm, but then you haven't created a completely valid binary release; it's missing licenses. As I say, I don't know that the binary release tarball must be exactly recreatable from the source artifact. The compiled bits? yes, must be exactly recreateable, and they are as far as I know --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22840: [SPARK-25840][BUILD] `make-distribution.sh` should not f...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22840 **[Test build #98051 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98051/testReport)** for PR 22840 at commit [`0950bb8`](https://github.com/apache/spark/commit/0950bb86ac028655c665687398c7dcfce1853f04). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22840: [SPARK-25840][BUILD] `make-distribution.sh` should not f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22840 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22840: [SPARK-25840][BUILD] `make-distribution.sh` should not f...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22840 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4506/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22840: [SPARK-25840][BUILD] `make-distribution.sh` should not f...
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22840 cc @srowen --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
