[GitHub] spark issue #22855: [SPARK-25839] [Core] Implement use of KryoPool in KryoSe...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22855 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22855: [SPARK-25839] [Core] Implement use of KryoPool in KryoSe...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22855 **[Test build #4421 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4421/testReport)** for PR 22855 at commit [`3bfc4eb`](https://github.com/apache/spark/commit/3bfc4ebbf214b6b0fadbaa10aa832303a59de97d). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22855: [SPARK-25839] [Core] Implement use of KryoPool in KryoSe...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22855 **[Test build #4421 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4421/testReport)** for PR 22855 at commit [`3bfc4eb`](https://github.com/apache/spark/commit/3bfc4ebbf214b6b0fadbaa10aa832303a59de97d). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22855: [SPARK-25839] [Core] Implement use of KryoPool in KryoSe...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22855 **[Test build #4418 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4418/testReport)** for PR 22855 at commit [`3c00321`](https://github.com/apache/spark/commit/3c00321b6156b8673f5d81f859a3b092266f0181). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22855: [SPARK-25839] [Core] Implement use of KryoPool in KryoSe...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22855 **[Test build #4417 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4417/testReport)** for PR 22855 at commit [`60310c0`](https://github.com/apache/spark/commit/60310c0e18613f0c32f19b73e6ac25a49ba25e86). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22855: [SPARK-25839] [Core] Implement use of KryoPool in KryoSe...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22855 **[Test build #4417 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4417/testReport)** for PR 22855 at commit [`60310c0`](https://github.com/apache/spark/commit/60310c0e18613f0c32f19b73e6ac25a49ba25e86). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22855: [SPARK-25839] [Core] Implement use of KryoPool in KryoSe...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22855 **[Test build #4415 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4415/testReport)** for PR 22855 at commit [`9069768`](https://github.com/apache/spark/commit/90697681ea39943b130977d7687757ce6a4db722). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22855: [SPARK-25839] [Core] Implement use of KryoPool in KryoSe...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22855 **[Test build #4415 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4415/testReport)** for PR 22855 at commit [`9069768`](https://github.com/apache/spark/commit/90697681ea39943b130977d7687757ce6a4db722). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22855: [SPARK-25839] [Core] Implement use of KryoPool in KryoSe...
Github user patrickbrownsync commented on the issue: https://github.com/apache/spark/pull/22855 @srowen I went ahead and fixed those issues where I could find them, mostly for my own learning experience. Thanks for taking the time to review this many times, really appreciate it --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22855: [SPARK-25839] [Core] Implement use of KryoPool in KryoSe...
Github user patrickbrownsync commented on the issue: https://github.com/apache/spark/pull/22855 @srowen should be fixed now, I rebased off master and changed KryoSerializerBenchmark to conform to how BenchmarkBase had changed on master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22855: [SPARK-25839] [Core] Implement use of KryoPool in KryoSe...
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22855 Ping @patrickbrownsync -- with this fixed I think we can merge it --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22855: [SPARK-25839] [Core] Implement use of KryoPool in KryoSe...
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/22855
Oops, something to do with the benchmark class:
```
[error]
/home/jenkins/workspace/NewSparkPullRequestBuilder/core/src/test/scala/org/apache/spark/serializer/KryoSerializerBenchmark.scala:41:
object creation impossible, since method runBenchmarkSuite in class
BenchmarkBase of type (mainArgs: Array[String])Unit is not defined
[error] object KryoSerializerBenchmark extends BenchmarkBase {
[error]^
[error]
/home/jenkins/workspace/NewSparkPullRequestBuilder/core/src/test/scala/org/apache/spark/serializer/KryoSerializerBenchmark.scala:45:
method runBenchmarkSuite overrides nothing.
[error] Note: the super classes of object KryoSerializerBenchmark contain
the following, non final members named runBenchmarkSuite:
[error] def runBenchmarkSuite(mainArgs: Array[String]): Unit
[error] override def runBenchmarkSuite(): Unit = {
[error]^
```
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22855: [SPARK-25839] [Core] Implement use of KryoPool in KryoSe...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22855 **[Test build #4410 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4410/testReport)** for PR 22855 at commit [`3433622`](https://github.com/apache/spark/commit/3433622d92957607ca3a4f83f199f86f52077627). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22855: [SPARK-25839] [Core] Implement use of KryoPool in KryoSe...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22855 **[Test build #4410 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4410/testReport)** for PR 22855 at commit [`3433622`](https://github.com/apache/spark/commit/3433622d92957607ca3a4f83f199f86f52077627). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22855: [SPARK-25839] [Core] Implement use of KryoPool in KryoSe...
Github user patrickbrownsync commented on the issue: https://github.com/apache/spark/pull/22855 @srowen Thanks for taking the time to give me feedback! I'll get this stuff fixed --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22855: [SPARK-25839] [Core] Implement use of KryoPool in KryoSe...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22855 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22855: [SPARK-25839] [Core] Implement use of KryoPool in KryoSe...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22855 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22855: [SPARK-25839] [Core] Implement use of KryoPool in KryoSe...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22855 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
