[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22989 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22989 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4962/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22989 `AssertionError` in tests is wrong. It should really just call `fail()`. If you're willing to fix that, it would be a great cleanup. The `AssertionError` in UnsafeAlignedOffset is legitimate and can be excluded. I would fix the `AssertionError` in KafkaUtils. That one is clearly an illegal argument check. Agree about the rest. Thanks for the great analysis @xuanyuanking --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22989 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22989 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98731/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22989 **[Test build #98731 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98731/testReport)** for PR 22989 at commit [`6e49bb8`](https://github.com/apache/spark/commit/6e49bb8cca201237a7871b22f178609319a0fdce). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22989 **[Test build #98731 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98731/testReport)** for PR 22989 at commit [`6e49bb8`](https://github.com/apache/spark/commit/6e49bb8cca201237a7871b22f178609319a0fdce). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22989 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4952/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22989 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user xuanyuanking commented on the issue: https://github.com/apache/spark/pull/22989 cc all reviewer, as @srowen's suggestion, add a rule to ban all of new Error cases. List currently `throw new XXXError` in Spark source below and record fix up or exclude for review conveniently: ErrorName | Count | In Test/Source Code | Fix Up or Exclude | - | - | - AssertionError | 32 | 29 in test code | Exclude | | | 2 in UnsafeAlignedOffset | Fix up by changing them to `IllegalArgumentException` | | | 1 in KafkaUtils | Just exclude cause fix it will cause behavior change NotImplementedError | 22 | 7 in source code/ 15 in test cases | Fix up by changing them to `UnsupportedOperationException` OutOfMemoryError | 1 | 1 in test code | Exclude LinkageError | 1 | 1 in test code | Exclude SparkOutOfMemoryError | 5 | 5 in source code | Exclude UnknownError | 9 | 5 in source code/ 4 in test cases | Fix up by changing to `IllegalAccessException ` and `IllegalArgumentException` All above done in 6e49bb8. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user xuanyuanking commented on the issue: https://github.com/apache/spark/pull/22989 Sorry for late reply, great thanks for all reviewer's advise, will address them soon. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/22989 and catching Error or Throwable.. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22989 Honestly it is bad style to throw any Error class, except in sepcial situations. I'd prefer a rule banning all of these and fix up any instances in the code or else exclude them --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22989 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22989 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98649/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22989 **[Test build #98649 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98649/testReport)** for PR 22989 at commit [`d678751`](https://github.com/apache/spark/commit/d67875115f622082519b1dbcb1c1e34c2184b34f). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22989 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4886/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22989 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22989 **[Test build #98649 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98649/testReport)** for PR 22989 at commit [`d678751`](https://github.com/apache/spark/commit/d67875115f622082519b1dbcb1c1e34c2184b34f). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user xuanyuanking commented on the issue: https://github.com/apache/spark/pull/22989 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22989 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98637/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22989 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22989 **[Test build #98637 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98637/testReport)** for PR 22989 at commit [`d678751`](https://github.com/apache/spark/commit/d67875115f622082519b1dbcb1c1e34c2184b34f). * This patch **fails due to an unknown error code, -9**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22989 **[Test build #98637 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98637/testReport)** for PR 22989 at commit [`d678751`](https://github.com/apache/spark/commit/d67875115f622082519b1dbcb1c1e34c2184b34f). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22989 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22989: [SPARK-25986][Build] Banning throw new OutOfMemoryErrors
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22989 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4877/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
