[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/9826


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[mengxr]

Github user mengxr commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158858659
  
LGTM. Merged into master and branch-1.6. Thanks! (The Jenkins test failure 
is irrelevant. The PR build doesn't compile doc anyway. So I verified the 
changes on my local computer.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[thunterdb]

Github user thunterdb commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158541369
  
@mengxr comment addressed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-15855
  
**[Test build #46457 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46457/consoleFull)**
 for PR 9826 at commit 
[`0350265`](https://github.com/apache/spark/commit/0350265a487cac0046f06b58daac0495ddf635a2).
 * This patch **fails Spark unit tests**.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158566695
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158566697
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46457/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158544511
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46447/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158544509
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158551115
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46448/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158551112
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[mengxr]

Github user mengxr commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158545655
  
test this please 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[mengxr]

Github user mengxr commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158553130
  
test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158555643
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46452/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158555642
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[mengxr]

Github user mengxr commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158562807
  
test this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158563254
  
**[Test build #46457 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46457/consoleFull)**
 for PR 9826 at commit 
[`0350265`](https://github.com/apache/spark/commit/0350265a487cac0046f06b58daac0495ddf635a2).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158177674
  
**[Test build #46343 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46343/consoleFull)**
 for PR 9826 at commit 
[`c8a7cb2`](https://github.com/apache/spark/commit/c8a7cb2cd5f5d207605d38e9eb042be293e1a291).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158178053
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158178060
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46343/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[thunterdb]

Github user thunterdb commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158169615
  
@mengxr with the fixes, the top menu breaks before the side menu :-)
![screen shot 2015-11-19 at 11 30 13 
am](https://cloud.githubusercontent.com/assets/7594753/11281827/454f62dc-8eb1-11e5-80a8-c7b66887d193.png)
![screen shot 2015-11-19 at 11 30 25 
am](https://cloud.githubusercontent.com/assets/7594753/11281831/47d78b88-8eb1-11e5-8928-6a3a016dfa8e.png)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[thunterdb]

Github user thunterdb commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158169959
  
This is about as much as I can do with my very limited knowledge of CSS, so 
additional fixes can be done in a separate PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158172384
  
**[Test build #46343 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46343/consoleFull)**
 for PR 9826 at commit 
[`c8a7cb2`](https://github.com/apache/spark/commit/c8a7cb2cd5f5d207605d38e9eb042be293e1a291).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[thunterdb]

Github user thunterdb commented on a diff in the pull request:

https://github.com/apache/spark/pull/9826#discussion_r45381998
  
--- Diff: docs/_includes/nav-left-wrapper-ml.html ---
@@ -0,0 +1,6 @@
+
+ML
--- End diff --

sure


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158232920
  
Test FAILed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46367/
Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158232917
  
Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[andrewor14]

Github user andrewor14 commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158206117
  
nice! I wonder if there's something more general we can do. This is useful 
across all pages in the docs so it would be worth investigating if there are 
existing frameworks we can use. E.g. this format is nice: 
http://docs.scala-lang.org/overviews/core/futures.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[thunterdb]

Github user thunterdb commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158229760
  
@mengxr based on our discussions, here is a slightly updated version:
 - menu is fixed
 - menu disappears under the page (but it looks half covered in the 
middle). Fixing that would require JS, I think (and sk-learn does not have a 
fixed menu):

![screen shot 2015-11-19 at 3 10 50 
pm](https://cloud.githubusercontent.com/assets/7594753/11287386/efb9686c-8ecf-11e5-9829-038f22468ad9.png)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[thunterdb]

Github user thunterdb commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158220169
  
@andrewor14 this is a different issue: the SIPs show the table of contents 
within one document, which we already have with the `{:toc}` directive. This PR 
adds the per-project organization (linking various markdown files together). 
This is not something we can infer automatically because we show different 
levels of nesting for each of the pages. Each project already has this 
description in their overview pages, and I am proposing we move them to the 
side bar:
 - http://spark.apache.org/docs/latest/streaming-programming-guide.html
 - http://spark.apache.org/docs/latest/sql-programming-guide.html
 - http://spark.apache.org/docs/latest/graphx-programming-guide.html
 - http://spark.apache.org/docs/latest/sparkr.html



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[mengxr]

Github user mengxr commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-158312175
  
@thunterdb Could you try the following CSS:

~~~css
.left-menu-wrapper {
  position: absolute;
  height: 100%;
  width: 256px;
  margin-top: -20px;
  padding-top: 20px;
  background-color: #F0F8FC;
}

.left-menu {
  position: fixed;
  width: 256px;
  padding-right: 10px;
}
~~~

It doesn't fix the issue with hiding the sidebar but makes the background 
lighter:

![screen shot 2015-11-19 at 11 38 05 
pm](https://cloud.githubusercontent.com/assets/829644/11294206/9d95f216-8f16-11e5-80f5-0f2843bc1c37.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[thunterdb]

GitHub user thunterdb opened a pull request:

https://github.com/apache/spark/pull/9826

[SPARK-11835] Adds a sidebar menu to MLlib's documentation

This PR adds a sidebar menu when browsing the user guide of MLlib. It uses 
a YAML file to describe the structure of the documentation. It should be 
trivial to adapt this to the other projects.

![screen shot 2015-11-18 at 4 46 12 
pm](https://cloud.githubusercontent.com/assets/7594753/11259591/a55173f4-8e17-11e5-9340-0aed79d66262.png)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/thunterdb/spark spark-11835

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/9826.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #9826


commit 831b3a114dfbf8b096e9fccfb4514d6dc9aeeb5f
Author: Timothy Hunter 
Date:   2015-11-19T01:05:35Z

work

commit 38fd759258a5b3cf93f569db480aa66833ab1830
Author: Timothy Hunter 
Date:   2015-11-19T01:06:02Z

clean

commit d67f0603f780c0a15206b7454875c88c0990eeb4
Author: Timothy Hunter 
Date:   2015-11-19T01:10:52Z

Merge remote-tracking branch 'upstream/master' into spark-11835




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[mengxr]

Github user mengxr commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-157932361
  
Great work! Shall we hide the side-nav-bar if width is not sufficient? See 
attached screenshot:

![screen shot 2015-11-18 at 6 45 11 
pm](https://cloud.githubusercontent.com/assets/829644/11260932/9c7e5ad2-8e24-11e5-99ae-003f98836d75.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-157915971
  
**[Test build #46280 has 
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46280/consoleFull)**
 for PR 9826 at commit 
[`d67f060`](https://github.com/apache/spark/commit/d67f0603f780c0a15206b7454875c88c0990eeb4).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-157919279
  
Test PASSed.
Refer to this link for build results (access rights to CI server needed): 
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/46280/
Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[SparkQA]

Github user SparkQA commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-157919180
  
**[Test build #46280 has 
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46280/consoleFull)**
 for PR 9826 at commit 
[`d67f060`](https://github.com/apache/spark/commit/d67f0603f780c0a15206b7454875c88c0990eeb4).
 * This patch passes all tests.
 * This patch merges cleanly.
 * This patch adds the following public classes _(experimental)_:\n  * 
`public final class UnsafeSorterSpillReader extends UnsafeSorterIterator 
implements Closeable `\n  * `  class CountVectorizerModelWriter(instance: 
CountVectorizerModel) extends Writer `\n  * `final class IDF(override val uid: 
String) extends Estimator[IDFModel] with IDFBase with Writable `\n  * `  class 
MinMaxScalerModelWriter(instance: MinMaxScalerModel) extends Writer `\n  * `  
class StandardScalerModelWriter(instance: StandardScalerModel) extends Writer 
`\n  * `  class StringIndexModelWriter(instance: StringIndexerModel) extends 
Writer `\n  * `class ALS(override val uid: String) extends Estimator[ALSModel] 
with ALSParams with Writable `\n  * `trait ScalaReflection `\n  * `  case class 
Schema(dataType: DataType, nullable: Boolean)`\n  * `s\"Unable to 
generate an encoder for inner class `$`\n  * `case class 
EncodeUsingSerializer(child: Expression, kryo: Boolean) extends UnaryExpression 
`\n  * `cas
 e class DecodeUsingSerializer[T](child: Expression, tag: ClassTag[T], kryo: 
Boolean)`\n


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[AmplabJenkins]

Github user AmplabJenkins commented on the pull request:

https://github.com/apache/spark/pull/9826#issuecomment-157919278
  
Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[mengxr]

Github user mengxr commented on a diff in the pull request:

https://github.com/apache/spark/pull/9826#discussion_r45293904
  
--- Diff: docs/_includes/nav-left-wrapper-ml.html ---
@@ -0,0 +1,6 @@
+
+ML
+{% include nav-left.html nav=include.nav-ml %}
+MLlib
+{% include nav-left.html nav=include.nav-mllib %}
+
--- End diff --

nit: new line at the end


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[mengxr]

Github user mengxr commented on a diff in the pull request:

https://github.com/apache/spark/pull/9826#discussion_r45293893
  
--- Diff: docs/_data/menu-ml.yaml ---
@@ -0,0 +1,10 @@
+- text: Feature extraction, transformation, and selection
+  url: ml-features.html
+- text: Decision trees for classification and regression
+  url: ml-decision-tree.html
+- text: Ensembles
+  url: ml-ensembles.html
+- text: Linear methods with elastic net regularization
--- End diff --

`elastic-net`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[mengxr]

Github user mengxr commented on a diff in the pull request:

https://github.com/apache/spark/pull/9826#discussion_r45293897
  
--- Diff: docs/_data/menu-mllib.yaml ---
@@ -0,0 +1,75 @@
+- text: Data types
+  url: /mllib-data-types.html
+- text: Basic statistics
+  url: /mllib-statistics.html
--- End diff --

ditto


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[mengxr]

Github user mengxr commented on a diff in the pull request:

https://github.com/apache/spark/pull/9826#discussion_r45293902
  
--- Diff: docs/_includes/nav-left-wrapper-ml.html ---
@@ -0,0 +1,6 @@
+
+ML
--- End diff --

Shall we use `spark.ml package` and `spark.mllib package` instead?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

[mengxr]

Github user mengxr commented on a diff in the pull request:

https://github.com/apache/spark/pull/9826#discussion_r45293895
  
--- Diff: docs/_data/menu-mllib.yaml ---
@@ -0,0 +1,75 @@
+- text: Data types
+  url: /mllib-data-types.html
--- End diff --

remove `/`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org